Bug 7 players - Githubissues

ExpeditionRPG / expedition

Expedition: The Cards & App RPG

https://ExpeditionGame.com

Other

78 stars 26 forks source link

Bug 7 players #823

Closed Lordtien closed 4 years ago

Lordtien commented 4 years ago

In the case of more than 6 players, a dialog saying "Too many players" open up. Peek 2020-01-29 17-05

Issue: Once the dialog is canceled, the splash screen sticks to the last state and requires an additional touch to reset. I need help there.

Fixes #811

Lordtien commented 4 years ago

@toddmedema As the PR description mentions, I need to reset the splash screen post dialog cancellation. I cannot find a way to do that. Can you provide some info?

toddmedema commented 4 years ago

You'd probably want to reset state to its initial value: https://github.com/ExpeditionRPG/expedition/blob/master/services/app/src/components/views/SplashScreen.tsx#L27

Lordtien commented 4 years ago

Update: Made the change. Here's a GIF (Player limit set to 0 for testing): Peek 2020-01-29 17-05