search

ExpeditionRPG / expedition

Expedition: The Cards & App RPG
https://ExpeditionGame.com
Other
79 stars 24 forks source link

Update dependency ws to v7.4.6 [SECURITY] - autoclosed #873

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 2 years ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 7.0.0 -> 7.4.6 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (https://github.com/websockets/ws/commit/00c425ec77993773d823f018f64a5c44e17023ff) and backported to ws@6.2.2 (https://github.com/websockets/ws/commit/78c676d2a1acefbc05292e9f7ea0a9457704bf1b) and ws@5.2.3 (https://github.com/websockets/ws/commit/76d47c1479002022a3e4357b3c9f0e23a68d4cd2).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

Release Notes

websockets/ws ### [`v7.4.6`](https://togithub.com/websockets/ws/releases/tag/7.4.6) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.5...7.4.6) ### Bug fixes - Fixed a ReDoS vulnerability ([`00c425e`](https://togithub.com/websockets/ws/commit/00c425ec)). A specially crafted value of the `Sec-Websocket-Protocol` header could be used to significantly slow down a ws server. ```js for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) { const value = 'b' + ' '.repeat(length) + 'x'; const start = process.hrtime.bigint(); value.trim().split(/ *, */); const end = process.hrtime.bigint(); console.log('length = %d, time = %f ns', length, end - start); } ``` The vulnerability was responsibly disclosed along with a fix in private by [Robert McLaughlin](https://togithub.com/robmcl4) from University of California, Santa Barbara. In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the [`--max-http-header-size=size`](https://nodejs.org/api/cli.html#cli_max_http_header_size_size) and/or the [`maxHeaderSize`](https://nodejs.org/api/http.html#http_http_createserver_options_requestlistener) options. ### [`v7.4.5`](https://togithub.com/websockets/ws/releases/tag/7.4.5) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.4...7.4.5) ### Bug fixes - UTF-8 validation is now done even if `utf-8-validate` is not installed ([`23ba6b2`](https://togithub.com/websockets/ws/commit/23ba6b29)). - Fixed an edge case where `websocket.close()` and `websocket.terminate()` did not close the connection ([`67e25ff`](https://togithub.com/websockets/ws/commit/67e25ff5)). ### [`v7.4.4`](https://togithub.com/websockets/ws/releases/tag/7.4.4) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.3...7.4.4) ### Bug fixes - Fixed a bug that could cause the process to crash when using the permessage-deflate extension ([`9277437`](https://togithub.com/websockets/ws/commit/92774377)). ### [`v7.4.3`](https://togithub.com/websockets/ws/releases/tag/7.4.3) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.2...7.4.3) ### Bug fixes - The deflate/inflate stream is now reset instead of reinitialized when context takeover is disabled ([#​1840](https://togithub.com/websockets/ws/issues/1840)). ### [`v7.4.2`](https://togithub.com/websockets/ws/releases/tag/7.4.2) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.1...7.4.2) ### Bug fixes - Silenced a deprecation warning ([`a2c0d44`](https://togithub.com/websockets/ws/commit/a2c0d447)). ### [`v7.4.1`](https://togithub.com/websockets/ws/releases/tag/7.4.1) [Compare Source](https://togithub.com/websockets/ws/compare/7.4.0...7.4.1) ### Bug fixes - Added a workaround for a double `'error'` event bug in Node.js < 13 which caused an uncaught error during the WebSocket handshake ([`38d6ab3`](https://togithub.com/websockets/ws/commit/38d6ab3b)). ### [`v7.4.0`](https://togithub.com/websockets/ws/releases/tag/7.4.0) [Compare Source](https://togithub.com/websockets/ws/compare/7.3.1...7.4.0) ### Features - The callback of `WebSocketServer.prototype.handleUpgrade()` now takes the client HTTP GET request as second argument ([`7d39f19`](https://togithub.com/websockets/ws/commit/7d39f19e)). ### Bug fixes - Read-only properties are now read-only ([`eabed8f`](https://togithub.com/websockets/ws/commit/eabed8fc)). - The `CONNECTING`, `OPEN`, `CLOSING`, `CLOSED`, `binaryType`, `bufferedAmount`, `extensions`, `onclose`, `onerror`, `onmessage`, `onopen`, `protocol`, `readyState`, and `url` properties are now enumerable ([`2069e68`](https://togithub.com/websockets/ws/commit/2069e684)). ### [`v7.3.1`](https://togithub.com/websockets/ws/releases/tag/7.3.1) [Compare Source](https://togithub.com/websockets/ws/compare/7.3.0...7.3.1) ### Bug fixes - Improved `websocket.bufferedAmount` accuracy ([`e1349c0`](https://togithub.com/websockets/ws/commit/e1349c04), [`a162942`](https://togithub.com/websockets/ws/commit/a1629426)). ### [`v7.3.0`](https://togithub.com/websockets/ws/releases/tag/7.3.0) [Compare Source](https://togithub.com/websockets/ws/compare/7.2.5...7.3.0) ### Features - `WebSocket.prototype.addEventListener()` now supports the `once` option ([#​1754](https://togithub.com/websockets/ws/issues/1754)). ### [`v7.2.5`](https://togithub.com/websockets/ws/releases/tag/7.2.5) [Compare Source](https://togithub.com/websockets/ws/compare/7.2.3...7.2.5) ### Bug fixes - Fixed compatibility with Node.js master ([`651d662`](https://togithub.com/websockets/ws/commit/651d6627)). ### [`v7.2.3`](https://togithub.com/websockets/ws/releases/tag/7.2.3) [Compare Source](https://togithub.com/websockets/ws/compare/7.2.2...7.2.3) ### Bug fixes - `WebSocket#{p{i,o}ng,close}()` now thow an error if the data to send is too large to fit in a control frame ([`e54f08d`](https://togithub.com/websockets/ws/commit/e54f08da)). ### [`v7.2.2`](https://togithub.com/websockets/ws/releases/tag/7.2.2) [Compare Source](https://togithub.com/websockets/ws/compare/7.2.1...7.2.2) ### Bug fixes - Fixed an issue where calling `webSocketStream.end()` could cause the process to crash ([`9535702`](https://togithub.com/websockets/ws/commit/9535702e)). - The connection is now closed if a non-masked frame is received on the server or a masked frame is received on the client ([#​1681](https://togithub.com/websockets/ws/issues/1681)). - The status code 1014 is now allowed to be used ([#​1682](https://togithub.com/websockets/ws/issues/1682)). ### [`v7.2.1`](https://togithub.com/websockets/ws/releases/tag/7.2.1) [Compare Source](https://togithub.com/websockets/ws/compare/7.2.0...7.2.1) ### Bug fixes - Added `bufferutil` and `utf-8-validate` as peer dependencies ([#​1626](https://togithub.com/websockets/ws/issues/1626)). ### [`v7.2.0`](https://togithub.com/websockets/ws/releases/tag/7.2.0) [Compare Source](https://togithub.com/websockets/ws/compare/7.1.2...7.2.0) ### Features - Added ability to specify the `readableObjectMode` option when using `WebSocket.createWebSocketStream()` ([#​1647](https://togithub.com/websockets/ws/issues/1647)). ### [`v7.1.2`](https://togithub.com/websockets/ws/releases/tag/7.1.2) [Compare Source](https://togithub.com/websockets/ws/compare/7.1.1...7.1.2) ### Bug fixes - Fixed a bug that caused compress jobs to never be marked as complete ([#​1618](https://togithub.com/websockets/ws/issues/1618)). ### [`v7.1.1`](https://togithub.com/websockets/ws/releases/tag/7.1.1) [Compare Source](https://togithub.com/websockets/ws/compare/7.1.0...7.1.1) ### Bug fixes - An error is now thrown if the `WebSocket` server constructor is used incorrectly ([`3641266`](https://togithub.com/websockets/ws/commit/36412662)). ### [`v7.1.0`](https://togithub.com/websockets/ws/releases/tag/7.1.0) [Compare Source](https://togithub.com/websockets/ws/compare/7.0.1...7.1.0) ### Features - Added utility to wrap a `WebSocket` in a `Duplex` stream ([#​1589](https://togithub.com/websockets/ws/issues/1589)). ### Bug fixes - Reverted "\[minor] Remove unneeded `if` statement" ([`dbacf58`](https://togithub.com/websockets/ws/commit/dbacf582), [#​1591](https://togithub.com/websockets/ws/issues/1591)). ### [`v7.0.1`](https://togithub.com/websockets/ws/releases/tag/7.0.1) [Compare Source](https://togithub.com/websockets/ws/compare/7.0.0...7.0.1) ### Bug fixes - Added ability to disable sending the SNI extension ([#​1587](https://togithub.com/websockets/ws/issues/1587)).

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Mend Renovate. View repository job log here.