ExpeditionRPG / expedition

Expedition: The Cards & App RPG
https://ExpeditionGame.com
Other
79 stars 24 forks source link

Remove buggy ids from cards in card creator #878

Closed smartin015 closed 2 years ago

smartin015 commented 2 years ago

Turns out, we don't need no stinkin' ID's. They're not referenced anywhere, sometimes they aren't even added, and the 2 of 3 different ways they're implemented are broken:

id={camelCase(card.name)} - this is fine, but not referenced anywhere.

id={camelCase(name)} - I don't think name is even declared, and I'm not sure how this doesn't cause errors normally (it does break the site on some card sets though, like Future).

id="{{camelCase name }}" - what.

So I removed them, and everything still works. Also ripped out camelCase from helpers.tsx and explicitly set zero dependencies in the package.json file.

Fixes bug uncovered by work on #871.