Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414

Open kbecciv opened 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR https://github.com/Expensify/App/pull/10194

Action Performed:

case 1

  1. Access staging.new.expensify.com
  2. Sign into a valid user
  3. Click on the "Global action" button (Big green plus button in LHN)
  4. Click New Chat

case 2

  1. Go to https://staging.new.expensify.com/
  2. Login with expensifail account
  3. Create a Workspace
  4. Tap "+"
  5. Tap "New Room"

case 3

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to settings > security > change password

case 4

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to some DM
  4. Open the in app emoji picker
  5. Select some emoji

Expected Result:

Keyboard is open and cursor focused when entering the new screen

Actual Result:

Keyboard won't open

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Case 1

https://user-images.githubusercontent.com/93399543/185005745-73a26290-2721-4b14-b3bd-ba0553a2a0a8.mp4

Case 2

https://user-images.githubusercontent.com/93399543/195383970-9354b2d0-cffc-4b1d-b5d2-2804c2462a5e.mp4

Case 3

https://user-images.githubusercontent.com/43995119/190952432-d072befe-c01d-404e-92fd-b6c71ff230c9.mov

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Tea

Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

NicMendonca commented 1 year ago

job post: https://www.upwork.com/jobs/~01f21a08ef50dd0283

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @sketchydroide (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

busyboxww commented 1 year ago

The text is not having top "priority" or the list is getting auto focus. You should give change the layout, something zIndex or ... set focus programmatically.

rushatgabhane commented 1 year ago

Interesting.. it tested well when I added screenshots for PR https://github.com/Expensify/App/pull/10194

rushatgabhane commented 1 year ago

I can't repro this bug on mWeb iOS, and mWeb Android. v 1.1.89-1

mWeb iOS Safari

https://user-images.githubusercontent.com/29673073/186508861-e30fecf7-d584-4118-9b00-083c5e661694.mov

mWeb Android Chrome

https://user-images.githubusercontent.com/29673073/186509173-15482710-c717-44f9-9e3e-46d97ee19b23.mp4

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

NicMendonca commented 1 year ago

@rushatgabhane are you recommending that I close this?

rushatgabhane commented 1 year ago

@NicMendonca not exactly. Let's close this bug if @kbecciv cannot repro it either

kbecciv commented 1 year ago

@rushatgabhane Issue is reproduced with latest build 1.1.94.4

https://user-images.githubusercontent.com/93399543/187564523-ea61b4d2-b8ff-4d5f-a70f-2d42605dc211.MP4

NicMendonca commented 1 year ago

Still reproducible ☝️

rushatgabhane commented 1 year ago

@parasharrajat what should we do? (i still can't reproduce it)

parasharrajat commented 1 year ago

I will check it later.

parasharrajat commented 1 year ago

I am able to reproduce this. iPhone 13 (iOS 15). I feel like maybe this is happening due to the banner. The banner is not visible when a new chat page is opened and there is empty space below the modal. This empty seems equal to the banner height.

image

sketchydroide commented 1 year ago

@parasharrajat did you have time to look into this?

parasharrajat commented 1 year ago

I already did https://github.com/Expensify/App/issues/10414#issuecomment-1238555503. Are you talking about something else?

I am open to proposals.

sketchydroide commented 1 year ago

no sorry, it's weird, but I' sure I did not have you comment with the screenshot when I wrote my comment, maybe GH did not refresh it, weird.

NicMendonca commented 1 year ago

price doubled - https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca commented 1 year ago

doubled: https://www.upwork.com/jobs/~01f21a08ef50dd0283

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

NicMendonca commented 1 year ago

doubled: https://www.upwork.com/jobs/~01f21a08ef50dd0283

mallenexpensify commented 1 year ago

Is the issue I'm facing the same as this one? On desktop, staging, v1.2.15-2

Same for when I click on a chat in LHN, cursor doesn't show in compose box

parasharrajat commented 1 year ago

That sounds like a new issue and I saw a bug report for it somewhere. This issue is concerned on the search box on the new chat and new group page.

mallenexpensify commented 1 year ago

Thanks @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1665792005925189

NicMendonca commented 1 year ago

doubled price: https://www.upwork.com/jobs/~01f21a08ef50dd0283

parasharrajat commented 1 year ago

@NicMendonca Should we merge all of the mentioned issues into this https://github.com/Expensify/App/pull/11794#issuecomment-1280776271. cc: @sketchydroide

NicMendonca commented 1 year ago

@parasharrajat maybe open up a discussion in slack?

parasharrajat commented 1 year ago

@sketchydroide What do you think of https://github.com/Expensify/App/issues/10414#issuecomment-1285514867?

sketchydroide commented 1 year ago

They do feel like all being the same issue @parasharrajat I think we can merge them

parasharrajat commented 1 year ago

Who can help with that? I don't have access to do that.

sketchydroide commented 1 year ago

I think I can do it It's just closing the other and mantainng one, also probably updating the description, let me see if I can do that myself.

puneetlath commented 1 year ago

@NicMendonca @sketchydroide it sounds like we're closing this issue, is that right? If so, can one of you go ahead and do it?

parasharrajat commented 1 year ago

We are not closing this one. Instead, merge other issues into this and close those. I don't have access to modify it so I am waiting on someone to take up on that.

NicMendonca commented 1 year ago

@sketchydroide were you able to do that based on this comment?

sketchydroide commented 1 year ago

yep the others are now closed

sketchydroide commented 1 year ago

lets continue this here

parasharrajat commented 1 year ago

Thanks, @sketchydroide. Could you please update the description to add more details about other issues? Adding those pages and steps to those issues will be enough.

We can also generalize the Expected behavior and title.

JmillsExpensify commented 1 year ago

@tgolen Another one to put on our radar. Shall we add it to the tracking issue?

sketchydroide commented 1 year ago

Thanks, @sketchydroide. Could you please update the description to add more details about other issues? Adding those pages and steps to those issues will be enough.

Sure @parasharrajat

sketchydroide commented 1 year ago

Ok Updated, I'm not sure if the fact that we have 3 instances where this happens can be a bit confusing on the description, but I'll take any suggestions on how we can improve that.

tgolen commented 1 year ago

@tgolen Another one to put on our radar. Shall we add it to the tracking issue?

It's probably a different problem than the ones in that tracking issue. I think this is more of an auto-focus problem, rather than a problem with views being obscured by the keyboard.

JmillsExpensify commented 1 year ago

Gotcha, thanks for the second opinion!

melvin-bot[bot] commented 1 year ago

@sketchydroide, @parasharrajat, @NicMendonca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

NicMendonca commented 1 year ago

Updated the job name on Upwork, and doubled the price: https://www.upwork.com/jobs/~01f21a08ef50dd0283

kavimuru commented 1 year ago

12439

NicMendonca commented 1 year ago

I am about to go OOO for a week, so re-assigning.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

s77rt commented 1 year ago

@kbecciv @parasharrajat Can you still reproduce? I can only reproduce the "New Chat" issue but I think it's related to another root cause