search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Deploy Checklist: New Expensify 2022-09-01 #10748

Closed OSBotify closed 2 years ago

OSBotify commented 2 years ago

Release Version: 1.1.96-5 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

cc @Expensify/applauseleads

OSBotify commented 2 years ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.96-0 :rocket:

mvtglobally commented 2 years ago

Regression is completed

Deploy Blockers https://github.com/Expensify/App/issues/10442 https://github.com/Expensify/App/issues/10751 https://github.com/Expensify/App/issues/10753 https://github.com/Expensify/App/issues/10754 https://github.com/Expensify/App/issues/10756 https://github.com/Expensify/App/issues/10757 https://github.com/Expensify/App/issues/10759

PR https://github.com/Expensify/App/pull/9532 is failing due to https://github.com/Expensify/App/issues/10751 & https://github.com/Expensify/App/issues/10766 PR https://github.com/Expensify/App/pull/10556 is failing due to https://github.com/Expensify/App/issues/10758. PR https://github.com/Expensify/App/pull/10582 & https://github.com/Expensify/App/pull/10717 are failing due to https://github.com/Expensify/App/issues/10751

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.96-1 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-1 has been deployed to staging :tada:

roryabraham commented 2 years ago

Tried reverting https://github.com/Expensify/App/pull/10582 and was able to reproduce the crash on that branch, so I don't think it's that

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.96-2 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-2 has been deployed to staging :tada:

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.96-4 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-4 has been deployed to staging :tada:

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.96-5 :rocket:

luacmartins commented 2 years ago

@mvtglobally @kbecciv can you still reproduce the following issues?

We are having issues reproducing these locally and on staging.

mvtglobally commented 2 years ago

@luacmartins we will check and confirm in a bit

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-5 has been deployed to staging :tada:

mvtglobally commented 2 years ago

We are re-testing PR https://github.com/Expensify/App/pull/9532, https://github.com/Expensify/App/pull/10582 & https://github.com/Expensify/App/pull/10717 which were failing due to https://github.com/Expensify/App/issues/10751 Checking CP as well

AndrewGable commented 2 years ago

Thank you @mvtglobally, we have completed all blockers so please let us know when you are finished!

Julesssss commented 2 years ago

This Firebase Exception is possibly a new regression. 12 unique users and only occuring on this version.

The alternative is that this was one of the reported blockers, is now fixed, and can be closed.

AndrewGable commented 2 years ago

Exported here and fixed already! 🎉

mvtglobally commented 2 years ago

Checking off https://github.com/Expensify/App/pull/9532 & https://github.com/Expensify/App/pull/10717

CP https://github.com/Expensify/App/pull/10780 is failing due to https://github.com/Expensify/App/issues/10799. Its a new feature, Ok to checkoff or mark as Blocker? I dont think we can test #10764. Ok to check off?

@AndrewGable @roryabraham Can you confirm if https://github.com/Expensify/App/pull/10582 was reverted? Should we test it or can just check off?

AndrewGable commented 2 years ago

https://github.com/Expensify/App/pull/10582 was not reverted and should be tested still. Looking into others!

AndrewGable commented 2 years ago

Checked off https://github.com/Expensify/App/pull/10764 as it was reverted shortly after.

PauloGasparSv commented 2 years ago

I think we can check https://github.com/Expensify/App/pull/10780 off as @mvtglobally said and address that on the follow up issue if that's ok! Because the offline-first and delete functionality are working despite the message quickly popping up before being deleted when toggling!

Is that ok?

mvtglobally commented 2 years ago

PR https://github.com/Expensify/App/pull/10556 is failing due to https://github.com/Expensify/App/issues/10758. Still seems to be broken

https://user-images.githubusercontent.com/43995119/188182783-3239f950-70cf-4c10-b6ed-3cdd69eec887.mp4

https://user-images.githubusercontent.com/43995119/188182794-0525f061-12f9-461f-ae41-c81cc791b7a4.mp4

luacmartins commented 2 years ago

@mvtglobally can you test with an account that hasn't attempted to send the link more than 3 times? I think the reason the message doesn't show up is because we never send the link since that account is throttled.

For now, the error message won't show up the first time you click Forgot? since we will fix the error message in a follow up PR in our API layer.

mvtglobally commented 2 years ago

Checking off https://github.com/Expensify/App/pull/10582 - retest pass. https://github.com/Expensify/App/pull/10556 is the last one left.

bondydaa commented 2 years ago

yep agreed can you confirm that you're not actually throttled in these https://github.com/Expensify/App/issues/10748#issuecomment-1235633455?

Users are throttled after on the 4th attempt within 5 minutes of each other: so you should be able to click it 3 times and get magic links sent and then a 4th should give you that error.

mvtglobally commented 2 years ago

New account seem ok. When you use re-set password it is showing automatically the message,

But can you guys re-validate this last one internally as well, to make sure we dont miss anything here.

https://user-images.githubusercontent.com/43995119/188198243-4d8d5a64-1c9e-4a64-9788-f8ec447f5562.mp4

bondydaa commented 2 years ago

When you use re-set password it is showing automatically the message

yep that's expected for now will be fixed on https://github.com/Expensify/App/issues/10785.

I just tried this myself (hours after those initial attempts) and got the same message for those accounts which is unexpected

image

logs https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22744792dfda233839-SAN%22)+AND+timestamp:[2022-09-02T15:20:33.984Z+TO+2022-09-02T17:20:33.984Z]&index=logs_expensify-018393

744792dfda233839-SAN | 2022-09-02 16:20:33 987 | mnata.utest+sr@gmail.com | undefined | db1.sjc | [audit] User just got throttled because they reached 3 number of calls for resendValidateCode
dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
 name = private_throttleAttempts_resendValidateCode
value = [1662135599059757,1662135601949561,1662135632575400,1662135633987843]

 name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662135599059930,1662135601949716,1662135632575547]

 name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]

But if anything this is something broken in auth not this code - new dot is actually handling this well and showing us the error now 🎉

mvtglobally commented 2 years ago

@bondydaa Are we ok to check it off then?

bondydaa commented 2 years ago

hm strange and I just tried again and it worked fine for mnata.utest+sr@gmail.com

image

looking at the db again, the throttle attempts had been cleared out and only 2 show now

dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
 name = private_throttleAttempts_resendValidateCode
value = [1662138028209658,1662138031477769]

 name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662138028209808,1662138031477953]

 name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]
dbondy@db2.rno:~$

Just copying over from Slack I tested with a brand new account

  1. created a new account, clicked resend validation link 3 times and got this image (1)
  2. on the 4th click of resend validation link got the error as expected: image (2)
  3. And got 4 emails as expected (when you first create the account we send you a validation link and then the 3 from the repeated clicking of resend validation link). image (3)

So yep I think 👍 to check it off.

mvtglobally commented 2 years ago

We are good to 🚀 then

Julesssss commented 2 years ago

Awesome, we're good to deploy first thing this morning.

Julesssss commented 2 years ago

From testing the app I'm still unable to find any exception. Going to move forward as Applause's checklist would have picked up on any noticable regression.

Julesssss commented 2 years ago

:shipit: