search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

Closing certain pages (drawers) navigates to the wrong URL #11111

Closed jasperhuangg closed 1 year ago

jasperhuangg commented 2 years ago

Action Performed:

Connect bank account page (https://github.com/Expensify/App/issues/10939):

  1. Open web app https://new.expensify.com/
  2. Click on user icon on LHN to open setting.
  3. Click on user's workspace.
  4. Click on Connect bank account.
  5. Click on close icon on top right.

Default room participant detail page (https://github.com/Expensify/App/issues/10989):

  1. Go to staging.new.expensify.com and log in with any account
  2. Click on any default room (workspace room)
  3. Click on header to open details page > settings > go back by clicking back button >
  4. Click on members > any member.
  5. Click on close button

Paypal.me payments page (https://github.com/Expensify/App/issues/10991):

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Open settings page > Workspace > Manage members
  4. Select Invite member and close the page
  5. Open settings page > payments > Add payment method > Paypal
  6. Close the page

Closing App download links page in settings page is causing incorrect URL settings/about instead of r/reportId https://github.com/Expensify/App/issues/11350

  1. Login in web app.
  2. Open settings page > profile > click add phone number
  3. Click on back arrow on this page to navigate to profile page.
  4. Click on back arrow to navigate to settings page.
  5. Click on about > app download links.
  6. Click on cross (x) to close app download links page.

Expected Result:

The URL should display correctly

Actual Result:

The URL is incorrect. Namely, the URL that is shown should have already been popped off of the navigation stack (is it the URL for a previous page).

Workaround:

Yes

Platform:

Where is this issue occurring?

Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @aneequeahmad (from https://github.com/Expensify/App/issues/10989) Slack conversation:

View all open jobs on GitHub

cc @parasharrajat

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 years ago

Whoops! This issue is 2 days overdue. Let's get this updated quick!

aneequeahmad commented 2 years ago

I see all of these issues are combined so it's easy to track them for engineers and QA team. Just a quick question would it will be considered one bug bounty for reporting all of these issues ? Almost all the bugs are reported by me and I have spent a lot of time on debugging and finding these issues.

cc: @parasharrajat, @flodnv

flodnv commented 2 years ago

@jasperhuangg any thoughts? And why is this on HOLD? 😕

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

jasperhuangg commented 2 years ago

@flodnv @aneequeahmad apologies for the lack of response, was out sick last week

I think we can still compensate you for reporting each of the issues separately, since I do recognize that it requires some time to find them even if they have the same source.

@parasharrajat recommended we HOLD this issue on navigation, can you clarify why?

melvin-bot[bot] commented 2 years ago

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

parasharrajat commented 2 years ago

@jasperhuangg New design doc for navigation is in planning that's why I suggested holding this like other navigation issues.

It seems like @puneetlath kick-started it https://expensify.slack.com/archives/C01GTK53T8Q/p1664825958481829.

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

MitchExpensify commented 2 years ago

I'm a little confused on what to do with this collection of issues. Mind pointing me in the right direction @mallenexpensify ?

mallenexpensify commented 2 years ago

There is no direction Mitch!!!! @jasperhuangg is this more of a tracking issue right now? I'm unsure if anything is currently actionable

michaelhaxhiu commented 2 years ago

IMO this shouldn't be daily if it's on hold. It should go to monthly till it's ready to move on it

puneetlath commented 2 years ago

Jason will be the BZ person for navigation issues, so assigning to him.

melvin-bot[bot] commented 1 year ago

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

JmillsExpensify commented 1 year ago

We discussed in Slack, but to reiterate here, @puneetlath is trying new methods to get in contact with the maintainer. We're unfortunately dead in the water and still on hold until we can get in touch.

JmillsExpensify commented 1 year ago

Also just realized that this issue isn't linked to the tracking issue. Adding that here as well as the title. https://github.com/Expensify/App/issues/11768

melvin-bot[bot] commented 1 year ago

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

JmillsExpensify commented 1 year ago

Still blocked on clear next steps in the main tracking issue.

melvin-bot[bot] commented 1 year ago

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

JmillsExpensify commented 1 year ago

Still on hold.

melvin-bot[bot] commented 1 year ago

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

JmillsExpensify commented 1 year ago

Yes, but this is on hold Melvin. Switching out daily for weekly.

JmillsExpensify commented 1 year ago

Still holding.

JmillsExpensify commented 1 year ago

Still held as we go through the design process.

JmillsExpensify commented 1 year ago

Still held on the larger react navigation reboot.

JmillsExpensify commented 1 year ago

Still on hold for the larger navigation reboot.

JmillsExpensify commented 1 year ago

Still on hold for navigation.

JmillsExpensify commented 1 year ago

Held on navigation revamp.

JmillsExpensify commented 1 year ago

Still held on the navigation revamp.

JmillsExpensify commented 1 year ago

Still on hold for navigation. No ETA.

JmillsExpensify commented 1 year ago

Same same.

JmillsExpensify commented 1 year ago

Still on hold.

JmillsExpensify commented 1 year ago

Still on hold

JmillsExpensify commented 1 year ago

Coming off hold very soon!

JmillsExpensify commented 1 year ago

Alright, I've gone through each of the linked issues, run through the reproduction steps, confirmed that they are all resolved. I'm handling next steps in the linked issues, closing this main tracking issue out as a result.