search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

UI - Border radius of attached protected pdf does not match with parent component #11520

Closed kbecciv closed 1 year ago

kbecciv commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any conversation
  3. Send password protected pdf
  4. Notice blue border of protect attachment
  5. Notice there is white space in all corner

Expected Result: Blue border radius of protected pdf should match with parent component

Actual Result:

Blue border radius of protected pdf does not match with parent component (leaves white spaces in corner)

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot_20221002-135136_New Expensify image (5) image (6)

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664363401205419

View all open jobs on GitHub

sketchydroide commented 1 year ago

Now in Prod

sketchydroide commented 1 year ago

Screenshot 2022-11-22 at 14 17 24 confirmed, closing

dhairyasenjaliya commented 1 year ago

hello @sketchydroide @JmillsExpensify Upwork job for reporting the issue is missing

dhairyasenjaliya commented 1 year ago

Bump for Upwork job for reporting the issue @JmillsExpensify

JmillsExpensify commented 1 year ago

Ah for clarity, the US is currently on holiday. Let me create a quick job for you though since it seems we're both online.

JmillsExpensify commented 1 year ago

Upwork job is here: https://www.upwork.com/jobs/~01ca1e43be96f08f0e.

dhairyasenjaliya commented 1 year ago

Appied , Ah I see sorry for trouble have a great holiday @JmillsExpensify

JmillsExpensify commented 1 year ago

Not a problem! Let's get this settled for you, as I'm online. Just sent you an offer via Upwork. 🙌🏼

dhairyasenjaliya commented 1 year ago

Accepted offer @JmillsExpensify

JmillsExpensify commented 1 year ago

Payment issue and contract closed! You should be all set now, let me know if I can help with anything else.

dhairyasenjaliya commented 1 year ago

All good thank you👍 @JmillsExpensify