[HOLD for payment 2023-02-15] [N7 Account Settings] Create Date of Birth page

[Beamanator]

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.76axa86bvakz

Note: This can not be completely implemented until the UpdateDateOfBirth command has been implemented - see https://github.com/Expensify/Expensify/issues/231916

[Beamanator]

On hold for WhatsApp Quality

[Beamanator]

Still on hold for now, might pick this up next week as discussions from here (https://github.com/Expensify/App/issues/11795) are indicating this could be useful to implement sooner rather than later

[Beamanator]

Unassigning since k2 is not liking that i have so many issues assigned to me on hold, will get back to this once N7 Account Settings if off hold

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Beamanator]

Monthly is fine, still waiting for WAQ to wrap up

[Beamanator]

Picking this back up!

[Beamanator]

App PR is still in review

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[fedirjh]

@Beamanator the is a bug with DateOfBirthPage , the header is missing the title for the birthday , we can fix that by adding this line to DateOfBirthPage

<HeaderWithCloseButton
    shouldShowBackButton
    title={this.props.translate('common.dob')} // this line is missing
    onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_PERSONAL_DETAILS)}
    onCloseButtonPress={() => Navigation.dismissModal(true)}
/>

Before	After

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.67-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/14290

If no regressions arise, payment will be issued on 2023-02-15. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Beamanator]

Closing in favor of doing payment in https://github.com/Expensify/App/issues/11578

Also @fedirjh please report any bugs you find in #expensify-bugs, and just so you know that missing page title is not a big, it was a design decision (we may change later)