[HOLD for payment 2023-04-26] Update sign up/sign in screen imagery to match new branding

[shawnborton]

Note: This issue is part of the greater Implement Our New Branding in NewDot project.

What is it: Updating the home page and sign up flow in the app to include our new illustrations. We’ll need to consider what this looks like for both mobile and desktop. Note that this may be adjusted based on passwordless flow.

Mini Design Doc can be found here: https://docs.google.com/document/d/1NxVst1XupNYpLVgknXPPlaQ2wAuR7-_8OmH442mQrzc/edit#

Does it require a mini design doc: Yes, this requires code changes

Design finished: No

cc @GabiHExpensify

[melvin-bot[bot]]

Auto-assign attempt failed, all eligible assignees are OOO.

[sketchydroide]

Happy to take this one, including helping with the design doc

[JmillsExpensify]

Nice, when do you expect to have a pre-design discussion kicked off? Let's start there.

[sketchydroide]

I think there are 2 main different things to change/update, the assets (images) and the style (colours, fonts, spacing, etc)

Images can be specific to each page, but styles might be common across the different screens.

Are we changing the style of the text @shawnborton? The Font feel different.

[sketchydroide]

I assume this has not been has important as WAQ so it will be kept in monthly?

[JmillsExpensify]

Good question. What are your thoughts there? I think there's an argument either way.

[shawnborton]

I think this still technically falls under WAQ Branding so we should treat it with urgency, and that's my bad for not having much progress to show yet.

[JmillsExpensify]

Cool, thought you'd say that. Sound good to me, and no worries!

[sketchydroide]

@shawnborton shall I start writing the mini doc for this? I think I mostly need to understand what parts of the app will be changed, not exaclty the how the design is going to look, so if I can just go from the images you shared on the GH I think I have something to start working on. Also we should probably move this to a least weekly so we can keep updating it.

Does this sound good? (I'm updating if you disagree we can move it back again :) )

[sketchydroide]

@shawnborton any input on the above :)

[shawnborton]

Hey Andre - sorry for the delay here. We had TCW explore this one last week and we'll provide some feedback to them today for where to take it next.

In terms of a mini design doc, that is totally your call - maybe let's wait to see the final proposed design changes and you can make the call from there? I do think there will be some considerations for mobile vs desktop, but otherwise I am hoping this is fairly straightforward.

[sketchydroide]

ok, will wait, where can I keep track of the changes, is there a slack thread for this?

[shawnborton]

Head over to the #expensify-tcw room, latest exploration is here.

[sketchydroide]

I think we are still waiting here

[shawnborton]

Okay, I think this is the version we're going with:

[sketchydroide]

will the new list of links be part of this rebranding, I would say at the moment that no, and we will leave that part empty on this project, as it's not exaclty rebranding, but a new feature. If it is, it's going to be a slighlty larger project (not a lot though) but I've started to write the mini doc so just need to know if I should include those or not.

[sketchydroide]

@shawnborton are we loosing the way we can tell if the app is in Staging or Dev (and Prod) This is now on the logo, but that seems to have been replaced the full Expensify one

[shawnborton]

We can probably add a small "stg" or "dev" icon near the wordmark, so no worries there.

For the footer links, we can certainly do them as a separate PR/issue if you would like to.

[sketchydroide]

We can probably add a small "stg" or "dev" icon near the wordmark, so no worries there.

sounds good, once we have a figma and assets going I can take care of that

For the footer links, we can certainly do them as a separate PR/issue if you would like to.

Can totally be part of this one, this one will be best to split into smaller GHs regardless, so adding a couple more to add the list of links is totally fine.

I mostly want to know if that already has a different GH or has anyone started working on it.

[shawnborton]

sounds good, once we have a figma and assets going I can take care of that

Cool, in the meantime though feel free to get started on this project and I'll follow up with the logo assets.

I mostly want to know if that already has a different GH or has anyone started working on it.

Got it, yeah I think that's a good question for @LLPeckham and @joaniew but I don't think individual GHs have been broken out just yet.

[sketchydroide]

This is a rough start for the document, but I've started it

[shawnborton]

Ah, I thought we were going to keep the footer changes separate for now and just plan to update the landing screen for the Sign In/Up page. If that's the case, do you think we need a design doc to implement the new sign in screen imagery?

[sketchydroide]

I don't mind not having a design doc, but in the description of the GH it does say that it needs a Mini Doc. As for the footer changes I don't make a point of having it be part of this changes, I'm fine either way, I do need to take in account that they will be there, but that is not a big deal regardless. Also is not a particular big set of work, it's a list of links each one with an header, it can be pretty much one GH.

[shawnborton]

Ah, I forgot I had mentioned mini design doc in the original comment. I guess it can't hurt to have one, it would almost be like a formal contributor proposal so that we can take a look at some ideas for code before you start building? cc @JmillsExpensify in case you feel strongly one way or the other there

[shawnborton]

Hey @sketchydroide - any update here? This is one of the remaining pieces of implementing our new brand into NewDot. Let me know if you need any help!

[sketchydroide]

Back from OOO, will start working on it more consistently, this week I want to see if I can get the technical part writen.

[JmillsExpensify]

@shawnborton I haven't followed this closely, though it is the home page. I'd expect people to have lots of opinions on our approach given that this is prime real estate. So probably better to do a mini-design doc, yes.

[shawnborton]

Hey @sketchydroide how is progress going on the design doc? It looks like the last edit was January 4th, so just seeing if you think you'll hit your goal of having the technical part written this week?

[sketchydroide]

Will work on this today again, should we move this up to daily?

[shawnborton]

That makes sense to me

[sketchydroide]

Do we have a figma for the new UI yet? it will make it easier to write the tech part.

[shawnborton]

Here ya go: https://www.figma.com/file/OgM6vzR98Qnr1gdmZOQPKz/Implement-Our-New-Brand?node-id=88%3A11872&t=3rvPLjUw5HyfTREa-1

All the way off on the right of that screen is the final version

[sketchydroide]

thanks

[sketchydroide]

Continue to work on this today. Will try to write some of the code in the doc and have a few people reviewing the non tech part

[sketchydroide]

will continue writting this today

[sketchydroide]

I'm still updating the doc, starting to look at some code, and what needs to be changed, the non technical part should be ready next week

[shawnborton]

Not overdue. That being said, @sketchydroide I took at look at the design doc and it doesn't feel like too much progress has been made. Do you have an estimate of when you think you'll have this finished?

[sketchydroide]

I will be able to really focus on it this week, so I think by the end of the week it will be ready for some reviews

[sketchydroide]

added some WIP code to the Doc yesterday, will continue today

[sketchydroide]

The Doc has most of the code for each component. It's mostly pseudo code for the components.

@shawnborton I would apreciate some help creating or writing the styles for the components.

[sketchydroide]

Will start asking for some people to have a look, and make some suggestions I think tech part is close, will work a bit more on it today

[sketchydroide]

Will continue working on the doc tomorrow, I've had some good feedback

[shawnborton]

I would apreciate some help creating or writing the styles for the components.

Feel free to just tag me in the doc where you'd like some help/input!

[sketchydroide]

I think the HL part is very close, just going trough some comments from some people I asked for an early review, and we should have it ready today or early next week

[shawnborton]

@sketchydroide do you have an update for us today?

[sketchydroide]

Sorry was OOO yesterday I'll see if anything is missing, and if not I think we can the HL ready for general review

[shawnborton]

For the other brand design doc, we just made it a mini doc with a combined high/detailed section. Is that your plan, or are you planning to take the more traditional design doc route? It's ultimately up to you, but I think at this point people have agreed upon the problem and the high level solution (the mockups) - we mostly just want to get crisp on the implementation details, aka detailed.

[sketchydroide]

I've been asked to follow the Manifesto guidelines and get the HL first, I agree that we want to get to the implementation details, happy to restart that if everyone agrees

[shawnborton]

Got it. Well, let's try to get an expeditious review then. Let us know when the DD is ready, thanks!

[sketchydroide]

I think we are all good, pre reviews seem happy with the Doc, will start the process for letting anyone review later today