Deploy Checklist: New Expensify 2022-11-15

OSBotify commented 1 year ago

Release Version: 1.2.28-2 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Internal QA:

[x] https://github.com/Expensify/App/pull/12429 - @tgolen @arosiclair

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/12760

Deployer verifications:

[x] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[x] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

OSBotify commented 1 year ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.28-0 :rocket:

dangrous commented 1 year ago

Working on internal QA for https://github.com/Expensify/App/pull/12429 - we may need some edits - I've posted a comment on the PR.

arosiclair commented 1 year ago

Thanks for taking over QA on that one. Just saw this now

OSBotify commented 1 year ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.2.28-1 :rocket:

OSBotify commented 1 year ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.28-1 has been deployed to staging :tada:

mvtglobally commented 1 year ago

@roryabraham We are blocked on Desktop due to https://github.com/Expensify/App/issues/12760

roryabraham commented 1 year ago

A fix for https://github.com/Expensify/App/issues/12760 is being CP'd to staging presently

OSBotify commented 1 year ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.2.28-2 :rocket:

roryabraham commented 1 year ago

https://github.com/Expensify/App/pull/12785 has been deployed on all platforms except iOS, so you should be able to retest https://github.com/Expensify/App/issues/12760 at any time and resume regressions

mvtglobally commented 1 year ago

thanks @roryabraham we will resume

roryabraham commented 1 year ago

Confirmed https://github.com/Expensify/App/issues/12760 is resolved, checking it off

mvtglobally commented 1 year ago

Regression is completed

roryabraham commented 1 year ago

Checked off https://github.com/Expensify/App/pull/12572
https://github.com/Expensify/App/pull/12588 isn't relevant because that flow isn't accessible due to https://github.com/Expensify/App/issues/12776

PR https://github.com/Expensify/App/pull/12601 https://github.com/Expensify/App/pull/12695 & https://github.com/Expensify/App/pull/12697 are PROD QA of Help pages. Ok to check off?

While they are PROD QA, keep in mind that help pages are deployed immediately so can be QA'd at any time. Usually this will be very quick so for now while we don't have a prodQA checklist we should just do them during the main checklist. There's also no scenario where we'd have a help site deploy blocker, so there's not much risk involved with these..

https://github.com/Expensify/App/pull/12785

Confirmed myself that this works so we should be good to check it off.

https://github.com/Expensify/App/pull/12429 doesn't work perfectly but we do not need to block deploy since the code for the workflow runs from main anyways we can fix it regardless of the release cycle. I know that @tgolen and @dangrous are investigating. Checking it off to proceed with the deploy.

roryabraham commented 1 year ago

I am seeing a spike in homepage initial render, but it seems probably that this could be attributed to the process change ensuring that people test on high traffic accounts.

roryabraham commented 1 year ago

There is a new crash too, but I think it's only happening in UIAutomator, which unless I'm mistaken is only related to E2E automated tests, which aren't live yet.

roryabraham commented 1 year ago

:shipit:

Expensify / App

Deploy Checklist: New Expensify 2022-11-15 #12753