search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Payments - Default label isn't stick to the personal account after added as default payment, but it works while offline #12950

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com
  2. Went to Workspace > Connect Bank Account and added a Business bank account
  3. Verified it appears in Settings > Payments
  4. Tapped on it and verified "Make default payment Method" does not appear
  5. From Settings > Payments, added a personal bank account
  6. Verified it appears in Settings > Payments
  7. Tapped on it and verified "Make default payment Method" appears
  8. Put your password and make as default payment
  9. Repeat steps 5-8 while offline ( you will notice that default label appears)

Expected Result:

Default label is stick to the personal account after added as default payment

Actual Result:

Default label isn't stick to the personal account after added as default payment, but it works while offline

Workaround:

Unknown

Platform:

Version Number: 1.2.30.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/203446141-3367869b-6d71-4a8b-bfcc-7d7a566ab368.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

luacmartins commented 1 year ago

Gonna assign myself to this one since I came back from ooo and I'm looking for WAQ issues to work on.

luacmartins commented 1 year ago

@kbecciv steps 5-8 don't seem to be available offline as the buttons are disabled. Could you please share a video of the issue?

mvtglobally commented 1 year ago

@luacmartins, Updated the issue.

luacmartins commented 1 year ago

Thanks! I'll take a look.

luacmartins commented 1 year ago

@mvtglobally sorry to bother you again, but can you share the credentials of the account used? I'm having trouble reproducing the error.

kbecciv commented 1 year ago

@luacmartins Credentials: applausetester+0901abb@applause.expensifail.com/Feya86Katya

luacmartins commented 1 year ago

Thanks! I'll get to this tomorrow!

luacmartins commented 1 year ago

Gonna try to get to this tomorrow!

melvin-bot[bot] commented 1 year ago

@sakluger, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

luacmartins commented 1 year ago

From the logs, it seems like we couldn't find the bank account, which means that the behavior witnessed here is correct!

[OOPS!] API Threw: Auth SetWalletLinkedAccount returned an error ExpException - 4bbb72ecefead2582ca5df4a9b782afc ~~ message: '404 Bank account not found' onyxData: '[0: '[onyxMethod: 'merge' key: 'userWallet' value: '[errors: '[1669154366755670: 'There was an error setting your default payment method. Please chat with Concierge for further assistance.']']']']' exceptionMessage: 'Auth SetWalletLinkedAccount returned an error' exceptionFile: '/git/releases/expensify.com/e6a2ac6/lib/Auth.php' exceptionLine: '121' exceptionCode: '404'
luacmartins commented 1 year ago

Closing since this is not an issue!