iOS - App crashes after adding workspace avatar in new account offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with a new account
2. Navigate to a Workspace settings
3. Disable the internet connection in the device
4. Upload new avatar, Verify you see the avatar grayed out a bit
5. Go back online, Verify the avatar is not grayed out anymore & that it updates in all pages and chats

Expected Result:

App is not crashed after adding a workspace avatar in a new account offline

Actual Result:

App is crashed after adding a workspace avatar in a new account offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.35.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/205352838-f70815a3-69d7-4bfd-984d-792f4f36ed88.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[amyevans]

Took a couple stabs at reproducing this both locally on a simulator and on my physical iOS and haven't been able to. Here's one pass through:

https://user-images.githubusercontent.com/7277067/205395041-0501c236-08c9-42b3-a864-ca59eb1a8b33.MP4

The avatar does toggle back to the default when coming back online for a bit, but the app doesn't crash. Curious to hear how @jliexpensify fares attempting to repro though!

[jliexpensify]

@amyevans I tried on my end, and am seeing the same behaviour as you: there isn't a crash but I am seeing the default avatar.

I'm on v1.2.36-1 (Android). @kbecciv are you seeing the same thing when you update your app?

[kbecciv]

@jliexpensify Checking with team, update you shortly

[kbecciv]

@jliexpensify Tester is able to reproduced in IOS app with build 1.2.36.2, please attached a new video.

https://user-images.githubusercontent.com/93399543/206294268-a63eb26a-b04d-4411-b692-649aacc5b987.mp4

[kbecciv]

@jliexpensify Let me know if we need to re-test in Android app.

[jliexpensify]

Around halfway through the video, the tester seems to be copying the link into a different app to test on Staging:

@amyevans - did you also test on staging?

[amyevans]

Yeah I was testing on staging, although the bug report says that it's reproducible on production, too.

I found logs for the 12/7 recording from andreylazutkinutest+071222@gmail.com above though.

I also tried reproducing a few more times on a dev build on my iPhone and reproduced it once. It's not reproducible every time which is just the funnest type of bug 😬.

It's an error from the API though, so this is definitely Internal.

[amyevans]

Logs from the error.

We're getting a reportID collision.

[jliexpensify]

@amyevans - awesome, thanks for the context. Given it's internal, would you be taking this one (i.e. no need for Upworks)?

[amyevans]

Yeah no need for Upwork! You can unassign yourself if you want 😄

[melvin-bot[bot]]

@amyevans Whoops! This issue is 2 days overdue. Let's get this updated quick!

[amyevans]

Continuing to work on, I've still only been able to reproduce once locally so not much to go on. I've been reviewing the code of the commands involved both on the App side and Web side but nothing sticking out to me as blatantly wrong.

[melvin-bot[bot]]

@amyevans Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@amyevans 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

@amyevans 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot[bot]]

@amyevans 12 days overdue. Walking. Toward. The. Light...

[JmillsExpensify]

This bug will hit the 30 day mark next week, so we need to start ironing out next steps. The reportID collision is pretty weird, as I'm not clear why we'd get that for updating a workspace avatar? Is that collision due to a workspace chat? Again though, let's create a Slack thread on this issue and start pushing it forward so that it's not blocking us from WAQ next week.

[melvin-bot[bot]]

This issue has not been updated in over 14 days. @amyevans eroding to Weekly issue.

[JmillsExpensify]

We need to retain a daily on this issue given my comment above.

[melvin-bot[bot]]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

@amyevans, @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

[AndrewGable]

Not sure if it helps but I tried reproducing this one a few times and was unable to get it to 💥

[AndrewGable]

This might be similar according to the LogSearch @amyevans shared: https://github.com/Expensify/App/issues/13738

[JmillsExpensify]

I got the crash on this. Details shared in Slack.

[amyevans]

Discussing in Slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1672681095936359

Logs from Jason's crash: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%227837e5cc7c5824e2-SJC%22)+AND+timestamp:[2023-01-03T00:17:56.615Z+TO+2023-01-03T02:17:56.615Z]&index=logs_expensify-020256

[JmillsExpensify]

Closing this issue in favor of the new issue that details the root cause. Thank you @amyevans!