[$1000] [HOLD for payment 2023-03-01] Expensify app icon looks different

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. install the app
2. verify the logo

Expected Result:

There should be no white background

Actual Result:

Has white background

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native

Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction

If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

Galaxy S9

Nexus 5X

Expensify/Expensify Issue URL: Issue reported by: @mdneyazahmad Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673504229478519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e365dc943aaf476b
• Upwork Job ID: 1614984043118538752
• Last Price Increase: 2023-03-01

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[joekaufmanexpensify]

I can't reproduce. Tried on Galaxy S9. Discussing here.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e365dc943aaf476b

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[Julesssss]

I have a good idea of how to fix this, and can reproduce on my Pixel 2A.

[joekaufmanexpensify]

Sounds good!

[joekaufmanexpensify]

Next step here is to begin PR.

[joekaufmanexpensify]

I believe next step here is to begin the fix, is that right @Julesssss ?

[Julesssss]

Hey, I've been OOO. Yep, I'll get this done soon.

[joekaufmanexpensify]

Sounds good, no rush. Thanks for confirming!

[joekaufmanexpensify]

Next step here is PR.

[MelvinBot]

@Julesssss @rushatgabhane @joekaufmanexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[joekaufmanexpensify]

@Julesssss do you think you'll be able to start the PR here soon?

[Julesssss]

@Julesssss do you think you'll be able to start the PR here soon?

Yep. Honestly I don't think this is a true WhatsApp quality blocker, but I will pick this up imminently.

[joekaufmanexpensify]

Got it, sounds good. Thanks!

[joekaufmanexpensify]

Not overdue.

[joekaufmanexpensify]

Next step is PR this week!

[joekaufmanexpensify]

Same.

[Julesssss]

Requested the necessary assets here. Once this issue is complete I can create the Android icon correctly.

[Julesssss]

PR in review

[MelvinBot]

@Julesssss, @rushatgabhane, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

Hm, this isn't overdue? PR is out on staging as of yesterday.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.75-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/15177

If no regressions arise, payment will be issued on 2023-03-01. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter
• [x] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

📣 @MelvinBot! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@rushatgabhane / @Julesssss] The PR that introduced the bug has been identified. Link to the PR: Not a regression.
• [x] [@rushatgabhane / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not a regression.
• [x] [@rushatgabhane / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [x] [@rushatgabhane] Propose regression test steps to ensure the same bug will not reach production again. NA.
• [x] [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Not a regression, so no test needed.

[Julesssss]

Not a regression, no test needed.

[Julesssss]

Closing as it's been deployed to production

[mdneyazahmad]

I think, I am eligible for reporting bonus here. Thanks!

[Julesssss]

Oh yeah, thanks for reminding me 😬

@joekaufmanexpensify would you please pay out the reporting bonus. Thanks!

[joekaufmanexpensify]

We still need to pay Rushat for reviewing as well, right? Going to re-open until all payment is issued.

[rushatgabhane]

thanks!

[joekaufmanexpensify]

All set to issue payment here. Upwork job is closed, so temp adding external label to create new upwork job.

[MelvinBot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[joekaufmanexpensify]

Hm, that didn't create a new job in Upwork, so I manually created one!

[joekaufmanexpensify]

@rushatgabhane offer sent for $1000!

[joekaufmanexpensify]

@mdneyazahmad offer sent for $250!

[joekaufmanexpensify]

@mdneyazahmad $250 paid and contract ended!

[joekaufmanexpensify]

@rushatgabhane $1000 paid and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, and payment sent. This is all set. Thanks everyone!