[HOLD Manual Requests][$1000] IOU Details page reload again after opening them same IOU

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account.
2. Go to any report, try to tap any IOU to open IOU Detail page, after that go back.
3. Swipe from bottom to make the app enter background mode, open the app again. Now tap to the same IOU that you tap before.
4. Notice that IOU Detail page doesn't show loading for the first time and it reloads after that few seconds.

Expected Result:

After enter foreground mode and tap the IOU, IOU Detail page should show loading and load the IOU Detail.

Actual Result:

IOU Detail page doesn't show loading after bringing to foreground then after a brief moment loading indicator appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] iOS / native

Version Number: 1.2.56-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/213301802-066556e4-cf3d-452b-bd26-7e129b44e290.MP4

https://user-images.githubusercontent.com/43996225/213301972-b4b506b7-6015-4464-a95c-440725ed5d10.MP4

Expensify/Expensify Issue URL: Issue reported by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674042038386489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5892f51566457de
• Upwork Job ID: 1615954837681774592
• Last Price Increase: 2023-01-26

[dangrous]

Sorry for the delay, all! The backend PR is in review and should hopefully get pushed soon.

[mollfpr]

Heyy @dangrous, any update on the API PR?

[dangrous]

Hey! So it's merged, but not yet deployed on staging or production. Hopefully soon!

[dangrous]

On staging!

[s77rt]

Regarding the skeleton view, can anyone share how the skeleton view should look like? I'm having a trouble designing the skeleton view for IOUPreview since it contains a box that contains other boxes.

[MelvinBot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Posted some ideas here, but something like this?

[fedirjh]

@shawnborton we are addressing this view

[shawnborton]

Ah, got it. @JmillsExpensify @trjExpensify thoughts on holding on this one since manual requests will change this view?

[trjExpensify]

Ah interesting one! We haven't considered adding a skeleton UI to a loading iouReport (or soon, expenseReport) in the RHP as part of manual requests, so won't we still have the same problem regardless of the redesign of the page? CC: @mountiny @Julesssss @luacmartins

[shawnborton]

For the detailed view, I suppose we could do something like this:

[Julesssss]

so won't we have the same problem regardless of the redesign of the page

Yeah, I don't think it matters too much either way. But waiting for the page redesign would reduce the chance of any conflicts when we begin work on the changes. It's likely that the component structure will change, so it's a bit simpler to hold.

I love the IOUPreview skeleton mocks, we should open a similar issue for this addition too.

[mountiny]

+1 to hold and I like the mockup from Shawn ❤️

[JmillsExpensify]

+2 for hold on manual requests. On that note, I wonder if we should add a boiler plate bullet to the offline section of the design doc template, basically to help prompt people whether skeleton UI will be needed for their project.

[JmillsExpensify]

@tjferriss Tom and I will take this from you, if you don't mind, and we'll wrap it up in the Manual Requests project.

[trjExpensify]

Yeah, I don't think it matters too much either way. But waiting for the page redesign would reduce the chance of any conflicts when we begin work on the changes. It's likely that the component structure will change, so it's a bit simpler to hold.

Cool, fair enough. Works for me! 👍

[trjExpensify]

New feature then for the skelly UI?

[dangrous]

Ah okay cool - so to confirm, we're going to close this issue, and we'll revisit the details as part of Manual Requests?

If so, do we still pay out for reporting? I don't think we'd need any of the other jobs.

Just want to make sure we're on the same page!

[trjExpensify]

I think we keep this issue open and on hold for manual requests, then revisit to implement it. Payments will be handled after it's on prod.

[JmillsExpensify]

Totally, nothing to do for the time being. Let's keep it open and hold.

[dangrous]

Sounds good!

[trjExpensify]

On hold for manual requests. Going to pop it on monthly till' we're on the way with the implementation.

[dangrous]

Still on hold

[dangrous]

Still on hold, I think we will be able to open it up again soon though!

[JmillsExpensify]

Yes indeed! Several weeks at the least.

[trjExpensify]

@mountiny @Julesssss @JmillsExpensify how do we feel about this one now? We have the skeleton UI loading in the expense/iou report screen and the request detailed thread. One improvement might be to include the page header(s) in the skeleton UI, right now I think it's just the comment sections?

[mountiny]

Yes, but I think we should create a fresh issue for that one. This issue is about component we wont support anymore.

[dangrous]

Cool, so do we just close this out instead?

[mountiny]

I think we can, I am not even sure if we need the updated skeleton, ti would not work when using URL and fetching the data fresh as then we have no clue what type of a report we have so we could only potentially do this when navigating from within the app, but I dont think its something we have to focus on

[dangrous]

Okay I'll close this for now, and if we end up needing to reopen, we can do that.