[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-10] [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other.

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account
In the compose box enter message with have lengthier letters like (j) and emoji

Expected Result:

Text entered with letters and emojis on the next line must not be close to each other

Actual Result:

When moving to another line, the word and emoji are close to each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] iOS / native

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/213815233-c2908d14-2042-4571-9196-09fbb3de6bd2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ebb233eae82dffea
Upwork Job ID: 1622658479891505152
Last Price Increase: 2024-03-05

Issue Owner

Current Issue Owner: @twisterdotcom

twisterdotcom commented 6 months ago

@fabOnReact how are you doing on this one?

melvin-bot[bot] commented 6 months ago

The BZ member will need to manually hire fabOnReact for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

twisterdotcom commented 5 months ago

Bump on this @fabOnReact

fabOnReact commented 5 months ago

The BZ member will need to manually hire fabOnReact for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

I tried to apply for the Upwork job but it says that the job is no longer available. I used this link https://www.upwork.com/jobs/~01ebb233eae82dffea This is my Upwork profile https://www.upwork.com/freelancers/~01ae44247887fa908b?viewMode=1

Thanks

twisterdotcom commented 5 months ago

Offer sent: https://www.upwork.com/nx/wm/offer/102318386.

You can accept, but I think we still want to ensure that https://github.com/Expensify/App/issues/4114 or https://github.com/Expensify/App/issues/17767 won't actually resolve it anyway, and that your solution will work after that.

fabOnReact commented 4 months ago

Update 17th May 2024

@twisterdotcom I wanted to let you know that I accepted the offer.

You can accept, but I think we still want to ensure that https://github.com/Expensify/App/issues/4114 or https://github.com/Expensify/App/issues/17767 won't actually resolve it anyway, and that your solution will work after that.

I tested a solution for this issue. I will publish the Pull Request with the solution in a couple of days. Thanks.

fabOnReact commented 4 months ago

Update 21st May 2024

I published 2 PRs https://github.com/Expensify/react-native-live-markdown/pull/350 and https://github.com/facebook/react-native/pull/44614 to fix this issue. I will follow up in a couple of days. Thanks

fabOnReact commented 4 months ago

Update 22 May 2024

Merged PR https://github.com/Expensify/react-native-live-markdown/pull/350
Meta imported PR https://github.com/facebook/react-native/pull/44614
Published Draft PR https://github.com/Expensify/App/pull/42454 to update Expensify dependency react-native-live-markdown to 0.1.76. I will move it to Ready for Review tomorrow.

fabOnReact commented 4 months ago

Update 23 May 2024

Moved PR https://github.com/Expensify/App/pull/42454 to ready for review.

fabOnReact commented 4 months ago

Update 28 May 2024

PR #42454 merged
I'll be away for 3 days for personal reasons (29, 30, 31st). I will restart working on Saturday 1st of June.

melvin-bot[bot] commented 4 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.77-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/42454

If no regressions arise, payment will be issued on 2024-06-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@fabOnReact requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 4 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

fabOnReact commented 4 months ago

Update 1st of June 2024

PR https://github.com/Expensify/App/pull/42454 was reverted because there are issues with react-native-live-markdown. The issues seem to not be related to PR https://github.com/Expensify/react-native-live-markdown/pull/350.

https://github.com/Expensify/App/issues/42755 (Android)
https://github.com/Expensify/App/issues/42766 (Android)

I will look into it.

fabOnReact commented 4 months ago

Update 5 June 2024

I reviewed and tested the regressions and none of them are related to my PR https://github.com/Expensify/react-native-live-markdown/pull/350.

The regression on iOS is not caused by my changes (videos included here).
https://github.com/Expensify/App/issues/42755 My changes are iOS only
https://github.com/Expensify/App/issues/42766 My changes are iOS only

twisterdotcom commented 4 months ago

Should we revert the revert? Do you need to submit a new PR again?

fabOnReact commented 4 months ago

Update 6th June 2024

@twisterdotcom Sorry, maybe my previous comment was not clear.

My PR react-native-live-markdown/pull/350 does not introduce any regression on iOS (see tests performed here).
My PR react-native-live-markdown/pull/350 includes iOS-only changes and it does not introduce regressions on Android (see my comment here).

I will start working again on this task on Monday. Hopefully, I can help to get this issue fixed so that we can upgrade react-native-live-markdown and close Issue 14445.

fabOnReact commented 4 months ago

@twisterdotcom

Should we revert the revert? Do you need to submit a new PR again?

I quote Skalakid comment.

After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after

I will create PR that bumps the version in the Expensify App I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue now

https://github.com/Expensify/App/commit/57d8b2be0cfb15e23ca3dcdd93bab39abaff183e

Maybe with the latest version of expensify-common and react-native-live-markdown the issues do not reproduce anymore. I will verify this on Monday (unluckily now I have other commitments). Thanks

twisterdotcom commented 4 months ago

No worries, we can wait until Monday.

melvin-bot[bot] commented 4 months ago

Payment Summary

Upwork Job

Reviewer: @eVoloshchak owed $250 via NewDot
ROLE: @fabOnReact paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1622658479891505152/hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

melvin-bot[bot] commented 4 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 4 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

fabOnReact commented 4 months ago

Update 10 July 2024

Tested PR https://github.com/Expensify/App/pull/43255#issuecomment-2157494277. The issue is fixed.
Meta team needs to merge PR https://github.com/facebook/react-native/pull/44614.
Regarding the Deploy Blocker. Issues 43332 and 43312 reverted PR 377. Our PR 350 did not introduce regression and is part of Expensify main branch (react-native-live-markdown version 0.1.83.

melvin-bot[bot] commented 4 months ago

Payment Summary

Upwork Job

Reviewer: @eVoloshchak owed $500 via NewDot
ROLE: @fabOnReact paid $500 via Upwork here

BugZero Checklist (@twisterdotcom)

[x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1622658479891505152/hired)
[x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[x] I have verified the payment summary above is correct

JmillsExpensify commented 4 months ago

$500 approved for @eVoloshchak

melvin-bot[bot] commented 4 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.81-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/43255

If no regressions arise, payment will be issued on 2024-06-18. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@fabOnReact requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 4 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.82-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/43255

If no regressions arise, payment will be issued on 2024-06-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@fabOnReact requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 4 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Expensify / App