Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Security - Can't close special account, error message appears #14504

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with the iheretsutest+2101@gmail.com/Yulia1986gerets account
  3. Go to Settings -> Security -> Close account
  4. Enter the email in the input and click on "Close account"

Expected Result:

Able to close account without any error message

Actual Result:

Can't close special account, error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.58.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (2)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017e23146eaa609166
  • Upwork Job ID: 1618276755241353216
  • Last Price Increase: 2023-01-25
slafortune commented 1 year ago

Hm - strange! LOGS

I do see an error in the logs TransactionIDs are not converted to string - there is only one transaction created in the account Transactions ID - 5299859348761605901

tgolen commented 1 year ago

Looking at the logs, I think the problem is this:

API threw ExpError Expensify\Error\User\Undeletable - c65019fc-c2d8-4529-8382-045c9c13d6cf ~~ message: '405 You have an annual subscription'

That account has an annual subscription which is why it can't be closed. It would be nice to surface the actual error in that case. This will probably need to be something done internally. I will work on it!

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~017e23146eaa609166

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

tgolen commented 1 year ago

@eVoloshchak This will be a fix only on the API, so there won't be anything for you to review on this one.

slafortune commented 1 year ago

Can just remove this Upwork Job @tgolen ?

tgolen commented 1 year ago

Yes, that should be fine 👍

tgolen commented 1 year ago

The updated error message was deployed to production last week, so I will close this.