Closed JmillsExpensify closed 1 year ago
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.54-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-24. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Woo! It's live. Great work everyone getting this merged.
@thesahindia Can you get the BZ checklist kicked off?
It's a new feature. We can add a test case if we don't have one
reportID
(last number in the chat's URL)Make sure the chat opens and has the same reportID
(has the same URL)
Open another existing chat (like concierge), make sure the chat stays in the LNH and shows the draft icon
Open another existing chat (like concierge), make sure the chat stays in the LNH.
Open another existing chat (like concierge), make sure the chat disappears from the LNH.
reportID
(last number in the chat's URL)Make sure the chat opens and has the same reportID
(has the same URL)
Make sure both the Money Request and the original report stay in the LNH
#admins
, #announce
and a workspace chats are createdThanks, sorry I missed your last response. I definitely think we need to add a regression test for every new feature. As for the payment summary, does the above issue technically count as a regression? Otherwise, I believe the payment summary is simply:
@JmillsExpensify I didn't do the PR, so no payment for me.
Ah thanks for your honesty! I'm not clear why you're assigned to this issue, though I'll update the payment summary in any case.
Regression test has been created so I think we're all done here.
$1,000 payment approved for @thesahindia based on BZ summary.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Chat should not show in the LHN as there is not at least 1 ADDComment action, or 1 draft message.
Actual Result:
Empty chat shows in the LHN and remains in the LHN after simply navigating to it.
Workaround:
None
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.58-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit