search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

Payment issue for E/App PR#14530 #14547

Closed melvin-bot[bot] closed 1 year ago

melvin-bot[bot] commented 1 year ago

Issue created to compensate the Contributor+ member for their work on https://github.com/Expensify/App/pull/14530 E/E issue linked to the PR - https:://www.github.com/Expensify/App/issues/169078. Contributor+ member who reviewed the PR - @mollfpr.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01194f2a230f6ba1b5
  • Upwork Job ID: 1618238982706950144
  • Last Price Increase: 2023-01-25
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

mallenexpensify commented 1 year ago

The automation works!!!! @strepanier03 this issue was auto-created cuz the PR that @mollfpr reviewed was linked to an E/E issue. This is the first I've seen, if you come across any issues or have any recommendations on for updating anything, add here in a comment. thx

strepanier03 commented 1 year ago

Thanks @mallenexpensify, handling this now and will let you know any feedback or questions I run into.

strepanier03 commented 1 year ago

@mallenexpensify - Can you review what I think needs to be done here and let me know if I'm off base anywhere?

  1. The PR was just merged and is waiting to be pushed to staging and then production. Once it's on production, the 7-day timer starts for regressions.
  2. When the PR goes to production, this payment GH title will be updated with "HOLD until [date]" so I know when to review and pay.
  3. The Upwork job that was created is private, so I'll need to make it public so mollfpr can apply,
  4. The fast bonus will apply as long as no regressions happen since Rory submitted and mollfr reviewed in about 1 business day.

Questions: Do I need to handle any regression test tasks for this?

mallenexpensify commented 1 year ago

Thanks @strepanier03 this makes me think we need an S/O update :| Yes to 1 and 2.

  1. It's best to keep private and invite/rehire the C+ - My Hires > type name > Rehire. Mohammad Luthfi F. is @mollfpr . If you're unsure of the C+ you can make it public then post in GH asking the C+ to apply and confirm once they have.
  2. No timeliness bonuses for internal PR reviews

You don't need to do regression test steps, those would be handled by the BZ assigned to the E/E issue

strepanier03 commented 1 year ago

Wonderful, thank you @mallenexpensify.

strepanier03 commented 1 year ago

Waiting for push to prod on this and update to title for payment hold.

sakluger commented 1 year ago

@mallenexpensify I was assigned another one of these (https://github.com/Expensify/App/issues/14710). Given that it's created and assigned before the PR is merged, and then we have to wait until 7 days after deploy to pay out, I think it would help to add the following details to the GH issue description.

  1. Ask the Bug-Zero assignee to hire the C+ on the upwork job immediately
  2. Set to a Weekly
  3. Check in a week later, and if the issue has been deployed, update the issue title with the payment date (7 days after deploy to prod). If it isn't deployed, leave a comment and wait another week.
strepanier03 commented 1 year ago

Commenting to remove overdue, and to agree with Sasha's comments above.

mallenexpensify commented 1 year ago

Currently the new issue is created once the C+ has approved a PR because that is the trigger to denote they're due payment.

Agree with your steps

  1. Ask the Bug-Zero assignee to hire the C+ on the upwork job immediately
  2. Set to a Weekly
  3. Check in a week later, and if the issue has been deployed, update the issue title with the payment date (7 days after deploy to prod). If it isn't deployed, leave a comment and wait another week.

@mountiny before we create a GH to update, do you have any thoughts/ideas here?

mountiny commented 1 year ago

Yeah this one is a bit tricky, we can do this, I can also try to edit the PR so the link to this issue is added to the PR body so once deployed it will automatically get updated using our automation. But that is a bigger improvement and not sure if it would go well.

Making this weekly sounds good to me

strepanier03 commented 1 year ago

Cool, thank you, everyone. I'm moving to weekly for now and stay really on top of GHs so I don't think this will be an issue. Once the HOLD is put on it after the push to prod I'll move back to Daily if it doesn't do it automatically.

mountiny commented 1 year ago

I think there must have been some miscommunication but @mallenexpensify created another issue for this here https://github.com/Expensify/App/issues/14643

already done and settled, closing