search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

IOS- IOU- New IOU action is not added to the 1:1 DMs and No green badge for any of the users #14590

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/13118

Action Performed:

  1. Launch the app
  2. Log i with new expensifail account
  3. Split a bill with a group you've never created before.
  4. Check if a new group chat is created with a CREATED action, an IOU action and the ADDCOMMENT action.
  5. Check a new IOU action is added to the 1:1 DMs with each member of the group.

Expected Result:

A new IOU action is added to the 1:1 DMs with each member of the group. And green badge is present for any of the users

Actual Result:

New IOU action is not added to the 1:1 DM. No green badge for any of the user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/214854744-c0105849-a58e-499d-9241-1a26c10da222.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

kbecciv commented 1 year ago

The same issue when Split Bill Offline .

luacmartins commented 1 year ago

So the 1:1 chats are created and the split message is correctly added to them, but there's no IOU summary nor badge in the LHN. This is only happening on iOS.

I'll take a quick look, but I'm not sure if we should block the deploy on that.

luacmartins commented 1 year ago

I'm not able to reproduce on dev.

luacmartins commented 1 year ago

Creating the SplitBill request offline adds the summary and badge. It's when we go back online that they disappear. I see this in the logs just now, which seems to be a problem with our API.

[OOPS!] API threw TypeError - 50450b563520aa892c003839a3ccaeac ~~ exceptionMessage: 'ReportUtils::notifyParticipants(): Argument #4 ($clientID) must be of type string, null given, called in /git/releases/expensify.com/b96822d/lib/ReportAPI.php on line 3975' exceptionFile: '/git/releases/expensify.com/b96822d/lib/ReportUtils.php' exceptionLine: '1939' exceptionCode: '0'
luacmartins commented 1 year ago

More context here, but the issue happens because the fix is still in the staging API. It should be fixed after the next API deploy. Closing!