Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[$1000] App resends copy pasted images from previous email replies along with new attachment reply #15312

Open kavimuru opened 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app with user A
  2. Open user B report and send any message
  3. Open user B email and open notification email of user A message
  4. Reply to message via email with copy pasted image (PrtSc button click and paste in windows and Shift+command+3 click on mac, right click on image to save to clipboard and paste), you can also send text with it if needed
  5. Once message is recieved by user A, reply again to same email using user B email, now reply with any attachment image (you can use text too with it if needed)
  6. Observe the message in user A

Expected Result:

User A should only receive the latest sent attachment with text

Actual Result:

User A receives both previous copy pasted image as well as latest sent attachment

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.74-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/220205513-1815b9c9-4976-4102-b9c8-49c39d784765.mp4

https://user-images.githubusercontent.com/43996225/220205565-c6be7721-a378-4e2c-9d64-e87f761c92b3.mp4

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676917118596099

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0123f5c9ea5dc8a8d1
  • Upwork Job ID: 1680605284573466624
  • Last Price Increase: 2023-07-16
MelvinBot commented 1 year ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

ctkochan22 commented 1 year ago

Looks like this falls under a larger tracking issue for email replies/formatting - https://github.com/Expensify/App/issues/15336

Pretty sure this is likely a Mailgun issue. If I'm guessing, we loop through the reply history. We usually omit most of it out, but in this case, maybe the image isn't filtered out and so we end up receiving two image.

It would be interesting to try sending attachments twice. Or even a third time to see if the non-attachment image keeps appearing

ctkochan22 commented 1 year ago

Lets put it on hold while we continue to consolidate email issues under this tracking gh

ctkochan22 commented 1 year ago

Placed on hold. @MitchExpensify it would be great if you can still do the triage checklist 🙇‍♂️

ctkochan22 commented 1 year ago

Still on hold for https://github.com/Expensify/App/issues/15336

ctkochan22 commented 1 year ago

Discussions on next steps should be held here: https://github.com/Expensify/App/issues/15336

MelvinBot commented 1 year ago

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MitchExpensify commented 1 year ago

Waiting on new engineering volunteer for the parent issue: https://github.com/Expensify/App/issues/15336

MitchExpensify commented 1 year ago

Waiting on new engineering volunteer for the parent issue: https://github.com/Expensify/App/issues/15336

Same as above

MitchExpensify commented 1 year ago

Same as above

MitchExpensify commented 1 year ago

Same as above

MitchExpensify commented 1 year ago

Still on hold

MitchExpensify commented 1 year ago

Waiting on new engineering volunteer for the parent issue: https://github.com/Expensify/App/issues/15336

Same as above

MitchExpensify commented 1 year ago

Same

MitchExpensify commented 1 year ago

Same seeing as the dependent issue is not being pushed as a priority https://github.com/Expensify/App/issues/15336

MitchExpensify commented 1 year ago

Same

MitchExpensify commented 1 year ago

SAME

MitchExpensify commented 1 year ago

Same, still not a priority

MitchExpensify commented 1 year ago

You guessed it, still not a priority

MitchExpensify commented 1 year ago

Same

MitchExpensify commented 1 year ago

@dhanashree-sawant are you still able to reproduce this?

dhanashree-sawant commented 1 year ago

Hi @MitchExpensify, yes it is still reproducible on latest staging.

MitchExpensify commented 1 year ago

Reproducible:

image
melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0123f5c9ea5dc8a8d1

melvin-bot[bot] commented 1 year ago

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

MitchExpensify commented 1 year ago

Still waiting on proposals, Melvin

allroundexperts commented 1 year ago

Needs to be internal @MitchExpensify since the emails are handled from the backend.

melvin-bot[bot] commented 1 year ago

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

MitchExpensify commented 1 year ago

Thanks @allroundexperts , made the change!

melvin-bot[bot] commented 1 year ago

@allroundexperts, @MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MitchExpensify commented 1 year ago

Labelling eng as this needs internal eng assignment

marcochavezf commented 1 year ago

No update yet

marcochavezf commented 1 year ago

No update

marcochavezf commented 1 year ago

No update, focused on other 2 daily issues

marcochavezf commented 1 year ago

No update

marcochavezf commented 1 year ago

No update, moving this issue to weekly

marcochavezf commented 1 year ago

No update, focused on TU

MitchExpensify commented 1 year ago

How are we looking here @marcochavezf? No worries if no update, wishing to keep Melvin off our backs 👍

MitchExpensify commented 1 year ago

No update, focused on TU

This is the latest, Melvin

marcochavezf commented 1 year ago

No update yet here, focused on wave7

MitchExpensify commented 11 months ago

Same as above, Melvin

marcochavezf commented 11 months ago

No update, focused on other daily priorities and wave7

marcochavezf commented 11 months ago

No update

marcochavezf commented 11 months ago

No update

marcochavezf commented 10 months ago

No update

MitchExpensify commented 10 months ago

I assume the same, @marcochavezf ?

marcochavezf commented 10 months ago

Yes sorry, still tackling a few other dailies