Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

[$250] Feature Request: Add full screen expand button when editing a messge #15596

Open kavimuru opened 1 year ago

kavimuru commented 1 year ago

Held on https://github.com/Expensify/App/issues/16078 If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

When there's multiple lines being edited, there is a "full-screen expand" button in the upper-left of the compose window, but not when editing an existin

Solution:

Add the full-screen expand button to the upper-left when editing an existing comment

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/222207842-4cb95747-e11d-4ab7-a3c9-6a3f85cdedd9.mp4

Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677476774053969

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e878e8c8ed91741e
  • Upwork Job ID: 1632674482135707648
  • Last Price Increase: 2024-06-20
cristipaval commented 1 year ago

still on hold

s77rt commented 1 year ago

Still on hold

cristipaval commented 1 year ago

Still on hold.

sonialiap commented 1 year ago

Still on hold

cristipaval commented 1 year ago

still on hold

s77rt commented 1 year ago

Still on hold

s77rt commented 1 year ago

Same ^

s77rt commented 1 year ago

Still on hold

cristipaval commented 1 year ago

Still on hold.

sonialiap commented 1 year ago

Still on hold

sonialiap commented 1 year ago

Holding pattern continues https://github.com/Expensify/App/issues/16078

sonialiap commented 11 months ago

Still on hold for https://github.com/Expensify/App/issues/16078

cristipaval commented 11 months ago

Same status.

cristipaval commented 11 months ago

It looks like no progress yet on the issue that this one is held on.

cristipaval commented 10 months ago

Same status.

s77rt commented 9 months ago

Still on hold

cristipaval commented 8 months ago

same status

s77rt commented 7 months ago

Same ^

cristipaval commented 6 months ago

Still on hold

s77rt commented 4 months ago

Still on hold

sonialiap commented 4 months ago

Still on hold for https://github.com/Expensify/App/issues/16078

sonialiap commented 3 months ago

Still on hold https://github.com/Expensify/App/issues/16078

s77rt commented 2 months ago

Same ^

sonialiap commented 1 month ago

Still on hold https://github.com/Expensify/App/issues/16078

melvin-bot[bot] commented 2 weeks ago

Upwork job price has been updated to $250

puneetlath commented 2 weeks ago

Reopening this for proposals. Now that we have inline auto-suggestion, we should be able to make the compose box expand to take up the full available space. And we should be able to have that happen on all platforms.

puneetlath commented 2 weeks ago

Or actually, looks like @tienifr is already assigned. @s77rt @tienifr does that proposal still make sense here?

s77rt commented 2 weeks ago

@tienifr Can you please look into the part that makes the main composer full screen as well as updating your proposal to reflect the current codebase

s77rt commented 1 week ago

Not overdue. Waiting on proposals

kevinksullivan commented 6 days ago

going to take a look at this one, so I'm removing the external label for now.