[HOLD][Tracking] Add Native Share Menus to New Dot - Share Into New Expensify

grgia commented 1 year ago

Design Doc

https://docs.google.com/document/d/10agvPMrVzXViEaH47gAXr9CZN62aaI3L5kj4aoj5LhI/edit

Proposal

Let’s implement native share menus so users can both share-to and share-from New Dot.

Problem: There are plenty of times where I want to share something from outside our app into New Expensify. But there’s no way to quickly share links/photos/information while outside Expensify. For example, if I’m in the Photos App and I decide I want to share a photo, I’ll have to leave the app → open New Dot → go to the correct chat → click add attachments → find the same image again → and so on. On the flipside, there’s no easy way to export information from inside the app to outside Expensify. There’s no quick solution to export a PDF to print or to AirDrop a photo from one device to another.

Solution: Let’s utilize one of our external agencies to implement Native Share Menus. Share menus are an essential feature to most other chat apps. If a user wants to send a photo, let’s make it as easy as possible. From the photo app you’d just click share → New Expensify and voila! In fact, we already have this feature for Old Dot. Right now, you can take a picture -> share -> Expensify, and immediately start a smartScan. So adding Share Menus to New Dot would be a requirement to maintain feature parity between Old and New Apps. As for sharing from inside Expensify to outside sources, to make New Expensify our go-to chat and finance collaboration app in the future, we should be able to communicate with those who have not yet adopted the app. For those of us that are eager to use NewDot as our primary chat app in our day-to-day lives, this feature would be a valuable way to encourage that while the rest of the world is still using WhatsApp. Later on, external sharing can feed into our viral business model, where chats/photos/links sent from New Expensify can be wrapped in an advertising moment, incentivizing people to join New Expensify from other chat apps.

https://expensify.slack.com/archives/CC7NECV4L/p1675375866420119

Pre-designs

Initial Pre-design Design Pre-design

Tasks

[x] Post Proposal (full Problem/Solution statement) in #whatsnext
[x] Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
[x] Paste Proposal in the space above with a link to the Slack thread
[x] Email strategy@expensify.com and paste in the Proposal
[x] Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
[x] Email strategy@expensify.com (continue the same email chain as before) with the link to your Design Doc
[x] Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section.
[x] Fill out the High-level of proposed solution section
[x] Email stategy@expensify.com again with links to the doc and pre-design conversation in Slack
[x] Add the DesignDocReview label to get the High-level of proposed solution section reviewed
[x] Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
[ ] Confirm that the doc has the minimum necessary number of reviews before proceeding
[ ] Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
[ ] Fill out the Detailed implementation of the solution and related sections.
[ ] Re-add the DesignDocReview label to this issue
[ ] Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
[ ] Confirm that the doc has the minimum necessary number of reviews before proceeding
[ ] Email strategy@expensify.com one last time to let them know the Design Doc is moving into the implementation phase
[ ] Implement the changes
[ ] Send out a follow up email to strategy@expensify.com once everything has been implemented and do a Project Wrap-Up retrospective that provides:
- Summary of what we accomplished with this project
- What went well?
- What could we have done better?
- What did we learn?

amyevans commented 9 months ago

I have read and reviewed this Design Doc!

stephanieelliott commented 9 months ago

I have read and reviewed this Design Doc!

conorpendergrast commented 9 months ago

I have read and reviewed this Design Doc!

arielgreen commented 9 months ago

I have read and reviewed this Design Doc!

robertjchen commented 9 months ago

I have read and reviewed this Design Doc!

grgia commented 9 months ago

In implementation, was briefly put on hold for violations project work. This project has been added to wave5

grgia commented 8 months ago

Checking on the status of implementation with violations project

lindboe commented 8 months ago

@grgia Violations is still ongoing and at the current pace looks likely to continue into next week. I expect we'll be able to start picking up Share again mid-next-week.

grgia commented 8 months ago

Implementation is in progress

JmillsExpensify commented 7 months ago

I have read and reviewed this Design Doc!

grgia commented 7 months ago

Implementation is in progress, current ETA end of feb

lindboe commented 7 months ago

Hand-off information, to add on from the design doc:

For planned updates to react-native-share-menu, this is the root tracking issue: https://github.com/Expensify/react-native-share-menu/issues/294. There are linked issues that have some associated PRs already.

There's a google doc available here with extra notes and information from prior prototyping work here, some of which is for react-native-share-menu, and some is for New Expensify: https://docs.google.com/document/d/1ku-jZ9mjDkRgMHWGhe-bmuPAwK88sh5WgczU3vc2mfw/edit?usp=sharing.

grgia commented 7 months ago

Putting this project on HOLD temporarily while we discuss integrating with Hybrid Web

trjExpensify commented 6 months ago

👋 I haven't migrated this issue to the #wave-collect project. If this project doesn't get taken care of as part of HybridApp, bring it up in the #wave-collect channel. Thanks!

grgia commented 5 months ago

Going to close this out in favor of https://github.com/Expensify/App/issues/36613

Expensify / App