[HOLD for payment 2023-04-03] [$2000] URL does not show on the bottom left on hovering the social media icons in sign in page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. open the https://staging.new.expensify.com/
2. go to login page (if you are logged in please logout) and scroll
3. hover mouse on the social media icons

Expected Result:

it should show URL on bottom left same as other links

Actual Result:

does not show URL on bottom left corner

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.2.80-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/223547269-38566e19-e4fc-4a1c-9be3-1c8fdeedc050.mov

https://user-images.githubusercontent.com/43996225/223547326-1f78d43a-924a-4dfb-b2db-8e19da845bf3.mp4

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678168484655499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108397cd1af3372fb
• Upwork Job ID: 1633301698434338816
• Last Price Increase: 2023-03-15

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0108397cd1af3372fb

[MelvinBot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[MelvinBot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Reckon this is a quick fix, unsure why it's not showing. I think we want for consistency but also to show people where the link will take them (I check links in similar situations/sites)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

URL's are not showing on the left bottom of the browser for the social icons.

What is the root cause of that problem?

We have used Pressable component for social icons which won't be treated as anchors, bcoz Text is required for making a hyperlink with Linking module.

What changes do you think we should make in order to solve the problem?

We need to reuse TextLink component which we are using for the other links and wrap it with the Hoverable which is the same way we are doing for the other links on the page. This will show the URL in the browser bottom on the link hover.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no link address shown at the bottom left of the page when we hover over the social icons at the sign in footer.

What is the root cause of that problem?

We use Pressable to show each icon which will be translated to a div, but we need an anchor tag.

What changes do you think we should make in order to solve the problem?

We can just add href={social.link} to the Socials's Pressable component and it will become an anchor tag.

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

URL does not show on the bottom left on hovering the social media icons in sign in page

What is the root cause of that problem?

We need an anchor tag to Pressable. Just using onPress can't handle anchor tag.

What changes do you think we should make in order to solve the problem?

Similar to what we implemented already in TextLink, we can apply href to Pressable. But we should also prevent default behavior on onPress callback because if href and onPress both exist, both of them are triggered and redirect happens on both same tab and another tab. So solution is to

• add href={social.link}
• add e.preventDefault() on onPress callback

https://github.com/Expensify/App/blob/7e8e8a1d881914abe7c13768eb13e4930cb8546b/src/pages/signin/Socials.js#L38-L44

Improvement:

We should avoid View derived components inside Text, which doesn't work well and might break style in native. So avoid using TextLink which is @Pujan92's proposal because it will have Icon as a child component.

And this can be replaced with <View style={[styles.flexRow, styles.alignItemsCenter]}> https://github.com/Expensify/App/blob/7e8e8a1d881914abe7c13768eb13e4930cb8546b/src/pages/signin/Socials.js#L36

[Aadil-Shabir]

We can simply use anchor tags to solve the problem. and pass the "href" property.

[MelvinBot]

📣 @Aadil-Shabir! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Aadil-Shabir]

Contributor details Your Expensify account email: aadil.shabir13@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~010905b3ee1f1acb1d

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jaygangani]

Proposal

Please re-state the problem that we are trying to solve in this issue. URL does not show on the bottom left on hovering the social media icons in sign in page

What is the root cause of that problem? The Root cause to this problem is using javascript to open a window in new tab.

What changes do you think we should make in order to solve the problem? Instead of using Javascript for redirecting the page we should use html5 anchor tag and set href and target for it. that will fix the issue.

[MelvinBot]

📣 @jaygangani! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jaygangani]

Contributor details Your Expensify account email: ganganijay70@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01d19649d41ad045f1

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mallenexpensify]

@sobitneupane , can you please review the above proposals?

[MelvinBot]

📣 @devmaxkyu! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sobitneupane]

Thanks for the proposal everyone.

The proposal from @Pujan92 looks good to me.

🎀👀🎀 C+ reviewed cc: @marcochavezf

[mallenexpensify]

@marcochavezf can you please review @Pujan92 's proposal above? Thx

[marcochavezf]

LGTM too, assigning @Pujan92 🚀

[MelvinBot]

📣 @Pujan92 You have been assigned to this job by @marcochavezf! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[situchan]

As I stated in proposal, if we use TextLink, style will be broken on native.

TextLink:

Pressable:

[Pujan92]

PR is ready for review.

[MelvinBot]

@marcochavezf, @Pujan92, @mallenexpensify, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.89-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/16067

If no regressions arise, payment will be issued on 2023-04-03. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@sobitneupane / @marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
• [x] [@sobitneupane / @marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [x] [@sobitneupane / @marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@mallenexpensify] Determine if we should create a regression test for this bug.
• [x] [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[marcochavezf]

This error didn't exist before are uncovered edge cases of the footer implementation. So checking off the checklist items. Also, I think the regression test steps to TR will be enough to prevent this bug in the future.

[MelvinBot]

@marcochavezf, @Pujan92, @mallenexpensify, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@sobitneupane @Pujan92 @gadhiyamanan can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01d818be187a45e3b9

I addressed the price increase between 🎀 and hiring, since it was 'on us' to revert the price back to $1000 when it got increased (me) or to revert/address once @marcochavezf hired @Pujan92 , we're going to let the $2000 amount stand. This doesn't mean that, in the future, other instances will follow the same process/logic, they can be handled on a case-by-case basis, as needed

[Pujan92]

@mallenexpensify Thanks! Accepted. If this needs to be reverted to $1000 to avoid ambiguity for future instances, I am also fine with it.

[gadhiyamanan]

@mallenexpensify accepted

[sobitneupane]

Thanks @mallenexpensify. Accepted the offer.

[mallenexpensify]

If this needs to be reverted to $1000 to avoid ambiguity for future instances, I am also fine with it.

@Pujan92 , appreciate the offer. We stopped auto-doubling so it won't be an issue going forward. I/we should have caught and reverted. I'll blame me being sick the past two weeks :)

[Pujan92]

Bump @mallenexpensify for the payment.

[mallenexpensify]

Thanks @Pujan92 , sorry for the delay, you've been paid $2000, @sobitneupane too. @gadhiyamanan paid $250 for reporting. Adding this issue to 'Edge Cases' in the testing guidelines, so no regression test steps needed.

[Pujan92]

Thanks @mallenexpensify, just to confirm aren't we considering the time bonus here?

[mallenexpensify]

I was going back/forth on that, I feel like it's a bit excessive, as the job price was doubled when it maybe shouldn't have been. That said... I don't know if I can point to anything in the CONTRIBUTING.md to justify my thinking.

[Pujan92]

I was unsure and doubtful so just asked to confirm, but I am fine and don't want to point out anything from guideline as mutually understand and agree with you. :)

[mallenexpensify]

If you and @sobitneupane are cool with it @Pujan92 , I'd prefer to treat this as an edge case, issue the 2x pay for the auto-doubling and not also add the bonus (since the former part is now obsolete, this won't happen again. And, you would have received the 50% timeliness bonus if this happened now)

[sobitneupane]

I think it makes sense @mallenexpensify. I am totally fine with it.

[situchan]

NOTE: the solution went in the wrong way. As I stated in my proposal, it's not recommended to put View inside Text in native unless there's no other solution. Though PR didn't cause regression, this issue would have been avoided if my solution is applied.