Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[$1000] IOS - IOUAmount - When entering/deleting numbers quickly, the cursor doubles #15856

Closed kbecciv closed 6 months ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR https://github.com/Expensify/App/pull/15710

Action Performed:

  1. Open the app
  2. Login with any account
  3. Tap on the FAB button -> Send/Request money
  4. Quickly enter/delete numbers

Expected Result:

A second cursor doesn't "flash" after the first digit

Actual Result:

A second cursor appears after the first digit on every keyboard press

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/224388551-beff33ab-17e9-4ef6-807b-f0d61382124b.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014612000725948717
  • Upwork Job ID: 1634282958953353216
  • Last Price Increase: 2023-03-10
trjExpensify commented 1 year ago

@hannojg where can I follow along on this?

hannojg commented 1 year ago

Hey, pardon for being absent. Continuing to work on it now. Expect an update in the next hours!

hannojg commented 1 year ago

After some further investigation I can confirm that this issue won't get fixed by the current text input fixes we did (those fixes only targeted android)

hannojg commented 1 year ago

Also adding here, that I tested the behaviour of controlled text inputs on iOS extensively now, and can confirm that this issue will be fixed with fabric. So I think having it on hold for fabric is still fine!

trjExpensify commented 1 year ago

Oh, that's encouraging. So we're right to hold on #8503. Looking forward to getting that over the line.

roryabraham commented 1 year ago

Still on HOLD

roryabraham commented 1 year ago

Still on HOLD

roryabraham commented 1 year ago

Still on HOLD

eVoloshchak commented 1 year ago

Not overdue, still on hold

Christinadobrzyn commented 1 year ago

Hi! @eVoloshchak or @narefyev91 do you think this issue will fix - https://github.com/Expensify/App/issues/15856?

eVoloshchak commented 1 year ago

@Christinadobrzyn, looks like the link isn't correct, https://github.com/Expensify/App/issues/15856 is the current issue

Christinadobrzyn commented 1 year ago

Oh sorry! @eVoloshchak here's the correct issue https://github.com/Expensify/App/issues/26336

eVoloshchak commented 1 year ago

@Christinadobrzyn, thanks! Yes, looks like https://github.com/Expensify/App/issues/26336 is a dupe of this issue, I think it can be closed

trjExpensify commented 1 year ago

Still on hold for Fabric.

trjExpensify commented 1 year ago

Down to one major blocker on Fabric.

trjExpensify commented 11 months ago

Latest on Fabric: https://github.com/Expensify/App/issues/8503#issuecomment-1858970965

roryabraham commented 10 months ago

Still on HOLD, but we're getting closer to merging new arch

trjExpensify commented 9 months ago

Still held, latest on Fabric here.

eVoloshchak commented 8 months ago

Update: according to https://github.com/Expensify/App/issues/8503#issuecomment-1980179995

it seems plausible that switching to Fabric in Expensify is a matter of weeks / 1-2 months

trjExpensify commented 7 months ago

What's the latest status on switching to Fabric? I think this follow-up issue can go in #wave-collect as polish.

roryabraham commented 7 months ago

Fabric is live, taking this off HOLD

trjExpensify commented 6 months ago

Alright, what are the next steps and who's doing them? Thanks!

eVoloshchak commented 6 months ago

@trjExpensify, I cannot reproduce this bug anymore, the cursor looks normal

https://github.com/Expensify/App/assets/9059945/532ed31b-8ccb-41a5-8b85-e66832719da6

There's still something weird going on with the first symbol when entering numbers quickly (0:08 in the video above), is that something that needs to be fixed?

trjExpensify commented 6 months ago

On a real iOS device on the latest TF (v1.4.71-0), I can't reproduce the reported bug in the OP, nor that one you mentioned just now. Anyone else on this issue have a real iOS device to try for a second opinion on that before we close it out?

eVoloshchak commented 6 months ago

@trjExpensify, checked on a physical device, both bugs are not present

trjExpensify commented 6 months ago

Great, so we can close this then!