[HOLD #16078][$2000] suggestion for Emoji remains even after sending message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Type for any emiji ( do not select suggested emoji)
3. Send message

Expected Result:

Suggested emoji should be removed after sending the message

Actual Result:

Emoiji suggestions shows

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [x] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.2.92-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/224875615-cecd9a1d-1424-46f2-b08e-51a0f88da5a2.mp4

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678718820449989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eccf0dd16e54ab9d
• Upwork Job ID: 1643225880592248832
• Last Price Increase: 2023-04-24

[s77rt]

@thiagobrez Thanks for the follow up. Unfortunately that's considered a flicker. It's something that does not exist now but it will, so it will be probably get reported as a bug and tracked as a regression to this one :sweat_smile:.

@MonilBhavsar Do you have any thoughts so far? Do you think we should just go for the onClear solution in this case?

[MonilBhavsar]

Sorry, where is the flicker. I am not finding it. Could you please tell the timestamp?

[s77rt]

In the first video (with refocus) after closing the modal the input lose focus and gain it again.

[MonilBhavsar]

Thanks! In my opinion, It is not a blocker. I see slack uses the "Without refocus" approach. So we go with that?

[thiagobrez]

It's something that does not exist now but it will, so it will be probably get reported as a bug and tracked as a regression to this one 😅

@s77rt To share a bit more of context, in production it already behaves like this when closing the emoji picker or attachment action.

Production ⬇️

https://github.com/Expensify/App/assets/26878038/4a1852f4-b4c0-448d-99e7-e7cffcdc0404

[thiagobrez]

I see slack uses the "Without refocus" approach. So we go with that?

@MonilBhavsar That's what I initially proposed. But for that, we need to remove this conditional:

https://github.com/Expensify/App/blob/c917c447f225fe3b194a5e03f568cca0de9e5e71/src/pages/home/report/ReportActionCompose.js#L252-L257

Which would stop focusing the input when other modals closed. I'm not exactly sure what are the other modals that could open in this page though.

[s77rt]

@MonilBhavsar Thanks for the confirmation.

So we go with that?

Not really. The whole View as Modal (coverScreen=false) approach seems a little over-engineered. I would prefer to go with RN Modal (coverScreen=true) and just disable focus trap. Or use the simplest solution onClear.

Ultimately, this is not a bug in E/App and even doing nothing is an acceptable approach. I'm still inclined towards onClear solution.

[thiagobrez]

I can understand both sides. Maybe if https://github.com/Expensify/App/issues/16078 (auto-complete work inline) is being worked on, we go for the simplest approach (onClear) since that ticket might already change a lot the suggestion behavior?

[s77rt]

@MonilBhavsar Greenlight for onClear :grin:?

[s77rt]

@MonilBhavsar Thoughts on the above ^

[MonilBhavsar]

Sorry, if we think a lot of suggestion behavior is going to be updated in that linked PR #16078. Should we hold before moving forward? I am sideways for onClear solution as it misses one case(as we discussed in slack), and we would open another issue to fix that case, and then will need to think of a solution that fixes the whole issue.

[s77rt]

I am not sure what kind of change we are expecting in that issue. I was for going with the modal approach as I thought it will solve the other issue as well, but I think it won't (coverScreen=false, will not teleport the modal to the outer view - I think teleporting the modal can fix the other issue).

I think it would be safer to hold for that issue.

[MonilBhavsar]

Cool, let's put this issue on hold. I'll comment on that issue for a heads-up

[MonilBhavsar]

Still on hold

[MonilBhavsar]

Still on hold

[s77rt]

Still on hold

[s77rt]

Same ^

[MonilBhavsar]

Still on hold

[miljakljajic]

Still on hold

[miljakljajic]

Unassigning myself from this issue whilst I participate in the Guides experiment for three months. Please reapply the BZ label when we've taken this off hold and we're ready to work on it.

[MonilBhavsar]

Still on hold

[melvin-bot[bot]]

@s77rt, @thiagobrez, @MonilBhavsar Eep! 4 days overdue now. Issues have feelings too...

[s77rt]

Still on hold, Melvin

[s77rt]

Same ^

[MonilBhavsar]

Still on hold for https://github.com/Expensify/App/issues/16078

[MonilBhavsar]

Still on hold

[MonilBhavsar]

Still on HOLD. bumping to weekly

[s77rt]

Still on hold

[s77rt]

Still on hold

[MonilBhavsar]

Still on hold

[MonilBhavsar]

Still on hold

[s77rt]

Still on hold

[s77rt]

Still on hold

[s77rt]

Still on hold

[s77rt]

Same ^

[MonilBhavsar]

Still on HOLD

[MonilBhavsar]

Still on HOLD

[s77rt]

Still on hold

[s77rt]

Same ^

[s77rt]

Still on hold

[s77rt]

Same ^

[s77rt]

Same ^

[s77rt]

Still on hold

[s77rt]

Still on hold

[s77rt]

Still on hold

[s77rt]

Same ^

[s77rt]

Same ^

[s77rt]

Same ^

[s77rt]

Still on hold

[s77rt]

Same ^