[HOLD for payment 2023-04-05] App does not translate 'reacted with' to spanish in new reacted with emoji tooltip

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open Preferences
4. Open Language
5. Change language to spanish
6. Open any report
7. React to any message
8. Hover on reacted emoji

Expected Result:

App should translate 'reacted with' text as it translates 'You' above it

Actual Result:

App only translates 'You' in tooltip and does not translate 'reacted with' to spanish

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.2.86-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/225697504-de080bb4-37e8-4291-ac5f-01672b8a13f9.mp4

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678961850453749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0a0323d7f5b83e2
• Upwork Job ID: 1636483395419566080
• Last Price Increase: 2023-03-16

[MelvinBot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Looks like this was introduced alongside https://github.com/Expensify/App/issues/15127, where reacted with is hardcoded in, rather than in the translation file.

@stitesExpensify and @hannojg , I will put this thorough the usual Extenal process, unless you two want to take it for some other reason?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0a0323d7f5b83e2

[MelvinBot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reacted emoji tooltip does not translate reacted with word in to Spanish

What is the root cause of that problem?

Within ReactionTooltipContent.js at line 65 'reacted with' text hardcoded. This is the root cause of the problem. https://github.com/Expensify/App/blob/0efe6acf41eb985a0d6e42b47a8d91ab9cef6559/src/components/Reactions/ReactionTooltipContent.js#L65

What changes do you think we should make in order to solve the problem?

We have to add translation key within en.js and es.js and update line 65 as shown below.

Within src/languages/en.js add below translation key

reportActionContextMenu: {
  ...
  reactedWith: ({emojiName}) => `reacted with :${emojiName}:`,
},

Within src/languages/es.js add below translation key

reportActionContextMenu: {
  ...
  reactedWith: ({emojiName}) => `reaccionó con :${emojiName}:`,
},

Within ReactionTooltipContent.js at line 65 change code as shown below

  { props.translate('reportActionContextMenu.reactedWith', {emojiName: props.emojiName}) }

What alternative solutions did you explore? (Optional)

None

[MelvinBot]

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Snehal-Techforce]

Proposal

Issue Root Cause: Spanish translation is not available in es.js file

Solution: Adding translation string in es.js & en.js file and modify the code by removing hard coded English text and updating translation trigger point in ReactionTooltipContent.js file’s 65th line., “reacted with” text is translated into Spanish text.

Below are the changes in es.js & en.js language files.

Expected Output:

[jasperhuangg]

@stitesExpensify and @hannojg , I will put this thorough the usual Extenal process, unless you two want to take it for some other reason?

I think this is a straightforward enough fix that proposals aren't required. Sorry to those that have already submitted proposals, but this seems like cleanup from a new feature that was added recently, so I'm removing the External and Help Wanted labels.

[tjferriss]

@stitesExpensify @jasperhuangg I have a related issue where the Emoji reaction names are not in Spanish language https://github.com/Expensify/App/issues/16086

Should we treat these separately or get both fixed here?

[MelvinBot]

@stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

[tjferriss]

@stitesExpensify any advice on the above comment?

[stitesExpensify]

Apologies for the delay, I'm currently sick and (mostly) OOO. These are definitely separate issues @tjferriss .

I'll fix this internally next week.

[stitesExpensify]

PR is up

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.91-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/16555

If no regressions arise, payment will be issued on 2023-04-05. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter @dhanashree-sawant
• [ ] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR @eVoloshchak

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@stitesExpensify] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/issues/15127
• [x] [@stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: (It was me)
• [x] [@stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should have been caught by the checkbox, it was missed because it was pushed out quickly for expensiconX
• [x] [] Determine if we should create a regression test for this bug. Not needed
• [x] [@stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

@stitesExpensify can you confirm we're not paying out @eVoloshchak for the contributor plus role?

[stitesExpensify]

@tjferriss puneet decided that we actually did want a contributor plus here, so we should pay them for a review

[tjferriss]

Thank you for confirming. @dhanashree-sawant and @eVoloshchak I've sent you both offers via Upworks.

[dhanashree-sawant]

Hi @tjferriss , ping for upwork.

[MelvinBot]

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

[tjferriss]

Sorry @dhanashree-sawant @eVoloshchak I missed this before heading out of office. I just invited you both to the job on Upworks: https://www.upwork.com/jobs/~013ae3f2bb593b09f0

[dhanashree-sawant]

Hi @tjferriss , sure that's okay, there is already a job with offer for the same task. I will message you on upwork in that offer. If possible, can you only accept that offer?

[eVoloshchak]

Same thing, I already have an active job for this task

[tjferriss]

Got it. Payments have been sent using the original job post.

@stitesExpensify can you complete the check list?

[MelvinBot]

@stitesExpensify Still overdue 6 days?! Let's take care of this!

[stitesExpensify]

Completed checklist! Closing