[$250] Migrate AttachmentPicker/index.native.js to function component

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.53k stars 2.88k forks source link

[$250] Migrate AttachmentPicker/index.native.js to function component #16116

Closed marcaaron closed 1 year ago

marcaaron commented 1 year ago

Class Component Migration

Filenames

[ ] src/components/AttachmentPicker/index.native.js
- type: React.Component
- has state values: true
- has refs: false
- has context: false
- lifecycle methods: none

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01183dfbebd5805613
Upwork Job ID: 1688993294115909632
Last Price Increase: 2023-08-08

kuluruvineeth commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

-> Class Component Migration for AttachmentPicker Native Component

What is the root cause of that problem?

-> class components are more verbose and harder to reason about than functional components.

What changes do you think we should make in order to solve the problem?

-> Convert AttachmentPicker Native Component to functional component by removing extends Component , receiving props i.e {translate and type} as input parameter and using arrow functionality syntax. -> I will use useState hook to maintain the state of the isVisible property and initially set its value to false -> Rest of the functions I would convert them to arrow based functions keeping the logic intact and updating the isVisible local state component variable using setIsVisible callback function provided by useState hook wherever necessary.

What alternative solutions did you explore? (Optional)

MelvinBot commented 1 year ago

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 1 year ago

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] commented 1 year ago

10 days overdue. I'm getting more depressed than Marvin.

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 14 days. eroding to Weekly issue.

muxriddinmuqimov77 commented 1 year ago

I'd like to work on this issue

s-alves10 commented 1 year ago

I'd love to work on this.

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!