[HOLD for payment 2023-04-10] [$1000] [Regression] Request Money - Amount field not auto focused if suddenly loose focus

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR https://github.com/Expensify/App/pull/16394

Action Performed:

1. Launch expensify app
2. Login with any account
3. Tap on the FAB button -> Send money
4. Enter numbers
5. Click outside of numpad
6. Enter numbers

Expected Result:

Autofocus Amount field if suddenly loose focus

Actual Result:

Amount field not auto focused if suddenly loose focus

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.2.89.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/227730584-334957a6-c2e6-4b3d-8e2e-2baa715af479.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dbf046ada3294608
• Upwork Job ID: 1640296677002747904
• Last Price Increase: 2023-03-27

[mountiny]

@0xmiroslav would you be able to help with the Checklist please? Then we can pay out

[0xmiros]

The PR that introduced the bug has been identified. Link to the PR:

This issue existed from the beginning but we missed web desktop case while fixing mWeb issue on https://github.com/Expensify/App/pull/16394

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/issues/15855#issuecomment-1505849502

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is already in checklist. I ran the tests on all platforms & verified they passed on: ... so no need further discussion I think.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think Test Steps in PR can be used for regression test steps.

[mountiny]

Thank you! I think Sonia is ooo so I will ask someone to help with this.

[mountiny]

@sonialiap we should pay $1000 to @0xmiroslav and we should be all set

[Christinadobrzyn]

Helping with payment:

Looks like this job is eligible for the speed bonus. Upwork job - https://www.upwork.com/ab/applicants/1640296677002747904/job-details

@narefyev91 can you please provide your Upwork profile so I can hire you for this job? @0xmiroslav I submitted a request to hire you for the job, let me know when you accept and I'll pay.

[0xmiros]

@Christinadobrzyn I am only the one for upwork payment. @narefyev91 is a callstack member.

[Christinadobrzyn]

Ah thank you for confirming @0xmiroslav!

Submitted Test Rail regression test here - https://github.com/Expensify/Expensify/issues/276043

Paid $1000 + $500 speed bonus to @0xmiroslav

Closing this GH

[hayata-suenaga]

I'm coming to this issue from another issue issue.

The event.preventDefault(); was added in the the PR to fix this issue. However, the original issue doesn't seem to be a problem. Isn't it an expected behavior that the text input looses focus if you click outside of it?

[hayata-suenaga]

decided to go with this fix