[HOLD for payment 2023-06-21] [$1000] Pressing Enter/Return from DOB field highlights “choose your document “ text in next onfindo page.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com on mweb
2. Go to Settings > Workspaces > [select a workspace] > Connect bank account.
3. Fill in routing and bank details in connect bank account page.
4. Go to the Personal Information page. Fill in all the details.
5. Now go to the Date of Birth field ( press click )
6. Now press enter
7. The application must redirect to a new page
8. Notice that the text “ Choose your documents” is highlighted by a blue border.
9. Plus in Mac chrome pressing enter on any field results in the highlighting issue.

Expected Result:

Text should not be highlighted while pressing return from previous page

Actual Result:

Highlighting certain text on the onfindo page degrades UI.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.2.90-7 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/228321188-0330f68f-091b-4dee-bf0a-df9c0b2f4c17.mp4

https://user-images.githubusercontent.com/43996225/228321304-203f4621-cf9a-4cac-8794-7334d74afdcd.mp4

Expensify/Expensify Issue URL: Issue reported by: @ashimsharma10 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679996395453299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143cbaf19b602982f
• Upwork Job ID: 1642082307866021888
• Last Price Increase: 2023-04-15

[allroundexperts]

Another update. Received this today:

[allroundexperts]

@tgolen Is it really worth the wait when this can be fixed easily from our side? We're already using custom styles for the Onfido SDK and adding to those styles shouldn't be an issue IMO.

[tgolen]

Yeah, at this point, let's move ahead with the temporary fix. I would still pursue and upstream fix for the long-term though.

[allroundexperts]

Another update. Received this about an hour ago:

[melvin-bot[bot]]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

I need to reassign this since I am going on extended leave

[eVoloshchak]

Yeah, at this point, let's move ahead with the temporary fix. I would still pursue and upstream fix for the long term though.

@marcochavezf, since this won't be fixed by Onfido any time soon and we need to implement it ourselves, @allroundexperts's proposal looks good to me

This should be fixed by Onfido at some point, but how do we track it? Is there some process do to it?

[mallenexpensify]

It sounds like we should fix ourselves if we have no idea of onFido ever will. @marcochavezf 's off today, maybe back on Monday

[marcochavezf]

Catching up. So let's do it here, assigning @allroundexperts! 🚀

[marcochavezf]

This should be fixed by Onfido at some point, but how do we track it? Is there some process do to it?

Good question, seems the Onfido support is internal, and we can only reach them via email. If they're going to fix it eventually in an upcoming release, I think we can :donothing: atm and just wait. Otherwise, we can reach them out again, but probably we can get the same response.

[melvin-bot[bot]]

📣 @allroundexperts You have been assigned to this job by @marcochavezf! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

Will hire folks soon, Upwork was buggy an hour ago

[allroundexperts]

PR created https://github.com/Expensify/App/pull/20248

[ashimsharma10]

Dear contributors,

While reloading the above page, the same issue occurs. Just a cross-check, have we tried fixing that too?

https://github.com/Expensify/App/assets/43598308/77c96e2b-7ad4-4c88-83ba-4c2dddde386b

[eVoloshchak]

@ashimsharma10, yup, this was also fixed by https://github.com/Expensify/App/pull/20248

https://github.com/Expensify/App/assets/9059945/99c680f7-8c8d-49cd-899e-4fe35153cabe

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.27-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/20248

If no regressions arise, payment will be issued on 2023-06-21. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eVoloshchak / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eVoloshchak / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eVoloshchak / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eVoloshchak / @allroundexperts] Determine if we should create a regression test for this bug.
• [ ] [@eVoloshchak / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

@ashimsharma10, @allroundexperts, @eVoloshchak , can you please accept the job? https://www.upwork.com/jobs/~01d186d1de3073e2cf

[allroundexperts]

Accepted.

[allroundexperts]

@mallenexpensify I think this one is also due for a bonus.

[ashimsharma10]

@mallenexpensify Accepted 👍

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: N/A, this was a bug in an external library
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It's a simple visual bug, I don't think there are additional steps we could take besides an automated UI testing
• Determine if we should create a regression test for this bug. The bug is very minor, doesn't break usage of the app, so I don't think a regression test is needed here

[mallenexpensify]

@mallenexpensify I think this one is also due for a bonus.

So I hopefully don't forget when I come back to pay. :)

[mallenexpensify]

@allroundexperts and @eVoloshchak paid $1500 each, inc. timeliness bonus @ashimsharma10 paid $250 for reporting.

Added to the Edge Cases and Design Issues - Tracking Sheet