Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[Hold on #15992] Composer not focused when user leaves/returns an ongoing DM draft #16699

Closed kavimuru closed 9 months ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to any chat
  2. click on composer
  3. click on users name to see the details
  4. close the details page

Expected Result:

composer should focused (same as web, mWeb)

Actual Result:

composer not focused

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.91-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/228643092-728b6ce2-119b-4f2f-958d-0ecd676cb062.mp4

https://user-images.githubusercontent.com/43996225/228643119-13f950d1-3457-47f2-8921-20da7430f05f.mp4

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680088305065359

View all open jobs on GitHub

MelvinBot commented 1 year ago

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

MelvinBot commented 1 year ago

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

michaelhaxhiu commented 1 year ago

@bondydaa do you think we should close this GH or keep it on hold for https://github.com/Expensify/App/issues/15992?

michaelhaxhiu commented 1 year ago

Posted in slack here - https://expensify.slack.com/archives/C049HHMV9SM/p1680715074199869?thread_ts=1680301816.029279&cid=C049HHMV9SM

michaelhaxhiu commented 1 year ago

Holding till we hear back. This is valid but it may be better to consolidate with the tracking GH.

bondydaa commented 1 year ago

I think the SOP has been to put a HOLD on any issues created and link it on the tracking GH.

michaelhaxhiu commented 1 year ago

Excellent, let's do the same here. Thanks Bondy :)

This job is on hold for https://github.com/Expensify/App/issues/15992

michaelhaxhiu commented 1 year ago

held for now

michaelhaxhiu commented 1 year ago

holding, still ⏸️

michaelhaxhiu commented 1 year ago

stil held

michaelhaxhiu commented 1 year ago

Still held, commented on blocking GH to see if we have any indication of prioritization on this one.

michaelhaxhiu commented 1 year ago

No movement, still held

michaelhaxhiu commented 1 year ago

same

michaelhaxhiu commented 1 year ago

held and no movement on blocking GH

michaelhaxhiu commented 1 year ago

still held

michaelhaxhiu commented 1 year ago

Note: I'm preparing to go OOO for ~2 weeks, and doubt this will see movement while I'm gone. I'm going to keep it assigned for that reason and not add a buddy. If it gets movement (and I'm wrong), please remove & reapply the bug label.

michaelhaxhiu commented 1 year ago

Back from OOO. Still no movement.

michaelhaxhiu commented 1 year ago

Not a priority yet.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

michaelhaxhiu commented 11 months ago

I'm re-assigning the Bug label to get a new BZ on this, as my sabbatical starts Friday.

Next steps:

Thanks in advance!

muttmuure commented 10 months ago

Not a priority yet

muttmuure commented 9 months ago

Still on hold

mountiny commented 9 months ago

Discussing with @muttmuure I think we can close this one in light of focus on waves and roadmap issues. It is also correctly linked in the tracking issue if we need to come back to this in future. Feel free to reopen if you disagree