Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

[$1000] Receiving email notification more often when setting preference as `Daily` #16722

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to room
  2. Set Notify me about new messages to Daily
  3. Send a message in the room

Expected Result:

Notification email sent after 24 hours only

Actual Result:

Receiving much more often

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

image (1) image

Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680017266261259

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a59d9867919cfdc
  • Upwork Job ID: 1641357889469644800
  • Last Price Increase: 2023-03-30
MelvinBot commented 1 year ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

CortneyOfstad commented 1 year ago

I also experience this myself and if I can be frank — it's very annoying 😂 Getting eyes on this!

MelvinBot commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~012a59d9867919cfdc

MelvinBot commented 1 year ago

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

MelvinBot commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

MelvinBot commented 1 year ago

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

alexxxwork commented 1 year ago

Isn't it a backend problem? The setting comes correctly to the API

image

puneetlath commented 1 year ago

Yes, this is a back-end issue and will need to be Internal.

MelvinBot commented 1 year ago

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

MelvinBot commented 1 year ago

@francoisl, @CortneyOfstad, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

puneetlath commented 1 year ago

I believe @jasperhuangg might've said they were already working on a fix for this.

francoisl commented 1 year ago

Yeah @jasperhuangg let me know if you have some context, looks like we're always entering this block, now since this change.

Here are logs examples for the report from the screenshot in the OP, 8264054345802435.

francoisl commented 1 year ago

Oh wait nevermind, I think Jasper's PR I linked to actually resolves this issue? I can't reproduce the issue locally anyway. The fix is not deployed to production yet.

francoisl commented 1 year ago

The fix is deployed to production, and internal logs confirm there were no new notifications incorrectly sent. Closing.