[HOLD for #37437][$2000] Pressing `space` 2 times `.` appears in display name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to iOS settings > iPhone Settings >> General >> Keyboards > toggle on "." Shortcut
2. Open the ios mobile app or iOS Safari or Mac Desktop Chrome
3. Tap Setting > Profile
4. Tap Display Name remove name
5. Write new text and press space button 2 times and see the result (the "." shortcut doesn't work even though it's enabled)

Expected Result:

if "." shortcut is enabled, the shortcut should work when tapping the space 2 times

Actual Result:

if "." shorcut is enabled, the shortcut doesn't work when tapping the space 2 times

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [ ] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.2.96-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/230680037-97e38841-3890-4671-a905-6757633be3f0.mp4

https://user-images.githubusercontent.com/43996225/230680041-a8b718bc-2575-43d1-9d83-dc2662c3094a.mp4

https://user-images.githubusercontent.com/43996225/230680087-d94f2354-2a45-498a-9705-f9f691ea13e3.MP4

Expensify/Expensify Issue URL: Issue reported by: @harshad2711 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680851400066889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194127eb40345b2ea
• Upwork Job ID: 1646595046183731200
• Last Price Increase: 2023-04-20

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

This is not issue. This is iOS keyboard specific features.

Follow this Steps to Disable It: Go to iPhone Settings >> General >> Keyboards >>

You will see this screen, So disable "." Shortcut settings as show below, It will solve the problem.

[MelvinBot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Thanks @PrashantMangukiya! I'll reach out in the slack chat to see if we can do some more testing - https://expensify.slack.com/archives/C049HHMV9SM/p1681247093995989?thread_ts=1680851400.066889&cid=C049HHMV9SM

[Christinadobrzyn]

did some testing and updated the OP - asking for a quick review to make sure I understand correctly - https://expensify.slack.com/archives/C049HHMV9SM/p1681334171519149?thread_ts=1680851400.066889&cid=C049HHMV9SM

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0194127eb40345b2ea

[MelvinBot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[Christinadobrzyn]

Updated OP based on Slack chat - I think this can be External.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

@chiragsalian, @Christinadobrzyn, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hasebsiddiqui]

https://github.com/facebook/react-native/issues/27693

[Christinadobrzyn]

Looks like we're waiting on more proposals

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MelvinBot]

Upwork job price has been updated to $2000

[Christinadobrzyn]

Raised price to $2000

[PrashantMangukiya]

@Christinadobrzyn @chiragsalian @0xmiroslav I think this is working as expected in our app and there is no issue.

Here is what happen, When you tap space twice at the end of sentence it will put "." Now delete that dot and tap space twice again it will not put dot.

Add some text and tap space twice it will put "." Now delete that dot and tap space twice again it will not put dot.

Add some text and tap space twice it will put "." Now delete that dot and tap space twice again it will not put dot.

Repeat this step, it will show same behaviour.

I tested it within message app. This is expected behaviour, it looks like there is not any issue in our app. Below is the video for comparison.

Expensify App

https://user-images.githubusercontent.com/7823358/233493871-7b6aceaf-c00f-46b1-a684-dda02288b526.mov

Message App

https://user-images.githubusercontent.com/7823358/233494889-9c5bf7b4-164e-4563-98a9-0f1690427c98.mov

Thank you.

[Christinadobrzyn]

Thanks for reviewing @PrashantMangukiya! To confirm, do you have "." enabled or disabled in the iOS settings?

[PrashantMangukiya]

Thanks for reviewing @PrashantMangukiya! To confirm, do you have "." enabled or disabled in the iOS settings?

@Christinadobrzyn Yes "." enabled in the iOS keyboards settings.

[Christinadobrzyn]

ah okay! I'll close this for now. Thank you so much for your help looking into this!

[harshad2711]

@Christinadobrzyn Why did you close this bug, I still have a problem

[harshad2711]

https://user-images.githubusercontent.com/123926740/233534492-095b75f8-a3ea-4a2a-93e2-b7dac47d4b3f.MOV

See this @Christinadobrzyn @PrashantMangukiya

[PrashantMangukiya]

@Christinadobrzyn I think what @harshad2711 said in above comment is correct for iOS native.

In fact what I noticed is, in iOS Safari it shows dot upon double space. But in iOS Native it is does not show, wired behaviour. i.e. three dot works on iOS Safari but not iOS native. I think we should re-open issue to make it working for iOS Native also. Sorry for the confusion.

iOS Native (Dot Not Working)

https://user-images.githubusercontent.com/7823358/233536734-ad486aad-18ca-491f-b86a-fd6e312959bf.MP4

iOS Safari (Dot Working)

https://user-images.githubusercontent.com/7823358/233536839-8ff4a215-a16a-4eb2-b9f2-99acb04dd88b.MP4

[chiragsalian]

Yup reopening, looks like a legit bug

[harshad2711]

Thank you😃

[MelvinBot]

@chiragsalian, @Christinadobrzyn, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Looks like we're waiting on some proposals.

[MelvinBot]

📣 @mohamedwshams! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[gedu]

Hey, hey, I am from Callstack - expert contributor group, I can take a look

[MelvinBot]

📣 @gedu You have been assigned to this job by @chiragsalian! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[chiragsalian]

Assigned the issue over to you @gedu

[gedu]

Still looking into this, my current findings are:

Seems that if we don't use the value prop from TextInput, the double-tapping space works, it adds the dot.

Here I start debugging the Bridge and if I don't use the value from Native it sends the . after the second space

But when I add the value prop, Native doesn't send the . after the second space.

I will need to dig deeper, I will start looking at react-native TextInput source code and see what happens with the value prop at that level.

[gedu]

Didn't have the time today to take a deeper look, I'm almost finishing the other task, as soon as I finished I continue with this one

[Christinadobrzyn]

Still investigating, please feel free to provide more of an update when you have one @gedu!

[gedu]

Tomorrow will make some time to look at this

[gedu]

New finding. if we use the prop value the double-space won't work, because of some logic that is given in RCTSinglelineTextInputView.

(Here are some of the steps, the dot isn't added)

But if we add the prop multiline (to be true) internally it uses RCTMultilineTextInputView and it works (even with the prop value)

(Here are some steps that and it adds the dot)

Internally they use an Input adapter RCTBackedTextFieldDelegateAdapter, which is different for each, and it differs in some small flows. I couldn't find the main diff between them, so I will keep looking.

Note: Seems that using multiline works on every environment

[melvin-bot[bot]]

@gedu @chiragsalian @Christinadobrzyn @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[Christinadobrzyn]

Not sure what we need to do next for this to stay on schedule. @0xmiroslav or @chiragsalian would you have some insights into what to do next?

[0xmiros]

We're still waiting for @gedu's final proposal. No other actions needed to be taken.

[gedu]

Hey, still digging into this, because adding multiline to all our inputs I don't think is a good solution, I wanna track what are the differences between RCTSinglelineTextInputView and RCTMultilineTextInputView so maybe I can come up with a final proposal.

[gedu]

Hey, trying to wrap another task, as soon as I finish I will continue here

[gedu]

Hey, still couldn't find the time to take a look, but found that is something that was already asked but closed. I will make some time tomorrow to take a look

[gedu]

Hey today I've been checking more about how the native inputs behave on iOS, Still couldn't find the right path, I will start doing a flow chart to see in which steps Multiline and Single line differ and also create an issue on react-native GH so I can get some inputs from them and probably they can guide me.

[gedu]

Looking into this a bit further, it could be something related to the autocorrect but not sure, so I created an issue on react-native: https://github.com/facebook/react-native/issues/37437

This will take longer than expected, can we change the label to weekly? @Christinadobrzyn

[strepanier03]

👋 hey, quick note that we should keep all e/app GHs as daily unless they have "Hold" in the title. I'm going to flip this back to daily as I'm doing the resync and it's step in the SO process guide.

[gedu]

I did some deeper investigation and created an Objective-C project to test the different behaviors, I could set and understand better the flow of the UITextField used by Singleline component. Also trying to get in touch with some devs in Meta/FB so I can get my issue reviewed or get some help

[gedu]

Ok I think I found a fix for it

The issue:

It appears that when the value prop is not set in the SinglelineTextInput component, an internal state is established only once. However, when the value prop is set, the internal updateState method is invoked at least twice. Interestingly, after the first invocation, the state remains unchanged. This repeated execution of the updateState method disrupts the expected double-tapping behavior since the double-space input does not occur consistently.

To address this issue, I am currently conducting tests. It seems that preventing the updateState method from being executed multiple times will resolve the problem and restore the desired functionality.

[gedu]

I run some tests, and seems to be working, I'm discussing a proposal internally