search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.77k forks source link

[HOLD for #37437][$2000] Pressing `space` 2 times `.` appears in display name #17153

Open kavimuru opened 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to iOS settings > iPhone Settings >> General >> Keyboards > toggle on "." Shortcut
  2. Open the ios mobile app or iOS Safari or Mac Desktop Chrome
  3. Tap Setting > Profile
  4. Tap Display Name remove name
  5. Write new text and press space button 2 times and see the result (the "." shortcut doesn't work even though it's enabled)

Expected Result:

if "." shortcut is enabled, the shortcut should work when tapping the space 2 times

Actual Result:

if "." shorcut is enabled, the shortcut doesn't work when tapping the space 2 times

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.96-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/230680037-97e38841-3890-4671-a905-6757633be3f0.mp4

https://user-images.githubusercontent.com/43996225/230680041-a8b718bc-2575-43d1-9d83-dc2662c3094a.mp4

https://user-images.githubusercontent.com/43996225/230680087-d94f2354-2a45-498a-9705-f9f691ea13e3.MP4

Expensify/Expensify Issue URL: Issue reported by: @harshad2711 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680851400066889

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0194127eb40345b2ea
  • Upwork Job ID: 1646595046183731200
  • Last Price Increase: 2023-04-20
0xmiros commented 8 months ago

Not overdue

gedu commented 8 months ago

Pinging the reviewer of the PR and also chatting with another dev that works with Text and TextInput

gedu commented 8 months ago

@0xmiroslav @mountiny Probably I will need some backup, so I can get the PR reviewed https://github.com/facebook/react-native/pull/39385

mountiny commented 8 months ago

asked

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

mallenexpensify commented 8 months ago

@eVoloshchak reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

eVoloshchak commented 8 months ago

@gedu, the current status on this is we're expecting a response from FB, is that correct?

We're facing the same problem in https://github.com/Expensify/App/issues/19507#issuecomment-1894295180

this is reliant on pull request to the react-native repository... Is there anything we (or one of our expert contributor agencies) can do to get this moving along? It's literally been months of nothing, unfortunately.

Linking here in case something can be done about it

gedu commented 8 months ago

@eVoloshchak Yes, it is correct

Christinadobrzyn commented 7 months ago

just to confirm an update here - @gedu are you working on a resolution to this or do you need us to reach out to anyone else for review/assistance?

mountiny commented 7 months ago

We are waiting for a response, nothing actionable right now. Any updates @gedu ?

gedu commented 7 months ago

Waiting for a review or feedback from FB @Christinadobrzyn @mountiny

Christinadobrzyn commented 7 months ago

Hi @gedu any update on the feedback? Thanks!

gedu commented 7 months ago

No updates, I pinged again

gedu commented 7 months ago

No updates, some new bugs were linked to my PR I will try to test them and see if my PR fixed them so I can get some support

gedu commented 6 months ago

I could confirm that my PR fixes another issue, trying to get more visibility: https://github.com/facebook/react-native/pull/39385#issuecomment-1973953402

Christinadobrzyn commented 6 months ago

hi @gedu how are things going? If you can provide an update that'd be great! Thank you!

gedu commented 6 months ago

Hey hey, the PR is getting more views, I will try to get more help

gedu commented 6 months ago

No updates yet

gedu commented 5 months ago

I joined the React Discord, so I'm trying to get some help

gedu commented 5 months ago

With Michal Pierzchala, we placed a message into a channel (code-review), no news yet

Christinadobrzyn commented 5 months ago

just checking in on this @gedu. thanks!

gedu commented 5 months ago

I ping on the PR and on the Discord channel again, but no news

Christinadobrzyn commented 5 months ago

Just checking in @gedu. thank you! Do you think this needs to be moved to Monthly? cc @chiragsalian

Christinadobrzyn commented 4 months ago

Should we move this to monthly @chiragsalian @gedu?

gedu commented 4 months ago

Should we move this to monthly @chiragsalian @gedu?

Maybe yes, I still have no responses

gedu commented 3 months ago

No updates, I have some conflicts on my PR that I will fix soon

eVoloshchak commented 3 months ago

@gedu, any updates on the PR?

gedu commented 3 months ago

No yet, I didn't have the time to fix the conflicts, I working on other Critical tickets

gedu commented 3 months ago

I received a review and a new comment, so I will look into them more actively to ensure we don't lose this new momentum.

gedu commented 3 months ago

Keep looking if I can place my fix in another place of the code as suggested

gedu commented 3 months ago

I found another way to fix the bug without using a new flag for early exit, waiting for it

gedu commented 2 months ago

I pinged the reviewer, still waiting

gedu commented 2 months ago

Hey, I will ping today, still no news. I created another issue related with TextInput, if that one get attention I will try to mention this one, so maybe it gets some momentum again. I will be on vacation, when I'm back I will check the situation again

Christinadobrzyn commented 1 month ago

Hi @gedu just checking in on this for an update - thank you!

gedu commented 1 month ago

Hey, no yes, I pinged less of 2 weeks ago, but no response. I will try on Discord

gedu commented 4 weeks ago

Hey, I wrote on Discord trying to call my PR attention, still no news

mallenexpensify commented 4 weeks ago

Thanks @gedu , we've def found that upstream fixes can take a while.

gedu commented 13 hours ago

I sent another ping to the reviewer