[HOLD for payment 2023-04-24] [$1000] Done button increases font size on click

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings -> Click profile picture
2. Click Personal details -> Home address
3. Click on country to open picker
4. Click on Done button

Expected Result:

Done button text size should stay same when clicked

Actual Result:

Done button font size changes on click

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [x] iOS / native
• [ ] iOS / Safari
• [ ] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/230700569-dc01f1cb-5650-46da-af8e-52bd291bae82.MP4

Expensify/Expensify Issue URL: Issue reported by: @dinaljivani Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680905677209739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb9a225908cf716a
• Upwork Job ID: 1645622506297696256
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[arielgreen]

I was able to reproduce using the described steps.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb9a225908cf716a

[MelvinBot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Done button increases font size on click

What is the root cause of that problem?

The root cause is that the styles defined in react-native-picker-select library for the done button in depressed state has different font size than the one in non depressed state. This can be seen here.

What changes do you think we should make in order to solve the problem?

We need to add the following styles to our implementation of react-native-picker-select here and here.

doneDepressed: {
    fontSize: defaultPickerStyles.done.fontSize,
}

The defaultPickerStyles can be imported using:

import {defaultStyles  as  defaultPickerStyles} from  'react-native-picker-select/src/styles';

This will fix the issue but if required, we can customise this further to use Expensify styles instead of the default ones defined in the library.

What alternative solutions did you explore? (Optional)

None

[MelvinBot]

Triggered auto assignment to @luacmartins (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[etechall]

Issue is in the Defined style, Can be corrected through done.fontSize by using Expensify Style.

[MelvinBot]

📣 @etechall! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[etechall]

Contributor details Your Expensify account email: admin@snologies.com Upwork Profile Link: https://www.upwork.com/freelancers/~01edeb68c8157883fc

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[hellohublot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Done button increases font size on click

What is the root cause of that problem?

defaultStyles.done.fontSize = 17 but defaultStyles.doneDepressed.fontSize = 19, the text is enlarged

What changes do you think we should make in order to solve the problem?

We can clear defaultStyles.doneDepressed.fontSize, It won't clear the defaultStyles.done.fontSize, because it is not in the same style array https://github.com/Expensify/App/blob/3abe7b2f9e38dba42edf406ca1b1e19087f5599d/src/styles/styles.js#L943-L945

+   doneDepressed: {
+       fontSize: undefined
+   },

What alternative solutions did you explore? (Optional)

Not Yet

[luacmartins]

@allroundexperts your proposal looks good and is consistent with how we set other picker styles. Assigning you to the job!

[MelvinBot]

📣 @allroundexperts You have been assigned to this job by @luacmartins! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[MateenAla]

Hi sir, I want to know if the done button is fixed or not. Please, Let me know.

[MelvinBot]

📣 @MateenAla! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MateenAla]

Contributor details Your Expensify account email: muteen.alam40@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~011147135e48f9e95d

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[luacmartins]

@MateenAla Thanks for the interest in this issue. I already assigned a contributor for this job. However, we have many others issues waiting for proposals

[allroundexperts]

PR created https://github.com/Expensify/App/pull/17314

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.0-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/17314

If no regressions arise, payment will be issued on 2023-04-24. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter @DinalJivani
• [x] Contributor that fixed the issue @allroundexperts
• [x] Contributor+ that helped on the issue and/or PR @eVoloshchak

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@eVoloshchak / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [x] [@eVoloshchak / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [x] [@eVoloshchak / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@arielgreen] Determine if we should create a regression test for this bug.
• [x] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@arielgreen] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arielgreen]

@eVoloshchak do you think we need to create a regression test for this?

[eVoloshchak]

Is it easy to test for this bug?

Yes

Is the bug related to an important user flow? (For example, adding a bank account)

This is purely a visual bug that doesn't prevent user from using the app

Is it an impactful bug?

No, it's a small visual bug that is present on a single platform. Additionally, we will be moving away from the native picker (not sure if that applies to this page, haven't seen the designs).

@arielgreen, all in all, I think the regression test isn't needed, this is a very low-impact bug

I'll finish the first 3 items of the BZ checklist tomorrow

[arielgreen]

@allroundexperts @eVoloshchak @DinalJivani please be sure to apply to the posting on Upwork so I can send payment: https://www.upwork.com/jobs/~01fb9a225908cf716a

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: not applicable, that's an issue with an external library
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: there's already a discussion here

  Continuing discussion here to catch and avoid this type of bug in the future: When we update code related to app theme, we should make sure to test all of these views throughout the app: scrollbar color default text color picker background and text colors locale picker background and text colors date picker input cursor color native alert |(i.e. when deny camera permission)

[DinalJivani]

@arielgreen
Applied on Upwork!

[allroundexperts]

@allroundexperts @eVoloshchak @DinalJivani please be sure to apply to the posting on Upwork so I can send payment: https://www.upwork.com/jobs/~01fb9a225908cf716a

@arielgreen Applied.

[arielgreen]

Offers sent, just waiting on acceptance and then ready to issue payments

[allroundexperts]

@arielgreen I think you were supposed to send an offer of 1500 but instead sent 2000. Can you please check?

[luacmartins]

Just waiting on payment. @arielgreen can you check the previous comment please? Seems like the offer amount might be incorrect.

[arielgreen]

@allroundexperts thank you so much for catching that! You are correct. I modified and resent the offer.

@eVoloshchak I did the same thing for your contract as well 😅 Apologies.

[luacmartins]

just waiting on payments

[luacmartins]

Are we still waiting on payment here?

[arielgreen]

Payments have been issued, @luacmartins and @eVoloshchak this can be closed once the checklist is completed.

[luacmartins]

@eVoloshchak would you mind completing the checklist?

[eVoloshchak]

@arielgreen, the last 3 checklist items are here: https://github.com/Expensify/App/issues/17180#issuecomment-1521694473