search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

[HOLD App/issues/16660] [$2000] Pinch to zoom on a Macbook browser dynamically changes the app's view and components #17246

Closed kavimuru closed 11 months ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. When a chat is open, pinch to zoom on either the LHN or the details tab. 1 (alternate). On a fresh sign in page, zoom in on any part of the site with pinch to zoom.

    Expected Result

    The page doesn't reorganize or shfit as you zoom in this way, this should be equivalent to magnification and shouldn't change the content ordering or structure of the app.

    Actual Result

    App re-renders into different various forms as you zoom in breaking your ability to zoom into

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.98-1 Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231004704-3ffa4eb5-bcb9-456f-83c7-555e63e266b5.mov

Expensify/Expensify Issue URL: Issue reported by: @johnmlee101 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681152993219619

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01caf96ff9d8613c10
  • Upwork Job ID: 1646608088499531776
  • Last Price Increase: 2023-05-02
alitoshmatov commented 1 year ago

@tgolen @fedirjh I propose creating a new issue to update react-native-web with upstream fork, adopt changes in our expensify/app and update all effected packages respectively. And we can put the current issue on hold. I think, resolving these two issues here in one slowed down our progress and made it hard to manage

What do you think?

fedirjh commented 1 year ago

I think we should hold this for https://github.com/Expensify/App/issues/16660 , even if we sync the fork with upstreams , we can’t really merge the new version , there are some deprecations that should be handled as well.

tgolen commented 1 year ago

OK, sounds good to me. I'll place this on HOLD for now then. Thanks!

alexpensify commented 1 year ago

@dylanexpensify and @NicMendonca - I appreciate your help here! I'm back online and removing your assignment.

alexpensify commented 1 year ago

@tgolen - with Rory's feedback here https://github.com/Expensify/App/issues/16660#issuecomment-1560003585, should we make this one a Weekly now?

alexpensify commented 1 year ago

Thank you, Tim!

alexpensify commented 1 year ago

@fedirjh - when you get a chance, can we get feedback on the next steps here and the current proposals? Thanks!

fedirjh commented 1 year ago

@alexpensify This issue is on hold. What proposals are you referring to ?

alexpensify commented 1 year ago

@fedirjh - disregard, I mixed this one up with another GH. For now, I'm hiding my last comment to avoid more confusion.

alexpensify commented 1 year ago

Still on hold here

alexpensify commented 1 year ago

Still on hold

alexpensify commented 1 year ago

On hold

alexpensify commented 1 year ago

Still on hold here

alexpensify commented 1 year ago

On hold here, the other GH is still accepting proposals.

alexpensify commented 1 year ago

Still on hold here

alexpensify commented 1 year ago

On hold

alexpensify commented 1 year ago

Still on hold here

alexpensify commented 1 year ago

Weekly update: On hold

alexpensify commented 1 year ago

Weekly update: On hold

alexpensify commented 1 year ago

Weekly update: On hold

alexpensify commented 1 year ago

Weekly update: On hold

alexpensify commented 1 year ago

Weekly update: On hold but looks like there is movement in

johnmlee101 commented 1 year ago

Hmm, that goes to an unrelated PR?

alexpensify commented 1 year ago

Whoops, thanks for flagging, https://github.com/Expensify/App/issues/16660 should be the correct one

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 1 year ago

Weekly Update: There should be a PR soon for the GH that put this one on hold

alexpensify commented 1 year ago

Weekly update: On Hold

alexpensify commented 12 months ago

Weekly update: On Hold but we had some GH movement yesterday. 🤞🏼

alexpensify commented 11 months ago

Weekly update: On Hold

fedirjh commented 11 months ago

RNW upgrade PR has been merged, we can remove the hold once it has been deployed to production.

alexpensify commented 11 months ago

Thank you for that update @fedirjh!

alexpensify commented 11 months ago

@fedirjh - I realized that I don't think the PR you mentioned last week is in this GH. Can you please share the link since the one in the title has many PRs associated with it now? Thanks!

fedirjh commented 11 months ago

@alexpensify This is the PR, it was just deployed to production

alexpensify commented 11 months ago

It is time! @tgolen and @fedirjh are you OK for me to take this one off hold and move it back to daily? I'm assuming that we will need updated proposals but keep me posted on the next steps. We can prepare accordingly. Thanks!

fedirjh commented 11 months ago

are you OK for me to take this one off hold and move it back to daily?

I think this should be awaiting for the regression period then payments as the bug was fixed.

I'm assuming that we will need updated proposals but keep me posted on the next steps.

@alexpensify The upgrade PR already includes the fix that was proposed in this issue, the fix was pushed and merged upstream and was released in the RNW v 0.19.

This video demonstrates that the bug was fixed:

https://github.com/Expensify/App/assets/36869046/e9da790e-05f1-42ee-8074-dfb9c11c44ef

alitoshmatov commented 11 months ago

https://github.com/Expensify/App/pull/24482 is live, which means we can take this issue off hold, finally 🥳

alexpensify commented 11 months ago

Ok, I chatted with @tgolen. Let's keep this one on hold to clear the regression period.

@fedirjh - Sorry, I'm confused are you suggesting that the PR (https://github.com/Expensify/App/pull/24482) for https://github.com/Expensify/App/issues/16660 fixed this issue too? If yes, then we will need to prepare for partial payment here instead of another fix when the HOLD is removed in this GitHub? I want to confirm the required actions since I will be OOO next week. If there is no new fix for this issue, then can find a replacement to take over the payment process in Upwork. Thanks!

fedirjh commented 11 months ago

Sorry, I'm confused are you suggesting that the PR (https://github.com/Expensify/App/pull/24482) for https://github.com/Expensify/App/issues/16660 fixed this issue too?

@alexpensify We addressed this particular issue upstream, and the corresponding fix was included in the release of RNW v0.19. In PR #24482, we upgraded to RNW v0.19, which inherently incorporates the fix. As a result, no further action is needed at this point.

If yes, then we will need to prepare for partial payment here instead of another fix when the HOLD is removed in this GitHub?

The upstream fix was a part of this issue. The process for this issue was :

  1. Open upstream PR and fix the issue: https://github.com/Expensify/App/issues/17246#issuecomment-1546607949
  2. Open same PR in our RNW fork: https://github.com/Expensify/App/issues/17246#issuecomment-1542586647
  3. Open a PR in our App to bump the version of our RNW in E/App.

Steps 1 and 2 were successfully completed. Upon completing the final step, the decision was made to discontinue the RNW fork. Instead, we began utilizing the react-native-web package directly within E/App.This transition was handled in #16660 (PR #/24482).

Given that RNW v0.19 has now been merged into our App, the third step is no longer necessary.

alexpensify commented 11 months ago

Got it, we will close after the regression period and prepare for the payment period. Thanks!

alexpensify commented 11 months ago

Reassigning another team member, I'm going OOO until Monday, November 27, and will take it back if it's still open by my return date.

@laurenreidexpensify - Required action from the team:

There will need to be a payment after the regression period closes while I'm offline next week. I haven't been able to write up a payment summary but will need help with that one before the payment date and then pay everyone via Upwork. Thanks!

laurenreidexpensify commented 11 months ago

Ready for payment, regression period has passed as https://github.com/Expensify/App/pull/24482 has been on staging for a week

laurenreidexpensify commented 11 months ago

Payment Summary:

laurenreidexpensify commented 11 months ago

Offers sent in Upwork,

@fedirjh is there a regression test that we need to add for this one?

alitoshmatov commented 11 months ago

Accepted the offer

laurenreidexpensify commented 11 months ago

Payment Summary: