[HOLD for payment 2023-04-27] [$1000] Date field allows spaces between the numeric digits, unlike other numeric fields (like Rate)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to web Chrome/Android
2. Go to any workspace
3. Go to reimburse expenses and try to add a space in the rate field. Notice that it doesn't allow any spaces
4. Now go to the personal information and date of birth field
5. Go to year and try to input a number followed by spaces and notice that it allows spaces in the field

Expected Result:

Space should not be allowed in the year field - it should mirror that of the rate input field.

Actual Result:

Spaces are allowed in the year search field between the numeric digits.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.2.98-2 / v99-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231254245-fdc104a2-d8b3-4b2c-bb7d-22fc4756c3ab.mp4

Expensify/Expensify Issue URL: Issue reported by: @priya-zha Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681201745994509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ecf6260853d6f525
• Upwork Job ID: 1645992955077120000
• Last Price Increase: 2023-04-12

[MelvinBot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

On v99.4 (Mac) and can reproduce. Also occurs on Android (Pixel 3a, v98-2).

This is a minor bug, but I agree that the year field should mirror the rate field, as there aren't spaces in a year.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ecf6260853d6f525

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that the space character is allowed when searching for the year, which should not be allowed.

What is the root cause of that problem?

When filtering, we do not sanitize the input provided by the user and directly use whatever is provided. https://github.com/Expensify/App/blob/e8bc6a86f13fd2f5561de5e6251abffa8f890384/src/pages/YearPickerPage.js#L75

What changes do you think we should make in order to solve the problem?

We should create a regex rule that sanitizes whatever is typed by the user. This can be as simple as /[\D]/g, which will replace and remove anything that is not a digit from the user input. We can filter the results based on that.

Additionally, we can add some more constraints such as the maximum number of characters that the user can enter is 4.

[MelvinBot]

Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aman-atg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The current implementation allows spaces in the year search field between the numeric digits, which is not consistent with other numeric fields in the app like Rate.

What is the root cause of that problem?

The filterYearList function in the YearPickerPage class does not filter out spaces from the input text, resulting in spaces being allowed in the year search field.

What changes do you think we should make in order to solve the problem?

Modify the filterYearList function in the YearPickerPage class to remove spaces from the input text before filtering the yearOptions list. This can be achieved using the replace method with a regular expression \s/g to remove all spaces from the input text. The filtered text should then be used for filtering the yearOptions list using the _.filter method. here

Eg.

filterYearList(text) {
    // Remove spaces from the input text
    const filteredText = text.replace(/\s/g, '');
    this.setState({
        inputText: filteredText,
        yearOptions: _.filter(this.yearList, year => year.text.includes(filteredText)),
    });
}

What alternative solutions did you explore? (Optional)

[jliexpensify]

Hi @trjExpensify - I've had to reassign as I'm headed OOO for the next 2 weeks. I've verified that the bug occurs in Chrome and Android so you're good to go!

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Date field allows spaces between the numeric digits, unlike other numeric fields (like Rate)

What is the root cause of that problem?

• The filterYearList function in the YearPickerPage class does not filter out spaces from the input text, resulting in spaces being allowed in the year search field.

What changes do you think we should make in order to solve the problem?

• We are trimming the values when we are filtering the year data only the thing is we are not validating the user-typed number so for that we just need to make sure white space is replaced with the blank which is a simple regex to validate replace(/ /g, '') we are already using in modifyRoomName() , validating the debit card number , emoji utils

• We dont need to add regex \s/g (which is used to remove whitespace from a string (including spaces, tabs and newline characters ) simply because the user never gets a chance to add tabs and newline characters I.e -> when the user press tab it changes focus and we are already limiting the value to 4 characters to the max and number of line is 1 so it doesn't make sense to add regex \s/g

• Since we are filtering displayed value that we can also add to yearOptions as well so need to remove text.trim()

    filterYearList(text) {
+        const filteredText = text.replace(/ /g, '');
        this.setState({
+            inputText: filteredText,
-            yearOptions: _.filter(this.yearList, year => year.text.includes(text.trim())),
+           yearOptions: _.filter(this.yearList, year => year.text.includes(filteredText)),
        });
    }

Note

• IMO we should not replace text with blank space ([\D]/g its simply a bad UX behavior and also we never used it anywhere else in the app

• We are already limiting the text character to a maximum of 4 so there is no need to add validation here

@s77rt

[gargmegham]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The current implementation allows spaces, and characters in the year text input of YearPickerPage. But it should only allow numeric characters

What is the root cause of that problem?

The keyboard type number-pad is not working as expected, because it should have only allowed numbers by default

What changes do you think we should make in order to solve the problem?

Before modifying the state inside the filterYearList function input text should be formatted just like we're doing in rate input field mentioned in issue description

Example

filterYearList(text) {
        // Remove all non-numeric characters from the input
        const inputYear = text.replace(/[^0-9]/g, '');
        this.setState({
            inputText: inputYear,
            yearOptions: _.filter(this.yearList, year => year.text.includes(inputYear)),
        });
    }

[MelvinBot]

📣 @gargmegham! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[gargmegham]

📣 @gargmegham! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details Your Expensify account email: meghamgarg@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~0170461d5a03bcee8d

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[s77rt]

@hayata-suenaga Please remove the Reviewing label. No one is assigned yet.

[s77rt]

@Prince-Mendiratta Thanks for the proposal. Your RCA is correct and the fix looks good to me :+1:.

:ribbon: :eyes: :ribbon: C+ reviewed

cc @hayata-suenaga

[Prince-Mendiratta]

Thank you for your review, @s77rt!

Additionally, we can add some more constraints such as the maximum number of characters that the user can enter is 4.

What are your thoughts on additional constraints?

[s77rt]

@aman-atg Thanks for the proposal. The RCA is correct but the suggested fix is a duplicate and I think we want to remove everything that is not a number and not just spaces.

[s77rt]

@dhairyasenjaliya Thanks for the proposal. The RCA is correct but it's basically a copy-paste even if you agree with someone's RCA you should at least rephrase or give credit to the original writer. As for your concern about replacing other text, we do that already here.

[dhairyasenjaliya]

Hm oky point noted was simple RCA thank you @s77rt

[s77rt]

@gargmegham Thanks for the proposal. I don't think your RCA is exactly correct, the keyboard type is only for virtual keyboard which is working fine.

[s77rt]

@Prince-Mendiratta

What are your thoughts on additional constraints?

The length is already limited to 4 here.

[s77rt]

@hayata-suenaga before assigning @Prince-Mendiratta do you think this should be handled by @ArekChr as a part of https://github.com/Expensify/App/issues/14322? We had a discussion about this bug but we decided to ignore it at that time, I think mostly because we didn't really consider it as a bug and I was not really convinced about the way it was meant to be handled.

I think we should hire @Prince-Mendiratta here since the solution we were going with is slightly different.

Just stating the above for clarity and transparency. cc @ArekChr .

[hayata-suenaga]

@s77rt thank you for the proposal review.

I think we can go with @Prince-Mendiratta. Assigning @Prince-Mendiratta

[MelvinBot]

📣 @Prince-Mendiratta You have been assigned to this job by @hayata-suenaga! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Prince-Mendiratta]

PR is up for review!

Applied in Upwork.

cc @s77rt @hayata-suenaga @trjExpensify

[MelvinBot]

@trjExpensify, @s77rt, @Prince-Mendiratta, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

Not overdue. PR deployed to staging 19 hours ago.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.2-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/17356

If no regressions arise, payment will be issued on 2023-04-27. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter
• [x] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[trjExpensify]

Hm, where's the checklist for this? Adding it manually..

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@trjExpensify] Determine if we should create a regression test for this bug.
• [ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Prince-Mendiratta]

@trjExpensify I'm not too sure about Melvin's flow but maybe the BZ checklist was not triggered as I was not assigned in the PR?

[trjExpensify]

Oh, maybe. I didn't think that had an impact tbh. Payments check in the meantime. I can see the PR was approved on the 13th, so within the timeframe, the slow down on merge was on our side.

• $1,500 to @Prince-Mendiratta for the fix & #urgency bonus
• $1,500 to @s77rt for C+ & #urgency bonus
• $250 to @priya-zha for the bug report.

Sound about right?

[s77rt]

I don't think bonus applies here, this was merged on 18th.

[trjExpensify]

I don't think bonus applies here, this was merged on 18th.

Yeah, I looked at that, but you were both done and approved on the 13th. After the weekend, the hold up was on us internally to action on the merge. Do you think I'm missing something?

[s77rt]

• The PR that introduced the bug has been identified: Not exactly a bug. This more like a feature request / improvement. This may have been handled on https://github.com/Expensify/App/issues/14322 but didn't as explained on https://github.com/Expensify/App/issues/17280#issuecomment-1504735586.
• The offending PR has been commented on: I don't think this applies here since it's not a regression. cc @hayata-suenaga
• A discussion in #expensify-bugs has been started: Same ^
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Open App
2. Go to Settings > Profile > Personal Details > Date of birth
3. Click on the year
4. Verify you are redirected to the Year picker page
5. Type in any non digit character e.g. whitespaces, letters or special characters
6. Verify none of the typed characters are entered in the search box
7. Type in any digit
8. Verify the typed digits are entered in the search box, upto 4 digits

[s77rt]

@trjExpensify, @hayata-suenaga did request a change on April 13th so technically it was not 100% ready for merge on April 13th.

[Prince-Mendiratta]

To help with the timeline analysis,

🐛 Issue created at: Tue, 11 Apr 2023 18:20:13 GMT 🧯 Help Wanted at: Wed, 12 Apr 2023 03:31:33 GMT 🕵🏻 Contributor assigned at: Wed, 12 Apr 2023 17:31:52 GMT 🛸 PR created at: Wed, 12 Apr 2023 18:43:00 GMT ✅ C+ Approved at: Thu, 13 Apr 2023 09:21:51 GMT ❗ Changes requested by @hayata-suenaga: Thu, 13 Apr 2023 15:26:39 GMT ✅ Requested changes applied at: Thu, 13 Apr 2023 18:52:34 GMT 🎯 PR merged at: Tue, 18 Apr 2023 18:30:19 GMT ⌛ Business Days Elapsed between assignment and PR merge: 5

I'll leave the decision up to you guys!

[trjExpensify]

Yeah, because the changes were still applied within the timeframe and no further changes were required after that, the delay from the 13th onwards were on us I think.

[trjExpensify]

Okay offers have been sent.

[trjExpensify]

Settled up!

@s77rt re: the regression test, there's this one here in TestRail. Instead of a totally separate one wouldn't we just add to that test script for ease?

Maybe..

8. ....
9. Type in any non digit character e.g. whitespaces, letters or special characters
10. Verify you see an error
11. ....

[s77rt]

@tjferriss I feel the test won't fit well with those since this one requires attention to the year selection page which none of existing tests mention.

Actually I think we can skip the regression test for this one just to be consist with the types of regression tests on that page.

[hayata-suenaga]

The offending PR has been commented on: I don't think this applies here since it's not a regression. cc @hayata-suenaga

I agree

[hayata-suenaga]

this is on hold for payment

[trjExpensify]

this is on hold for payment

Payment has been made, we're just looking at this regression test.

I feel the test won't fit well with those since this one requires attention to the year selection page which none of existing tests mention.

Ah, wait. The test script has changed since I linked it - likely because it has been recently developed. Okay, so there's this standalone test for DOB now.

So what we could do is insert these two lines before 5 & 6 perhaps?

5. Type in any non digit character e.g. whitespaces, letters or special characters
6. Verify you see an error

[s77rt]

@trjExpensify Yes that looks good to me, but step 6 is to verify that the non of the typed characters got inserted (there is no error message)

[trjExpensify]

Oh, so if it's not possible at all to enter them at all (i.e it's a numerical keyboard) then what are we testing for? 😕

[trjExpensify]

Sorry, I interpreted this suggested script as being that these characters are allowed for the input but receive an error on blur (a bit like forms). I just checked this and it's a numerical keyboard, so I think we can forgo this addition to the script - it's extraneous.

Going to close this out!

[s77rt]

@trjExpensify You can still enter any char in Web / Desktop. But I think we can still skip this test.