Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

A jittery motion is observed on opening of "Reimburse expenses" section repeatedly. #17303

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the Settings menu.
  2. Click on " Workspaces."
  3. Open any Workspace.
  4. Select "Reimburse expenses."
  5. Observe right scroll bar.
  6. Go back to Workspace.
  7. Select "Send invoices."
  8. Observe right scroll bar
  9. Notice that the scroll bar on right side is not smooth. A jittery motion can be seen clearly.

Expected Result

Scroll bar should not shiver on opening repeatedly like "Send invoices".

Actual Result

Scroll bar shivers when "Reimburse expenses" section is opened repeatedly.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduciton If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231288448-f4dfa483-7763-48d0-9d26-b75c745f15a3.mp4

Expensify/Expensify Issue URL: Issue reported by: @usmantariq96 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681210964657689

View all open jobs on GitHub

MelvinBot commented 1 year ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

kadiealexander commented 1 year ago

I don't think this is a bug. This is happening because the Reimburse expenses tab takes a moment to populate the last section, which means that the tab is not scrollable until the last tab populates and the scroll bar appears when the final tab does. It's not jittering.

https://user-images.githubusercontent.com/59587260/231384555-2edaa16e-e4a0-46fa-a6d8-2c18cdcf2473.mp4

allroundexperts commented 1 year ago

I don't think this is a bug. This is happening because the Reimburse expenses tab takes a moment to populate the last section, which means that the tab is not scrollable until the last tab populates and the scroll bar appears when the final tab does. It's not jittering.

@kadiealexander The width of the RHN should remain the same even if its loading content. Its width seems to change when the content is loaded. I think this is a bug. I've taken the screenshots from the video you posted above. Please check them and let me know what you think.

Loading State

Screenshot 2023-04-14 at 7 41 27 PM

After Loading State

Screenshot 2023-04-14 at 7 41 43 PM

Note that the width of the menu decreases once the content loads.

kadiealexander commented 1 year ago

The width of the menu doesn't decrease, but the scroll bar takes up a portion of the menu when visible. This is the same for all right-have nav menus.

Main setting menu, scrollbar vs no scrollbar:

image

Reimburse expenses, scrollbar vs no scrollbar:

image

Video:

https://user-images.githubusercontent.com/59587260/232357784-38d18a5a-09e2-4350-81cb-3e0f03159d4a.mp4

This is not a bug, this is how the scrollbar behaves across the whole platform.