[HOLD for payment 2023-06-30] [Hold 18658][$1000] When only link is added in header text, app adds extra padding above link which has cursor as pointer

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any link as header text. eg: # google.com
4. Hover slightly over the link and observe the pointer is cursor i.e. pointer is clickable.
5. Click in that area and observe that it does nothing

Expected Result:

App should only keep the link area clickable like does for normal text message and header message with both text and link

Actual Result:

App keeps area above link clickable but does nothing on click when only link is added in header text

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/232342197-70444093-fc37-4d9a-acc6-b8c19999e4e0.mp4

https://user-images.githubusercontent.com/43996225/232342200-4bb59a97-95eb-477e-b198-b3b3bd51e6c8.mp4

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681575226770749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143b139f54244d059
• Upwork Job ID: 1648636657245667328
• Last Price Increase: 2023-05-10

[flaviadefaria]

I'm OoO for 8 days so re-adding the BUG label, but keeping myself assigned. I'll be back at work on May 30th.

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

@0xmiroslav let's get an update today! 🙇‍♂️

[melvin-bot[bot]]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

I'm heading OOO tomorrow for about a week so adding another BZ member while I'm away to help keep the train moving! 🚂 Thanks @arielgreen!!

[parasharrajat]

Can someone help me with the summary of the root cause and issue that caused the regression? It is tagged on one of the PRs where I am a reviewer. It will help me confirm that. Thanks

[parasharrajat]

This will soon be resolved on https://github.com/Expensify/App/pull/16052. Thankfully, there is no proposal selected yet.

[0xmiros]

@parasharrajat how is tooltip refactor related to this issue? you meant https://github.com/Expensify/App/pull/19545?

[parasharrajat]

In that PR we are removing the container styles, thus display:inline will also be removed. Yeah, you might be correct that change might not solve this issue. We are also removing the wrapper Views applied by the Tooltips.

Let me test this issue on that PR.

[amyevans]

Thanks @parasharrajat!

[parasharrajat]

Ok, I checked and yes that PR does not solve this issue.

[Nikhil-Vats]

@amyevans @0xmiroslav I have tested this issue in #19545 and I think it is fixed. I tested with different types of links - in headers, in headers within quote, etc. and there is no extra padding.

https://github.com/Expensify/App/assets/31413407/157e5cba-d0ab-490a-b456-2ee58029af2f

[amyevans]

Ok, I checked and yes that PR does not solve this issue.

@parasharrajat can you clarify if you meant to say "does solve this issue"?

Because based on my local testing (and the video from @Nikhil-Vats), the heading padding issue is resolved by the PR.

Heads up also that I'll be OOO tomorrow and Monday, but @0xmiroslav (and trio of BZ members 😄) let's not let that prevent us from driving this issue forward in the interim. Thanks!

[arielgreen]

Reassigning, OOO tomorrow/Monday.

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[flaviadefaria]

I'm back from OoO so will take this back now.

[flaviadefaria]

Also @0xmiroslav @parasharrajat @amyevans what's the latest here? This issue has been open now for over a month what can we do to unblock it?

[parasharrajat]

@amyevans I meant to say that https://github.com/Expensify/App/pull/16052 does not solve this issue.

it might be solved with https://github.com/Expensify/App/pull/19545. @0xmiroslav can tell better.

[amyevans]

Okay thanks @parasharrajat!

I'm going to remove the Reviewing label here until we have fully evaluated whether https://github.com/Expensify/App/pull/19545 solves for this issue. @0xmiroslav please prioritize this today, or if you can't let us know and we can find a volunteer in the C+ room. Thanks!

[0xmiros]

I will test https://github.com/Expensify/App/pull/19545 branch today if it fixes this issue

[0xmiros]

I confirmed this is not reproducible on that branch. Let's still put this on hold for https://github.com/Expensify/App/pull/19545 (rather than close) for the edge case that PR might be reverted due to regression, though I believe it won't happen.

[amyevans]

Sounds good 👍

[dhanashree-sawant]

Hi @amyevans, @0xmiroslav, in case it is solved by 19545, will it be eligible for reporting bonus?

[amyevans]

@dhanashree-sawant Yes I think it'd still be eligible for reporting bonus. This issue was also reported prior to #19545 fwiw.

[melvin-bot[bot]]

@amyevans, @flaviadefaria, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[amyevans]

19545 is merged but not yet on staging, still holding

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[youssef-lr]

@Nikhil-Vats FYI the fix for this issue has been reverted.

[Nikhil-Vats]

Fix for the regression proposed here.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.27-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/19545

If no regressions arise, payment will be issued on 2023-06-21. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
• [ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[0xmiros]

@Nikhil-Vats FYI the fix for this issue has been reverted.

check this, Melvin

[amyevans]

Fixed up the title/labels manually

[flaviadefaria]

So just to confirm, we're still waiting to see if the reverted PR fixes this issue before we make a decision, right?

[amyevans]

So just to confirm, we're still waiting to see if the reverted PR fixes this issue before we make a decision, right?

After the revert, a new PR was put up (https://github.com/Expensify/App/pull/20996), so yes we're waiting to see if this PR fixes the issue.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.31-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/20996

If no regressions arise, payment will be issued on 2023-06-30. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
• [ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

Waiting for @0xmiroslav to fill out the checklist above so that I can process payment.

[flaviadefaria]

Friendly bump @0xmiroslav!

[flaviadefaria]

Bumped @0xmiroslav in Slack as I think he has missed my previous bumps here.

[0xmiros]

Shall I or @mollfpr fill checklist? As PR was reviewed by @mollfpr

[flaviadefaria]

Ok so it looks like we're issuing the following payments:

@dhanashree-sawant - $250 @0xmiroslav - $1000 - $500 from regression = $500

[flaviadefaria]

Offers sent!

[flaviadefaria]

Paid!