search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for @0xmiroslav payment] Make Profile > Personal Details > Address true push-to-page fields. #17548

Closed JmillsExpensify closed 1 year ago

JmillsExpensify commented 1 year ago

@Beamanator @cristipaval I was in a thread with @shawnborton and he noticed that both our State and Country fields are not true push-to-page inputs. Mind helping us understand why that's the case? Ideally if we're going to allow selection of a list, we'd follow a true push-to-page pattern where the row/input has a right caret, upon which tapping that takes you to the full list on a separate page. Right? Adding a New Feature label on this one given that it's not technically a bug.

Screenshot 2023-04-17 at 17 50 04

In addition to the above, let's make sure we have 20px below each input grouping (could be just an input, or input + hint text), as @shawnborton asked here.

JmillsExpensify commented 1 year ago

Offer extended to @s77rt. @0xmiroslav I think there's still some uncertainty how you're being paid out. Please let me know how you'd like to proceed.

JmillsExpensify commented 1 year ago

@s77rt paid for this job. Going to add a hold for @0xmiroslav.

mountiny commented 1 year ago

making it monthly for the payment to miroslav

JmillsExpensify commented 1 year ago

@0xmiroslav Can we issue payment on this one yet?

0xmiros commented 1 year ago

Not yet

JmillsExpensify commented 1 year ago

I'm going to close this because I have an unsustainable amount of GH issue assigned. Please keep track on this one your side and let us know when you are ready to receive payment. Thanks!