[HOLD for payment 2023-06-30] [$1000] Jittery transition of tooltip when the inner content changes

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any chat > Click on chat header
2. Click on the clipboard icon at the details page
3. Keep the cursor at clipboard and wait for the tooltip to change again to "Copy to clipboard"

Expected Result:

The tooltip transition is Jittery when the tooltip text changes.

Actual Result:

You shouldn't see any shaking/jitter in the transition.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/232654771-8182efd6-d634-40e9-b1b8-fc5f8a4d8efd.mp4

https://user-images.githubusercontent.com/43996225/232654786-3a83e4f3-19b9-4403-8df5-a8f864b32925.mov

Expensify/Expensify Issue URL: Issue reported by: @dukenv0307 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681726366513289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7a7c818708f281d
• Upwork Job ID: 1651051677043404800
• Last Price Increase: 2023-04-26

[isagoico]

• ts to Copy to Clipboard after few seconds on Safari
• Long Tooltip the arrows are aligned with the Bu

Hi there, these are all visual checks that are indirectly tested with the proposed steps here. We ask the testers to check for any visual issues when executing the steps without being explicitly told so in the step instructions. For context, we're avoiding having a extremely granular regression that checks every visual behavior of a feature and focusing mostly on functional behavior. Going to add Copied resets to Copy to Clipboard after few seconds as this fits with the tests we want to cover.

[isagoico]

@michaelhaxhiu we can add these 2 steps (7 & 8) to cover the button reset:

User detail page

1. Click on the header of the conversation
2. Verify there's a copy option next to the users email
3. Hover over the copy button
4. Verify a tooltip is displayed with the action ("Copy to Clipboard")
5. Click on the copy button
6. Verify the tooltip displays "Copied"
7. Web/Desktop - Wait a few seconds while hovering over the tooltip
8. Web/Desktop - Verify the tooltip changes back to "Copy" after a few seconds

wdyt?

[dukenv0307]

Hi @michaelhaxhiu Could you help to check this comment Am I eligible for reporting bug here reporting bonus for reporting the bug here

[mananjadhav]

I'll be testing this PR today.

[michaelhaxhiu]

@amyevans noted! I missed that originally and the Awaiting payment label threw me.

[michaelhaxhiu]

@dukenv0307 yes i updated my prior comment to be more accurate.

We'll get this paid when the fix(es) are deployed to production & 7 days elapse without regressions.

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @bernhardoj got assigned: 2023-04-28 14:40:38 Z
• when the PR got merged: 2023-06-21 13:12:05 UTC
• days elapsed: 38

On to the next one 🚀

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.31-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/20340

If no regressions arise, payment will be issued on 2023-06-30. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter
• [ ] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [x] [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [x] [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@mananjadhav] Determine if we should create a regression test for this bug.
• [x] [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/296910

[anmurali]

Paid @mananjadhav on New Dot

[melvin-bot[bot]]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[michaelhaxhiu]

@dukenv0307 can you share your upwork profile, or apply to the upword job directly? https://www.upwork.com/jobs/~0139362b8c0838a40f

[michaelhaxhiu]

I invite @bernhardoj to the job just now.

[dukenv0307]

@michaelhaxhiu My Upwork profile: https://www.upwork.com/freelancers/~01f5cbe690701118a2. I've also applied to the job, thank you!

[mananjadhav]

Closest I could find the PR was https://github.com/Expensify/App/pull/8494 but I am not confident, hence I am not posting it on the PR. This is because I am not sure if we had Copy to Clipboard and we also made multiple changes in the component while fixing https://github.com/Expensify/App/issues/13146

I don't think this specific issue required a regression, but I think it makes sense to have a regression suite for Tooltip atleast? I have mentioned some cases here and we've got two additional cases here and here. @michaelhaxhiu Could you help with this? I am not sure if adding regression suite would be considered and what would be the steps here?

[michaelhaxhiu]

Re: the regression, I already made the regression test and linked it (yesterday). All set there.

[mananjadhav]

Thanks @michaelhaxhiu. Is everyone paid out here? If yes, then we are good to close here?

[michaelhaxhiu]

@dukenv0307 lmk when you accept the job offer. Just need to pay you & this can be closed.

[dukenv0307]

@michaelhaxhiu I accepted, thank you!

[melvin-bot[bot]]

@mananjadhav, @amyevans, @michaelhaxhiu, @bernhardoj Eep! 4 days overdue now. Issues have feelings too...

[mananjadhav]

@michaelhaxhiu are we done with the payout? Can we close this one out?

[michaelhaxhiu]

paid now