search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.59k stars 2.92k forks source link

[HOLD for payment 2023-05-16] [$1000] DEV: Mobile - Right icon of menu item is misaligned #17601

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Login any account
  2. Go to Settings

Expected Result:

right icon of menu item is aligned with close icon

Actual Result:

too much space between right icon and right edge

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: DEV Reproducible in staging?: Need reproduction Reproducible in production?: Need reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation padding

Expensify/Expensify Issue URL: Issue reported by: @situchan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681830317121849

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aade89d36aab6c3b
  • Upwork Job ID: 1648379900812378112
  • Last Price Increase: 2023-04-18
MelvinBot commented 1 year ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
MelvinBot commented 1 year ago

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

zanyrenney commented 1 year ago

Its 18.05, i shouldn't have been assigned an hourly issue at the end of the work day GMT. I need to reassign this, sorry! https://expensify.slack.com/archives/C01SKUP7QR0/p1681837710580459

MelvinBot commented 1 year ago

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot commented 1 year ago

Bug0 Triage Checklist (Main S/O)

situchan commented 1 year ago

https://github.com/Expensify/App/pull/17321 caused regression. This is easily reproducible on large mobile devices like iPhone 14 Pro Max

MelvinBot commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01aade89d36aab6c3b

MelvinBot commented 1 year ago

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

MelvinBot commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

MelvinBot commented 1 year ago

Current assignee @hayata-suenaga is eligible for the External assigner, not assigning anyone new.

situchan commented 1 year ago

I don't think this needs open for proposals. Maybe @allroundexperts can handle this as author of offending PR.

allroundexperts commented 1 year ago

I don't think this needs open for proposals. Maybe @allroundexperts can handle this as author of offending PR.

@situchan I'm available to fix this but I'm not sure if I should wait for approval from someone.

Jeet989 commented 1 year ago

This issue can be resolved by removing this styles.

https://github.com/Expensify/App/blob/b2c28acea914a54dc6585485529fd01019a8bfcf/src/components/MenuItem.js#L98

And the expected output can be achieved. Here is the Screenshot for that:

WhatsApp Image 2023-04-18 at 1 24 13 PM

MelvinBot commented 1 year ago

📣 @Jeet989! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
allroundexperts commented 1 year ago

For more context, what caused this issue can be seen in this comment. We thought that adding a maxWidth on the container itself was more cleaner rather than adding it on the descriptiveText. But, doing that caused this regression.

Jeet989 commented 1 year ago

Contributor details Your Expensify account email: jeet3766@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~013e771b85d2fc24e8

MelvinBot commented 1 year ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

hayata-suenaga commented 1 year ago

@allroundexperts can you actually handle this issue and create a PR as your PR might have caused this?

MelvinBot commented 1 year ago

📣 @allroundexperts You have been assigned to this job by @hayata-suenaga! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

hayata-suenaga commented 1 year ago

I don't think this is a deploy blocker. removing the blocker label.

allroundexperts commented 1 year ago

@hayata-suenaga Sure. Creating a fix PR right now.

allroundexperts commented 1 year ago

@hayata-suenaga PR created https://github.com/Expensify/App/pull/17640

s77rt commented 1 year ago

@hayata-suenaga Please assign @sobitneupane since this issue is a regression that happened before the end of the regression period.

MelvinBot commented 1 year ago

📣 @sobitneupane You have been assigned to this job by @hayata-suenaga! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

MelvinBot commented 1 year ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

situchan commented 1 year ago

This now became deploy blocker since offending PR deployed to staging

hayata-suenaga commented 1 year ago

This is a regression but it only involves a minor UI misalignment this is not a deploy blocker

MelvinBot commented 1 year ago

@s77rt, @NicMendonca, @sobitneupane, @allroundexperts, @hayata-suenaga Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

s77rt commented 1 year ago

Sorry forgot to unassign myself earlier.

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

NicMendonca commented 1 year ago

bump @sobitneupane https://github.com/Expensify/App/issues/17601#issuecomment-1539340397

NicMendonca commented 1 year ago

Don't forget to apply to the job: https://www.upwork.com/jobs/~01aade89d36aab6c3b

sobitneupane commented 1 year ago

@NicMendonca It is a regression from this PR related to https://github.com/Expensify/App/issues/16521.

So, I guess checklist and payment stuff will be handled in https://github.com/Expensify/App/issues/16521.

Only payment here should be to the issue reporter.

situchan commented 1 year ago

Don't forget to apply to the job: https://www.upwork.com/jobs/~01aade89d36aab6c3b

@NicMendonca shall I apply here for reporting bonus?

NicMendonca commented 1 year ago

@situchan yes, please! Thank you!

NicMendonca commented 1 year ago

@situchan accept the offer when you can please!

NicMendonca commented 1 year ago

@situchan paid!