[HOLD for payment 2023-06-09] [$1000] Composer input is empty when editing the word `[block]` in chat

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Log into staging.new.expensify.com
Click into any chat
Type the word [block] and send it as a message
Click the pencil icon to edit the comment
Notice the composer input is empty

Expected Result:

The composer input should be text [block] in editing mode

Actual Result:

The composer input is empty

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/233535465-20d83e6a-1279-4ddd-8a77-aaab3ebd04b6.mp4

https://user-images.githubusercontent.com/43996225/233535477-bc59a995-b10c-4ad7-9b52-88df4ffadbcb.mov

Expensify/Expensify Issue URL: Issue reported by: @eh2077 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681920140787049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0c0a4619ff68e29
Upwork Job ID: 1650565300774252544
Last Price Increase: 2023-04-24

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 1 year ago

@cead22 @rushatgabhane @stephanieelliott @maddylewis this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

maddylewis commented 1 year ago

@cead22 @rushatgabhane - can you provide an update on which proposal we're moving forward with? thx!

rushatgabhane commented 1 year ago

@maddylewis well, I'm still leaning towards @tienifr's proposal

Curious for @cead22's feedback tho. Worth the risk?

maddylewis commented 1 year ago

i trust you, @rushatgabhane! @cead22 - if you're around today/tomorrow, let us know what you think!

melvin-bot[bot] commented 1 year ago

@cead22 @rushatgabhane @maddylewis this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] commented 1 year ago

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

maddylewis commented 1 year ago

@rushatgabhane - to keep the momentum, lets go with the proposal you suggested. if we need to switch gears, @cead22 will let us know once he's back from OOO.

thanks!

cead22 commented 1 year ago

@maddylewis well, I'm still leaning towards @tienifr's proposal

Curious for @cead22's feedback tho. Worth the risk?

Yes, let's give it a go!

melvin-bot[bot] commented 1 year ago

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

📣 @tienifr You have been assigned to this job by @cead22! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 1 year ago

Current assignee @cead22 is eligible for the External assigner, not assigning anyone new.

tienifr commented 1 year ago

The expensify-common PR is ready for review: https://github.com/Expensify/expensify-common/pull/541. @maddylewis Please help assign the C+ there. Thanks in advance! cc @cead22 @rushatgabhane

cead22 commented 1 year ago

I reviewed it, but I couldn't assign @rushatgabhane. The PR looks good, but I left a comment there saying we need to do a lot more testing, and suggested adding all those tests to the App PR that will update the version of expensify-common. What do you think?

cead22 commented 1 year ago

The PR on expensify-common is merged. The PR in App should be ready soon, it just needs to be re-tested on the latest commit of expensify-common

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.22-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/19511

If no regressions arise, payment will be issued on 2023-06-09. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[x] External issue reporter
[x] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[x] [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x] [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[x] [@rushatgabhane] Determine if we should create a regression test for this bug.
[x] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

maddylewis commented 1 year ago

moving to daily since payment is coming up!

maddylewis commented 1 year ago

Payments

[x] Reporting bonus - eh2077 ($250) - offer sent
[x] Contributor - @tienifr ($1000) - offer sent
[ ] C+ - @rushatgabhane ($1000) - offer sent

maddylewis commented 1 year ago

@rushatgabhane - will you go through this checklist when you have a chance - thanks! https://github.com/Expensify/App/issues/17776#issuecomment-1573404748

maddylewis commented 1 year ago

apologies! sending offers now!

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

maddylewis commented 1 year ago

hiya @flaviadefaria - all that's needed here is:

[x] process payment for @tienifr (offer here - https://www.upwork.com/nx/wm/offer/25014584) - completed on June 14
[ ] process payment for @rushatgabhane (offer here - https://www.upwork.com/nx/wm/offer/25014435)
[ ] bump @rushatgabhane to complete the BZ checklist if need be
[ ] create a GH for a regression test update if applicable

I'll be back on June 20 - thanks!

flaviadefaria commented 1 year ago

@rushatgabhane can you please complete the list here so that I can issue your payment? Thanks!

flaviadefaria commented 1 year ago

Still waiting for @rushatgabhane to fill the tasks I mentioned above so that I can issue payment and close this.

rushatgabhane commented 1 year ago

Hi, could we please change this to a weekly? I won't be able to complete the checklist until Friday 😅

maddylewis commented 1 year ago

all good! i will keep at daily just for my own organization. but, no worries if you don't complete the checklist until Friday 👍

flaviadefaria commented 1 year ago

@maddylewis since you're back I'll unassign myself from this issue.

maddylewis commented 1 year ago

@rushatgabhane - let us know know if you think a regression test update is required for this one - thanks!

rushatgabhane commented 1 year ago

@maddylewis no regression test required. This can never happen again

rushatgabhane commented 1 year ago

Checklist

The PR that introduced the bug has been identified. Link to the PR: Not a bug but a known drawback of the implementation.
@rushatgabhane The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: not a bug.
@rushatgabhane A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

4.Determine if we should create a regression test for this bug. NO

maddylewis commented 1 year ago

thanks @rushatgabhane - just waiting for you to accept the offer I sent you and then i will close this out 👍

rushatgabhane commented 1 year ago

Hey @maddylewis , Anu is setting up global payments through expensify for us. It might take another week or two, and we'll have the clarity of next steps for payment.

Until then, we could make this a weekly issue? I hope this is okay :)

https://expensify.slack.com/archives/C02NK2DQWUX/p1687451792686509?thread_ts=1686871517.189609&cid=C02NK2DQWUX

maddylewis commented 1 year ago

of course! thank you for letting me know :)

moving to weekly.

rushatgabhane commented 1 year ago

Jul 5 is when I'll get the confirmation if manual requests worked as expected

rushatgabhane commented 1 year ago

Hi @maddylewis, I made a manual request on new dot - https://staging.new.expensify.com/r/5901048936724743

rushatgabhane commented 1 year ago

This is paid by Anu, and can be closed.

Expensify / App