Closed kavimuru closed 1 year ago
Triggered auto assignment to @arielgreen (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)Inconsistent margin above the payment methods title in payment methods page.
The root cause is that we're using margin incorrectly here.
We need to remove the margin top that is defined here. I think this is not needed even when the canUseWallet
is enabled. This is because it adds it own set of margin. However, if extra margin is needed, we can remove the margin here conditionally if canUseWallet
is not enabled.
We also need to add styles.mt3
here.
We also need to add a styles.mb3
around a wrapping View
here.
None
Job added to Upwork: https://www.upwork.com/jobs/~0153926c14e0c2607c
Good to go external
Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External
)
Triggered auto assignment to @yuwenmemon (External
), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Inconsistent margin above 'Payment methods' title
The extra margin space come from this line https://github.com/Expensify/App/blob/17c1dd8561f217ed3117937a901425d298196873/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L375
Where we add margin-top to the Payment methods
title
This style is added via this commit. It seems we want to add it to make spaces with Transfer button in this LOC
styles.mt6
out of Payment title stylesKYCWall
insides a View and adding style.mb6 for it. So when it's rendered, it will add spaces with the bellow component. Otherwise, do nothing.
<View style={[styles.mb6]}>
<KYCWall>
....
</KYCWall>
</View>
Results:
i don't see the inconsistency !!!! im blind
can someone attach screenshots using the inspect elements? of how it looks before and after?
@rushatgabhane
BEFORE
AFTER
Preference page
Payment page Before
After
Ah... Apologies @rushatgabhane. I forgot to inspect the elements. @hoangzinh Thanks for covering up!
@yuwenmemon let's go with @allroundexperts' proposal because they were first
C+ reviewed 🎀 👀 🎀
@rushatgabhane @hoangzinh is correct about my proposal. I missed a case. I've updated my proposal with that new condition. I think we should use mb3
instead of mt6
because it will be consistent with the margin of the top title. This is also included in my proposal.
📣 @allroundexperts You have been assigned to this job by @yuwenmemon! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@yuwenmemon @rushatgabhane PR created.
PR merged yesterday
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-16. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@allroundexperts @DinalJivani @rushatgabhane offers sent in Upwork
Hi @arielgreen, I applied using account - https://www.upwork.com/freelancers/~01212e8255b02ae924 Could you please hire me there, thanks!
All context here - https://expensify.slack.com/archives/C02NK2DQWUX/p1683614947522329
@rushatgabhane can you please re-link the context? That link isn't working for me.
@arielgreen maybe this works - https://expensify.slack.com/archives/C02NK2DQWUX/p1683639845797519?thread_ts=1683614947.522329&cid=C02NK2DQWUX
@rushatgabhane yes, that link works. Thank you. Offer sent.
Can you please also complete the checklist here?
Calculating payments:
2 business days = 50% bonus
$250 to @DinalJivani - paid $1000 + 50% = $1500 to @allroundexperts - paid $1000 + 50% = $1500 to @rushatgabhane - offer sent, payment pending acceptance
@rushatgabhane bump on the checklist pleas
awaiting checklist
Bumped Rushat in Slack here.
The PR that introduced the bug has been identified. Link to the PR: This is the closest PR I could find, but it's 1 year old and it's a 2px visual improvement with other pages. Let's do nothing.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: same as above
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: don't think we should because it's a tiny UX polish
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
Sorry for the delay @arielgreen, completed the checklist!
Thank you! All payments issued. This is complete.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Results:
There should be consistent margin above 'Payment methods' title
Actual Results:
Margin is inconsistent above 'Payment methods' title compared to other screens
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/233853535-c7a25571-ed87-4fcb-b555-56965b0848f7.mov
https://user-images.githubusercontent.com/43996225/233853541-2dd76f6f-203d-42e1-9e79-0ae526b54960.mp4
Expensify/Expensify Issue URL: Issue reported by: @DinalJivani Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682204992873729
View all open jobs on GitHub
Upwork Automation - Do Not Edit