search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

Implement Date dividers within chats to distinguish `Today`, `Yesterday` and other dates. #18101

Closed johnmlee101 closed 4 months ago

johnmlee101 commented 1 year ago

Feature Request: Have visible indicators when chats change days, similar to how Slack separates individual days with a bar Problem: When reading chat history, I had a hard time finding out where a discussion started a few days ago, and it required a bit of scanning each chat to see when that day occured. Solution: Add an indicator between each day of the week that changes between messages, giving indication when that message was sent in an easy way.

Slack

image

Whatsapp

image

Original report: https://expensify.slack.com/archives/C01GTK53T8Q/p1682528022290149

cc @puneetlath @flodnv

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efa7bb6bd1169217
  • Upwork Job ID: 1663961128511111168
  • Last Price Increase: 2023-05-31
dubielzyk-expensify commented 5 months ago

Maybe we would need to follow Slack's lead there and not use this style within threads, and only use it for rooms/DMs?

Same. Hadn't considered that either, but I think your suggestion works well here @shawnborton .

I kinda feel like we should get this one done unless it's a huge lift. It's good quality of life and I worry that if we punt it, it'll be forgotten about. But I don't feel super strongly 😄

puneetlath commented 5 months ago

Ok sounds good. @MrRefactor what do you think it would take for you to get the v1 done?

MrRefactor commented 5 months ago

Ok sounds good. @MrRefactor what do you think it would take for you to get the v1 done?

Hey, right now Im fully occupied with react-native upgrade. As I finish it, I will work on v1.

roryabraham commented 5 months ago

thanks @MrRefactor, I think that's correct prioritization.

MrMuzyk commented 5 months ago

I am Michał from Callstack - expert contributor group. I've been asked to take over this issue since @MrRefactor is busy with RN upgrade :)

puneetlath commented 4 months ago

As discussed in the PR, we're going to set this aside for now and focus on other things as the implementation has been more complicated than expected and there are a lot of edge-cases to consider.