Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[$1000] [HOLD for payment 2023-05-16] [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18194

Closed melvin-bot[bot] closed 1 year ago

melvin-bot[bot] commented 1 year ago

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 880/1000
Why? Mature exploit, Recently disclosed, Has a fix available, CVSS 7.6
Integer Overflow or Wraparound
SNYK-JS-ELECTRON-5462056
No Mature

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

πŸ›  Adjust project settings

πŸ“š Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

πŸ¦‰ Learn about vulnerability in an interactive lesson of Snyk Learn.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e6c354c4810571c
  • Upwork Job ID: 1652318066339057664
  • Last Price Increase: 2023-05-19
MelvinBot commented 1 year ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
MelvinBot commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~013e6c354c4810571c

MelvinBot commented 1 year ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

@aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

aimane-chnaif commented 1 year ago

@stitesExpensify can you please add BZ member for me?

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot[bot] commented 1 year ago

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

thienlnam commented 1 year ago

@tjferriss This issue is ready for payment - internal review to @aimane-chnaif

melvin-bot[bot] commented 1 year ago

@tjferriss, @thienlnam, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

thienlnam commented 1 year ago

Bump when you get the chance @tjferriss

tjferriss commented 1 year ago

@aimane-chnaif the offer is pending your acceptance: https://www.upwork.com/jobs/~0168b695076da79b8d.

melvin-bot[bot] commented 1 year ago

@tjferriss, @thienlnam, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

tjferriss commented 1 year ago

@aimane-chnaif has been paid.