[HOLD for payment 2024-02-20] [$1000] [Polish] Add limit on length of task names, room names, etc.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Go to FAB -> Assign task
4. Start typing the title and note that there is no symbol limit

Expected Result:

After discussion in Slack, we want to make the following field limit updates:

Titles (100 characters):

• Workspace name
• Task name
• Room name

Supporting messages (500 characters):

• Request description
• Room welcome message
• Task description

Actual Result:

There is no limit on the length of the title. Same behavior for Description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/05b9957a-b07e-4625-9e73-3b720dea6b93

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a42c5fcacc50150
• Upwork Job ID: 1686014963280871424
• Last Price Increase: 2023-07-31
• Automatic offers:
• dhairyasenjaliya | Contributor | 26010517

[dhairyasenjaliya]

@youssef-lr Also for WorkspaceName and RoomName we need to set the character limit to 100 as well currently both have 80 from the backend so this required backend changes as well

[dhairyasenjaliya]

@youssef-lr @mananjadhav I have created a draft PR but do we hold this issue until backend limit fix for WorkspaceName and RoomName ?

[mananjadhav]

@dhairyasenjaliya I think you can complete the PR.

@joekaufmanexpensify @youssef-lr Can you folks help with the backend change here?

[joekaufmanexpensify]

Sure! @youssef-lr since the auto-assigner selected you for the proposal review, do you want to handle the backend changes for the field limits too?

[youssef-lr]

Sure thing!

[joekaufmanexpensify]

Awesome, ty!

[joekaufmanexpensify]

Next step here is internal PR!

[mananjadhav]

@dhairyasenjaliya Still waiting for an update on this one.

[dhairyasenjaliya]

Hey @mananjadhav im waiting for backend fix once done will push code

[mananjadhav]

@dhairyasenjaliya As I've mentioned before we can finish the PR on the frontend. It isn't that this is introducing the bug currently? This anyway exists today, that backend has limit but we don't have on the frontend.

I don't see a need to block the App PR. Thanks.

[dhairyasenjaliya]

Hm @mananjadhav if we add limit of 100 then we want able to save it as it will throw invalid name an backend error

[mananjadhav]

and what happens today if we enter the text of length 100?

[dhairyasenjaliya]

On live there is limit of 80 on both backend and front end so we cant add 100

[mananjadhav]

Okay got it. I thought we didn't have the limit on the frontend. Thanks for correcting me. @joekaufmanexpensify can we put this on Hold until we have the backend fix up?

[dhairyasenjaliya]

also @youssef-lr can you check if we have a limit backend for the legal name since we also need to change the first/last legal names to support 50 characters each as per below thread https://expensify.slack.com/archives/C01GTK53T8Q/p1691756214835199?thread_ts=1686863510.616919&cid=C01GTK53T8Q

[joekaufmanexpensify]

@mananjadhav should it be on hold though? We're going to handle the internal PR in this issue too.

[joekaufmanexpensify]

@youssef-lr could you share an ETA for when you expect the internal PR to be up?

[mananjadhav]

Yeah it makes sense to put this on Hold. We could split them into separate PRs, but I don't think it's worth the effort as backend fix should be a small one. @youssef-lr You agree?

[joekaufmanexpensify]

Got it. I'd think the issue would not be on hold though. The frontend PR is held on the backend one. But the backend one is still being managed in this issue too. Could we just put that PR on hold?

I'm not sure it makes sense to hold the entire issue, as part of it can be worked on now.

[mananjadhav]

Okay sure I thought we create separate issues for backend. Thanks for correcting. Then it makes sense to put the PR on Hold. cc - @dhairyasenjaliya

[dhairyasenjaliya]

yup let's hold until the backend fix then I will adjust frontEnd PR here

[joekaufmanexpensify]

Chatted with @youssef-lr and he confirmed he's been resolving some issues with his dev environment, and PR will be up later today/tomorrow.

[melvin-bot[bot]]

@mananjadhav, @youssef-lr, @dhairyasenjaliya, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@mananjadhav, @youssef-lr, @dhairyasenjaliya, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

@youssef-lr could you share an ETA to the issue of when the internal PR will be up here?

[daordonez11]

Hey guys coming from https://github.com/Expensify/App/issues/25494, please include in the polish the Description and the merchant of the request. As per discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1692723237220349

cc @dhairyasenjaliya @mananjadhav @joekaufmanexpensify @mountiny

[joekaufmanexpensify]

@mananjadhav bumped the discussion here.

[joekaufmanexpensify]

Latest ETA for new PR is tomorrow!

[melvin-bot[bot]]

@mananjadhav, @youssef-lr, @dhairyasenjaliya, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

Not overdue.

[Santhosh-Sellavel]

We closed https://github.com/Expensify/App/issues/26123 in favor of this issue. It makes sense to handle it here, please take of it.

cc: @mananjadhav

[joekaufmanexpensify]

I bumped the slack discussion again.

[joekaufmanexpensify]

Still held on internal PR.

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

@youssef-lr could you please share an update on this when you have a chance? TY!

[youssef-lr]

@joekaufmanexpensify I'm gonna be able to get to this one after the launch of TU, which is in a couple of days, promise!

[joekaufmanexpensify]

Cool cool, sounds great, ty!

[joekaufmanexpensify]

We'll get to this one later this week, once TU is done

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

We're discussing some error handling considerations here that will impact how we proceed with fixing this issue.

[joekaufmanexpensify]

@youssef-lr could you please confirm once you're ready to proceed with this one?

[youssef-lr]

Working on the PR @joekaufmanexpensify!

[joekaufmanexpensify]

Sounds good. We are discussing adding a character counter as an error message for when the user hits the limit, so they'd be able to see that they have exceeded the limit, but just not be cut off from typing.

That would be something to incorporate into the frontend PR though, right?

[joekaufmanexpensify]

Still pending further discussion on the above point.

[youssef-lr]

That would be something to incorporate into the frontend PR though, right?

Correct, this can be made external.

[joekaufmanexpensify]

Got it, ty!

[joekaufmanexpensify]

Not overdue

[joekaufmanexpensify]

Still ironing out specifics of character counter in the above linked issue.

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Still discussing the character limit error patterns in the above issue.