Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

[HOLD for payment 2023-08-01] [$1000] Emojis inside the reaction buttons appear far down #18751

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Add a reaction
  3. Observe the emojis inside the buttons

Expected Result:

Should be properly aligned in the center

Actual Result:

Appears closer to bottom of the bottom

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.12 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683717352716409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d57ef93d5d7af14e
  • Upwork Job ID: 1656626923913682944
  • Last Price Increase: 2023-06-01
muttmuure commented 1 year ago

Catching up after being OOO, I'll get to this later this week

grgia commented 1 year ago

not overdue, hold for payment

grgia commented 1 year ago

@muttmuure did we finalize payment?

thesahindia commented 1 year ago

@grgia, I haven't requested the payment yet. @muttmuure, can you please confirm the payment on this issue so that I can send a request?

thesahindia commented 1 year ago

Bump @muttmuure

P.S. I have requested $1000. It was an internal PR review.

muttmuure commented 1 year ago

C+ @thesahindia - $1000

JmillsExpensify commented 12 months ago

$1,000 payment approved for @thesahindia based on comment above.