[BONUS PAYOUT ONLY] [$1000] Chat - Redundant "Unexpected error" below the IOU" message after split from 2 devices

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with the same account in the main testing device and a secondary device
2. Disable the internet connection in the main testing device
3. In the secondary device Split a bill with 2 users, this should create a new group and 2 new 1:1 conversations
4. In the main testing device (should be offline) create the SAME split bill with the 2 users
5. Enable the internet connection in the main testing device. The split bill request will be sent and you will get an error in the main device only.
6. Duplicated chats are display in the LHN
7. Open any dup chat with red dot

Expected Result:

PR https://github.com/Expensify/App/pull/18328 says "We shouldn't need to use a generic error message for failure data for the request money / send money flow when creating a New Chat, just like split bill. Otherwise, it will just be redundant with the error sent by the API.". And step 8 of the PR says "Make sure there is no "Unexpected error" below the IOU" (second error message). In scenario above (steps) as chat is invalid then no need for second redundant message under IOU

Actual Result:

Second redundant "unexpected error" message under IOU is displayed. is redundant, he second error message under IOU is redundant as chat is invalid and will be deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [x] Android / Chrome
• [ ] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.13.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/32da3c48-f47e-4552-a251-2ba1afb49000

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136c6f52250bef4a6
• Upwork Job ID: 1658967606698582016
• Last Price Increase: 2023-06-09

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@yuwenmemon @s77rt @jliexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[yuwenmemon]

Sorry playing catch-up. @s77rt that proposal sounds good to me - thanks for working with @therealsujitk on it!

[melvin-bot[bot]]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Current assignee @yuwenmemon is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @therealsujitk You have been assigned to this job by @yuwenmemon! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[therealsujitk]

Just confirming, which approach should I go with - https://github.com/Expensify/App/issues/18839#issuecomment-1578135062?

[yuwenmemon]

Method 3 seems simplest.

[jliexpensify]

Accepted @therealsujitk in Upworks. @s77rt I can't seem to find you - can you apply here? https://www.upwork.com/jobs/~0136c6f52250bef4a6

[therealsujitk]

PR ready for review! :rocket:

[s77rt]

@jliexpensify Applied!

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @therealsujitk got assigned: 2023-05-17 22:48:00 Z
• when the PR got merged: 2023-06-16 17:45:51 UTC
• days elapsed: 22

On to the next one 🚀

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.29-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/20666

If no regressions arise, payment will be issued on 2023-06-28. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@s77rt] Determine if we should create a regression test for this bug.
• [ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/17718
• The offending PR has been commented on: https://github.com/Expensify/App/pull/17718#discussion_r1237758549
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1687386609145189
• Determine if we should create a regression test for this bug: No

[jliexpensify]

@yuwenmemon all good with no regression test?

[yuwenmemon]

Good with me

[jliexpensify]

Paying now!

[therealsujitk]

@jliexpensify @yuwenmemon can a bonus be considered for this one since there were no further changes after the three day period and the only delay was the final review.

• June 12, 5:12 PM (UTC) - Assigned to me
• June 14, 6:51 PM (UTC) - Last commit with no further changes
• June 15, 10:46 AM (UTC) - C+ Reviewed & Approved
• June 15, 5:12 PM (UTC) - 3-day period ended
• June 16, 5:45 PM (UTC) - Approved & Merged

[jliexpensify]

Hmm weird - I was going off this. Is that not correct?

[therealsujitk]

Ah @jliexpensify the reason for that is because I was assigned to this before and then unassigned because we decided to go with a different approach and was assigned again here.

@MelvinBot took the first time I was assigned instead of the last, I've already reported this and was told it'll be fixed.

[jliexpensify]

Ok, going to re-open this. @s77rt you should then also qualify for a $500 bonus too - can you confirm that @therealsujitk 's timeline is correct?

[s77rt]

@jliexpensify Yes, that timeline is correct

[jliexpensify]

Ok @s77rt and @therealsujitk i'll whip up a job to pay the extra $500.

[jliexpensify]

Job - https://www.upwork.com/jobs/~01346cf257dfdd21bd

Invited both!

[s77rt]

@jliexpensify Accepted! Thanks!

[therealsujitk]

@jliexpensify offer accepted, thanks!

[jliexpensify]

Paid and closed job, cheers.