[HOLD for payment 2023-06-05] [$1000] Assign task- 404 error in the console appears when create a task

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login
3. Go to any #announce
4. Create a task

Expected Result:

No errors in console

Actual Result:

404 error in the console appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [X] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: v1.3.15-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/44479856/5fb0d74a-b670-4f99-ae2b-4233ac98669d

Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e1b763b4e7b70a1
• Upwork Job ID: 1658927033624666112
• Last Price Increase: 2023-05-19

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Yep, reproduced!

[conorpendergrast]

@thienlnam I think this should be over to you! I'll label it Internal to get the ball rolling, and will also then assign you too

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012e1b763b4e7b70a1

[conorpendergrast]

If I'm wrong, let me know!

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[thienlnam]

The error is with AuthenticatePusher, not sure why that is showing up. The EditTask command should now be on production and so that error shouldn't be happening anymore

[thienlnam]

I think we can have this external for someone to investigate

[melvin-bot[bot]]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[phuchoang23]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task- 404 error in the console appears when create a task

What is the root cause of that problem?

404 error is come from this API to authorize Pusher when our App need to subscribe to a socket channel.

I suspect the API to create Task (+ report) is not finished yet, then we navigate to taskReport in this line The ReportScreen will load and it triggers this line to subscribe to private socket channels of the report https://github.com/Expensify/App/blob/737862677811acc2b05c68209a56ecd58bee59f3/src/pages/home/report/ReportActionsView.js#L230-L233 => Can cause 404 error because the create Task API is not finished yet (report is not created yet)

Screenshots when navigate to a newly chatReport and a newly taskReport

- **newly taskReport** - **newly chatReport**

What changes do you think we should make in order to solve the problem?

To solve this problem we need to ensure the taskReport is created successfully before subscribe to its private channels

More details: We need to follow this condition: https://github.com/Expensify/App/blob/737862677811acc2b05c68209a56ecd58bee59f3/src/pages/home/report/ReportActionsView.js#L225-L229 That means when build optimisticTaskReport data, we need to add pendingFields.createChat with CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD (and isOptimisticReport: true so it won't trigger OpenReport API when it's not ready).

                pendingFields: {
                    createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                },
                isOptimisticReport: true,

And reset those fields in successData.

We used this trick in some other places:

• IOU chat
• ExpenseChats
• Normal report

Result:

[conorpendergrast]

Unassigning @laurenreidexpensify as I'm already assigned as BugZero

[thesahindia]

I don't think I will be able to review this today. I have too much on my plate at the moment. @conorpendergrast, can you please reassign?

[conorpendergrast]

Asked in Slack

[melvin-bot[bot]]

📣 @aimane-chnaif You have been assigned to this job by @conorpendergrast! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[aimane-chnaif]

@phuchoang23 thanks for the detailed explanation. Proposal looks good to me. So task report is built separately from other reports and below line was easily missed while building optimistic data.

                pendingFields: {
                    createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                },

With this root cause, I found another bug of chat not blurred when created offline.

Before:

https://github.com/Expensify/App/assets/96077027/a6d6a8cc-51bd-4ca3-bfef-328efc7ec959

After:

We can fix them all together.

cc: @thienlnam 🎀 👀 🎀 C+ reviewed

[conorpendergrast]

@thienlnam Over to you to review and confirm the proposal!

[thienlnam]

Awesome - looks great thanks!

[melvin-bot[bot]]

📣 @phuchoang23 You have been assigned to this job by @thienlnam! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[phuchoang23]

PR will ready in a couple hour

[phuchoang23]

@aimane-chnaif @thienlnam PR is ready to review

[phuchoang23]

@aimane-chnaif @thienlnam Btw I have signed the CLA but I'm still getting this error

[conorpendergrast]

Checking that in our internal Slack channel

[aimane-chnaif]

I think it will disappear after re-trigger

[conorpendergrast]

Agreed; re-running the test now

[conorpendergrast]

Yay

[phuchoang23]

look fine now. Thanks for supporting

[phuchoang23]

@aimane-chnaif @thienlnam bump for code review

[conorpendergrast]

PR reviewed and on Staging

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.19-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/19513

If no regressions arise, payment will be issued on 2023-06-05. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter - N/A, Applause
• [x] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[conorpendergrast]

Argh, Upwork isn't letting me hire on the existing job. I'll have to create new ones - tomorrow!

[conorpendergrast]

Looks like this was merged in less than 3 business days, so adding a 50% urgency bonus for C and C+

[conorpendergrast]

@aimane-chnaif contract sent via Upwork @phuchoang23 Can you reply here with your Upwork profile URL please?

[phuchoang23]

@conorpendergrast Here is my Upwork profile https://www.upwork.com/freelancers/~01ae621d43ddc5931a

[phuchoang23]

@conorpendergrast Did you send contract to me via Upwork?

[conorpendergrast]

I will shortly send the contract, yes!

[conorpendergrast]

@aimane-chnaif paid @phuchoang23 contract sent!

[phuchoang23]

@conorpendergrast I accepted the offer

[conorpendergrast]

@phuchoang23 Paid!

[conorpendergrast]

Alright, just the BugZero checklist here

[phuchoang23]

@conorpendergrast Thanks 👍

[conorpendergrast]

@aimane-chnaif Bump on the BugZero checklist here please!

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/17992
• [x] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17992/files#r1224672801
• [x] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [x] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [x] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This bug was introduced while implementing new feature of create task. This should have been caught earlier in PR review if they tested offline case. As offline test is already in PR checklist, no further regression test step is needed.

[conorpendergrast]

Got it. Sounds like we're all done. Closing, thanks all!