[HOLD for payment 2023-07-05] [$2000] iOS - Keyboard does not hide when switching between attachments with focused password input field

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.54k stars 2.88k forks source link

[HOLD for payment 2023-07-05] [$2000] iOS - Keyboard does not hide when switching between attachments with focused password input field #19156

Closed mvtglobally closed 1 year ago

mvtglobally commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the App
Login with any account
Send several attachments including PDF-protected file
Click to preview on PDF-protected file -> Press Enter a password
Switching to another attachment

Expected Result:

Keyboard should be hidden

Actual Result:

Keyboard does not hide

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[X] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.15-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43995119/6f87bbd7-de1d-4df5-8197-a060b73f80c0

Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014d32d06c969c5ab1
Upwork Job ID: 1661854565030178816
Last Price Increase: 2023-06-21

melvin-bot[bot] commented 1 year ago

@MariaHCD @sonialiap @aimane-chnaif this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] commented 1 year ago

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

ahmedGaber93 commented 1 year ago

@aimane-chnaif what do you think of the fixes here?

ahmedGaber93 commented 1 year ago

Proposal

Updated

sonialiap commented 1 year ago

@aimane-chnaif proposals have been updated, could you please review them?

aimane-chnaif commented 1 year ago

reduce itemVisiblePercentThreshold: 95 to 75 will fix quick swipe.

We should be careful to update this value. It should be based on best user experience after bunch of testing. @ahmedGaber93 can you apply all updated solutions to your branch? I will test again.

aimane-chnaif commented 1 year ago

@sonialiap what do you think of this?

sonialiap commented 1 year ago

@aimane-chnaif if the scope has increased, we can consider increasing the bounty 👍 Do you have a proposal for how much you think the scope has increased and to what we should increase the bounty?

aimane-chnaif commented 1 year ago

OP:

When the user navigates away from the PDF password form to other attachments by swiping, dismiss the keyboard
When the user navigates away from the PDF password form by clicking on the arrow buttons, dismiss the keyboard

Increased scope:

When the user clicks on the eye icon while the keyboard is open, it should toggle immediately without dismissing keyboard
When the user navigates back to the PDF password form, focus the input and bring up the keyboard again
(optional) Fix edge case bugs as much as possible

Fair amount: 2k

MariaHCD commented 1 year ago

That sounds fair to me 👍🏼

ahmedGaber93 commented 1 year ago

@aimane-chnaif my updated branch.

dukenv0307 commented 1 year ago

@aimane-chnaif hi what do you think about my updates here?

sonialiap commented 1 year ago

The new amount sounds good to me as well, updating the title and upwork bounty

melvin-bot[bot] commented 1 year ago

Upwork job price has been updated to $2000

aimane-chnaif commented 1 year ago

@dukenv0307 I see the only difference from your proposal is on which event to dismiss keyboard, right?

dukenv0307 commented 1 year ago

@aimane-chnaif There're 2 main differences:

on which event to dismiss keyboard
how the activeSource is passed that helps refocus the password input

My approach will help avoid most of your mentioned issues (without touching things like itemVisiblePercentThreshold), feel free to test in my branch

Also the remaining similarities are first suggested by me through-out the discussion when we discuss the scope increase, not that those of mine are similar but later 😅

aimane-chnaif commented 1 year ago

@MariaHCD, @dukenv0307's solution is better and tests well. So I 🎀 on @dukenv0307's proposal and we can continue PR.

MariaHCD commented 1 year ago

@dukenv0307's solution looks good to me too.

MariaHCD commented 1 year ago

Oops, this was labelled internal. Resetting back to external.

melvin-bot[bot] commented 1 year ago

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

📣 @dukenv0307 You have been assigned to this job by @MariaHCD! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

dukenv0307 commented 1 year ago

@aimane-chnaif https://github.com/Expensify/App/pull/21367 The PR is ready for review

melvin-bot[bot] commented 1 year ago

🎯 ⚡️ Woah @aimane-chnaif / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @dukenv0307 got assigned: 2023-06-22 16:24:21 Z
when the PR got merged: 2023-06-26 15:24:04 UTC

On to the next one 🚀

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.33-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/21367

If no regressions arise, payment will be issued on 2023-07-05. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
[ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

aimane-chnaif commented 1 year ago

No PRs caused regression. These were missing cases while implementing new feature of attachment carousel.

Regression Test Step:

Go to any chat room
Send multiple attachments including protected PDF
Click preview on protected PDF -> Press Enter a password
Click 👁️ while keyboard is open
Verify that it toggles immediately without dismissing keyboard
Navigates away from the PDF password form by clicking on the arrow buttons or by swiping
Verify that keyboard is dismissed automatically
Navigate back to the PDF password form
Verify that password input is focused automatically and bring up the keyboard again

sonialiap commented 1 year ago

@dukenv0307 offer sent for fix (+bonus) - paid ✔️ @aimane-chnaif offer sent for review (+bonus) - paid ✔️